Received: by 2002:ac0:a5a6:0:0:0:0:0 with SMTP id m35-v6csp48253imm; Wed, 5 Sep 2018 14:44:53 -0700 (PDT) X-Google-Smtp-Source: ANB0VdYpHamvQUjcS25aUSBoHxuKOg4zWT/3mq+iR3HRkmkapyeHe1vTtt/i5O9tKPRtAanQn0pg X-Received: by 2002:a62:3545:: with SMTP id c66-v6mr42584942pfa.63.1536183893219; Wed, 05 Sep 2018 14:44:53 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1536183893; cv=none; d=google.com; s=arc-20160816; b=U4YRoB8EHS9IULtSM10jiT8wC687AB1VEkhsVlwNcnT9zZyrmfM7VoLZdSYwBZdh0G yiyIq9iV2eRrbqu/xVr0xVt1DQw1uHHXBB0n6SM7xFNKJ334bYbCcLgKGHxaVbXZhWcR zaUfO+V6QAosVrqt7alOpu8RYd30JlrOyci1RunAB8pddAMrPLmlE3isweCoZdgoEr2J GEG/1bm4brzb4INTg41xaKDKsDxOwnRTMY0eol0r0bG4gqDUX1sa8w5bzqBbvVSCsSlx 5nnJQayynoFOceWQzQSMXZOkscI5RP1+XK19GzUrpAJ66zeQZGdPH03sxzgiCfxBgIso GSRA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=qXZubM8MF/Lw3QDANhwRZtFYSjHznjc5hICQlHp7cko=; b=RFGDuytArahaiUe5MPYEXiRwVDLugcCsrxKIS1+CvQSbzlmwSPgPN46T/grQz2BLQL 5rNuU+8JWgupPE0ujnAp9Hv7h+F+xGZc6gvH0Ai9XlEuIWNpoOVp7Xvy8PTgj2YnROo/ PVAQ+f560Rw15xmLaVSgtOn3tLA0yk5JyQDnJ6PVF8EHXIa/zwobVVJczB5Lb1ROpI69 7VnbTxEkci0Jq3R1fElTrCpvwbGdOodfxvPS4i1Y/ca1wj+QZOOERr8o1qq6MwOofHor nH1ucXWx/mR2aqmSLJGNV7lxg0QC5sYQAYVfTdGvpnCHRO43Kk1gdmTyC+Bu0xGbUCjJ yGqQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@cmpxchg-org.20150623.gappssmtp.com header.s=20150623 header.b=M+iAuvG3; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=cmpxchg.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id a27-v6si3223086pfh.164.2018.09.05.14.44.33; Wed, 05 Sep 2018 14:44:53 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@cmpxchg-org.20150623.gappssmtp.com header.s=20150623 header.b=M+iAuvG3; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=cmpxchg.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727657AbeIFCPL (ORCPT + 99 others); Wed, 5 Sep 2018 22:15:11 -0400 Received: from mail-yb1-f196.google.com ([209.85.219.196]:44250 "EHLO mail-yb1-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727069AbeIFCPL (ORCPT ); Wed, 5 Sep 2018 22:15:11 -0400 Received: by mail-yb1-f196.google.com with SMTP id l16-v6so3299705ybk.11 for ; Wed, 05 Sep 2018 14:43:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cmpxchg-org.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=qXZubM8MF/Lw3QDANhwRZtFYSjHznjc5hICQlHp7cko=; b=M+iAuvG3nZuE+iAp8SieNDJtUSc+tUkG89ZfAYtfxK5ugvz93f4eDUzpQ7mO511D0G WCpqluaGB+8oMV+TYwpyJ2M5HYjOyXj+FUw4KIu4/sOoHF7UBxwRPBAv4gKuS/jloHts Z2BH6dIP18ZJkH6qVow1nkgDBjejunAgC07Usz0O6ifZ7ORxO1orGcM/0bsfD271p6O4 4j9oW1PFKRQi1pNd/kHU7+I8NPaCGcqe/KcMulVod/1ktFig4wloJUY4d47nGmPrPTxf DoHaZsx0U8+8WJF2ZFMdY4ypmPH+ibIUZkhdCItDdSOLd1hSVrkb7R3o6xwTQanZEWbe K2Gg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=qXZubM8MF/Lw3QDANhwRZtFYSjHznjc5hICQlHp7cko=; b=A50tw3HUvCvaZAKcWf0mXsamgItXk+Z7xFgK1DUoidrgsP34J55hTtmtUpoFD0ZUE6 nNP4Ys8wtQ+NoxhFwsnh5pE9kN9XMCgJWgS65BAwG9BCmvSOAF83T+E5tXzG0xz091vH hipAInZ8x7+JC5tNNSh2cFHRLg17XLi7KQaNX9BDkTUoeKlCMxb3Hp0YwfKdydsxBFTy RCG+kwdQHbm3IRmqw9qQglbKcfK9omBY3NTXTzXWyvpurPzVES6L/V692li3BSR61cQv qXIZdXxPU2mBw3O+/09ToiAU6E91Q99uwJnCJ/AxU3ynEnh11PM6N/b5cTszU8cqtXTR 6QSQ== X-Gm-Message-State: APzg51D9h3OibikwccbDM3oNUqqLxUpHL0eTR+oEdvk6QKgU9qpUVDfd 9QFEs6JZIQ+JiQWjaM0dkcPt+A== X-Received: by 2002:a25:bdcb:: with SMTP id g11-v6mr21206517ybk.494.1536183785217; Wed, 05 Sep 2018 14:43:05 -0700 (PDT) Received: from localhost ([2620:10d:c091:200::3622]) by smtp.gmail.com with ESMTPSA id e124-v6sm1017519ywh.66.2018.09.05.14.43.03 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Wed, 05 Sep 2018 14:43:03 -0700 (PDT) Date: Wed, 5 Sep 2018 17:43:03 -0400 From: Johannes Weiner To: Ingo Molnar , Peter Zijlstra , Andrew Morton , Linus Torvalds Cc: Tejun Heo , Suren Baghdasaryan , Daniel Drake , Vinayak Menon , Christopher Lameter , Peter Enderborg , Shakeel Butt , Mike Galbraith , linux-mm@kvack.org, cgroups@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-team@fb.com Subject: Re: [PATCH 0/9] psi: pressure stall information for CPU, memory, and IO v4 Message-ID: <20180905214303.GA30178@cmpxchg.org> References: <20180828172258.3185-1-hannes@cmpxchg.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20180828172258.3185-1-hannes@cmpxchg.org> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Aug 28, 2018 at 01:22:49PM -0400, Johannes Weiner wrote: > This version 4 of the PSI series incorporates feedback from Peter and > fixes two races in the lockless aggregator that Suren found in his > testing and which caused the sample calculation to sometimes underflow > and record bogusly large samples; details at the bottom of this email. Peter, do the changes from v3 look sane to you? If there aren't any further objections, I was hoping we could get this lined up for 4.20.