Received: by 2002:ac0:a5a6:0:0:0:0:0 with SMTP id m35-v6csp51105imm; Wed, 5 Sep 2018 14:48:50 -0700 (PDT) X-Google-Smtp-Source: ANB0VdaFNdtN9ALUaZI27ne0383me7fXhyDRviZJmFgDzX8h+t26QOihz0duBM7C19yOqcvP22fF X-Received: by 2002:a62:f5c1:: with SMTP id b62-v6mr43260690pfm.158.1536184130357; Wed, 05 Sep 2018 14:48:50 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1536184130; cv=none; d=google.com; s=arc-20160816; b=Uc1SFViHaM749sC5wDg+MDBNclhNh9uU/jNRxDWUc6GcHQibZe8GuI74IS/lfZWj8G WkVyFRVYY9h2XfxlZVWPLr8qq0Mp8BqEidApD1WcseHjX59hDan/XIW5K9ejD+HhSitR MV2yC5HX4ZCELWLx2M1MqWwe2azZRjxlG5oQL5A9lrEmnHEifZjcV2MojuXFX4lhBUFj 1vFBNgK8NhMQzoalqWSSzNYnz/D+KvBurhbbtSpqHn8IMnoLA2a8desqQ8CGkOWPVmfV 7Nw0SJ8+F/ynDOJwiQxcPE0i4mhPv6VwqhD0yck5rKHXmiS9hEds7M/GiIHq5Ix1Zto6 lY6A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date; bh=ivmX6aPP80pGtRP8ugLEaVr6z5WB3Izant9YhLUzCqQ=; b=sYcK8WbbbC2JCdk5FkhddzUVcfXjOq3Q5D6O4A0ERq39tdqrm3rMIBeYN/9jvHqA0s 35X8xXDHTgMWRxa74ILQ1ZE9fPUi81NEnH5n8a0qrMgEsrSn8BiXgLc/yb0Rz3lU8TlR G8A72PiE4OnsU7dxnz4vh7WVBpE++NwlgvWvg6s4L4zLz3BEjIi5ExVD4frDX1H2bOQP Uu1VAE4SX2BoYZLFKutO1oOhfWyilz/wMhpxcGmJFH9oguYRk3Id4I342Vtoz9f134m7 Pl/GkZUCJm5btRESQl17WEvFRddVQlOHOvGSpcT97ONfxOnISit2TeW5XrDkD9uKM6VC h2sQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id d11-v6si3161082pgh.564.2018.09.05.14.48.33; Wed, 05 Sep 2018 14:48:50 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727665AbeIFCTO (ORCPT + 99 others); Wed, 5 Sep 2018 22:19:14 -0400 Received: from mga17.intel.com ([192.55.52.151]:7133 "EHLO mga17.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727364AbeIFCTO (ORCPT ); Wed, 5 Sep 2018 22:19:14 -0400 X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by fmsmga107.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 05 Sep 2018 14:47:08 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.53,334,1531810800"; d="scan'208";a="67844584" Received: from tassilo.jf.intel.com (HELO tassilo.localdomain) ([10.7.201.126]) by fmsmga007.fm.intel.com with ESMTP; 05 Sep 2018 14:47:06 -0700 Received: by tassilo.localdomain (Postfix, from userid 1000) id AB0EA300B65; Wed, 5 Sep 2018 14:47:07 -0700 (PDT) Date: Wed, 5 Sep 2018 14:47:07 -0700 From: Andi Kleen To: Eduardo Valentin Cc: Peter Zijlstra , Thomas Gleixner , Ingo Molnar , "H. Peter Anvin" , x86@kernel.org, Kan Liang , Dan Carpenter , Jia Zhang , Greg Kroah-Hartman , linux-kernel@vger.kernel.org Subject: Re: [PATCHv2 1/1] perf/x86/intel: make error messages less confusing Message-ID: <20180905214707.GM27886@tassilo.jf.intel.com> References: <20180823150732.11249-1-eduval@amazon.com> <20180905085212.GS24124@hirez.programming.kicks-ass.net> <20180905155317.GA20320@u40b0340c692b58f6553c.ant.amazon.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20180905155317.GA20320@u40b0340c692b58f6553c.ant.amazon.com> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Sep 05, 2018 at 08:53:17AM -0700, Eduardo Valentin wrote: > On Wed, Sep 05, 2018 at 10:52:12AM +0200, Peter Zijlstra wrote: > > On Thu, Aug 23, 2018 at 08:07:32AM -0700, Eduardo Valentin wrote: > > > On a system with X86_FEATURE_ARCH_PERFMON disabled > > > and with a model not known by family PMU drivers, > > > user gets a kernel message log like the following: > > > [ 0.100114] Performance Events: unsupported p6 CPU model 85 no PMU driver, software events only. > > > > > > The "unsupported .. CPU" part may be confusing for some > > > users leading to wrong understanding that the kernel > > > does not support the CPU model. > > > > Send them back to first grade, such that they might learn to read? > > > > :-) I think it's a valid concern, I guess Eduardo actually has real people who got confused. -Andi