Received: by 2002:ac0:a5a6:0:0:0:0:0 with SMTP id m35-v6csp55519imm; Wed, 5 Sep 2018 14:54:46 -0700 (PDT) X-Google-Smtp-Source: ANB0VdaoOM84uL6kgyF/O+BZDtwrovAtrnMRRZHLb1+I3dl7/3wReh4s9K/MGomv9JCTZgD637Wq X-Received: by 2002:a17:902:6b05:: with SMTP id o5-v6mr41385576plk.338.1536184486075; Wed, 05 Sep 2018 14:54:46 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1536184486; cv=none; d=google.com; s=arc-20160816; b=EOGihH5TOVAw4CGH0IY6jciNy7X9vkIDGLeiZQpvMNQR8zEcKjd2qcB0cuB2tkZTZ9 4tXkdhdq+wg5FfoLOnvIFYRtNuxuAnoruCVEJ5wQbPDUPZaQMZwvfByy1Pu0KQzz0Y7U tu5olutcgBtnGxgU2Jcy12QikfCbvxsFkydo+nJ5CV0T8A9NMJ2QfS1UTNpmpu3lG2we OtFimc9F+vWXj/FvTAHD1fHa1L/tEejNlecY8bBrF3w0VYBIh31M2d+up4FpeCU9WUam jYwWZDb3X3Xn8Pu4rb2hWA/yRgZSF3ILmsMpd7xEIvps2ehf95iSS9J1e3hS3pKHUjCl fZow== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=ezltiUevTcWAmCudjI3HEsT0UbUUXDNIEqFkM+sJjr4=; b=IEfnlWuTurk7XLh+3JdQOlUQ9me6ccsQn4i6iIyvLmU8QL8k1Yx545TelwJkLdp/xz 5x/mxu7CJC9OVtbp2+QmN4pClWk2ABRSrEZw3WqBfUvVUwr8nTG6Wn859OepBORNrWMp GMl2m/+TAWbhxs3SShjSX0iJ9XYHcJulh0qpLomQdYPOF54qS4PxSBoFcuO1i9j9Y2Ue ZsFLD0KOmDJhbU1XVMInzBokAWBBSOyAEZX/ecByIlpZ5+XVgbRZlxROsmpIUJUmDRSz 1HYpy16Ggmdh5Q6vFwLatTzgGDotK6sO2LW0urqDyC48/DTdi9awvnUt0yNzMrBzkS+w axtg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@ziepe.ca header.s=google header.b=Nhk49a01; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id y1-v6si3130625pli.412.2018.09.05.14.54.20; Wed, 05 Sep 2018 14:54:46 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@ziepe.ca header.s=google header.b=Nhk49a01; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727707AbeIFCZJ (ORCPT + 99 others); Wed, 5 Sep 2018 22:25:09 -0400 Received: from mail-pf1-f196.google.com ([209.85.210.196]:36896 "EHLO mail-pf1-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727572AbeIFCZI (ORCPT ); Wed, 5 Sep 2018 22:25:08 -0400 Received: by mail-pf1-f196.google.com with SMTP id h69-v6so4156601pfd.4 for ; Wed, 05 Sep 2018 14:53:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ziepe.ca; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=ezltiUevTcWAmCudjI3HEsT0UbUUXDNIEqFkM+sJjr4=; b=Nhk49a01hLFRBqGTHwagLTjEkSNG57OTVOn12TetIGPIz6666hFzbCNtDxkmjOJMfr bHfeYjCxKi9tg4J2jH2JOrPweLrghDMNS8hM+42Ugz/fRQ3/1eIAQva209KDFm95y1Mu K9bEI9Oy3Yf1zsUpXdHfgvQpwhRTmaOaRiiSwwMF9Yjs+l87L3w6CfI0hcKd0d6CagwJ 9QfXNB9cu4U+P7WKM+/nE25TvmXQzvmCM4JxHXxH7UE7lW0HJ1d7G4g353pk36xqsRjX s5EnDAO25cjlvoEAhEjFZvWFh9An4g2HblDH1IAIz209q3sc7Qee/J4Al+jgNNmmnl2f Q2UA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=ezltiUevTcWAmCudjI3HEsT0UbUUXDNIEqFkM+sJjr4=; b=OXLJ3qcVnLVhtRF0FJ3TkTMTpPUnh8fTTrbUy4zfox4m+R6GmVyIMBtZkaUgTiP3MI E7sojZxHYZgO7Lq918eOMMjBgKrenmW0DuNPyVdwMYNJKOMNEnumyxqoFs6STTVtcatX RlVCZnqAgrxHXEo7+FsbMf9+GKiSzIg9F9XRFIYEzAMJFFlIBQv/Kh1vUghvBVYDd3+y 2XUDy4OfueLjSD+qfOp+z7WA1ltuw4lXwZevbEFE4G/0PxwyHSeCBVV99GDSBtgfpqUY a+VVFIYIo7L96SNDSZWp8zaMT2r3IZ1fCYrNcjDyAQT7EAeSUUXELFRcmgIQBJN6EKuC DXmQ== X-Gm-Message-State: APzg51COFZQjDKiojk5OkKCaGs9oc8yWMlaccYWvaCy3G+CAKKYjQ8SC of72ZfoF0E5HoK8xP8MgaJREBg== X-Received: by 2002:a63:586:: with SMTP id 128-v6mr38831639pgf.169.1536184381180; Wed, 05 Sep 2018 14:53:01 -0700 (PDT) Received: from ziepe.ca (S010614cc2056d97f.ed.shawcable.net. [174.3.196.123]) by smtp.gmail.com with ESMTPSA id q85-v6sm4516743pfa.151.2018.09.05.14.53.00 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Wed, 05 Sep 2018 14:53:00 -0700 (PDT) Received: from jgg by mlx.ziepe.ca with local (Exim 4.90_1) (envelope-from ) id 1fxfjP-0007AF-Ik; Wed, 05 Sep 2018 15:52:59 -0600 Date: Wed, 5 Sep 2018 15:52:59 -0600 From: Jason Gunthorpe To: Igor Stoppa Cc: Bart Van Assche , Igor Stoppa , linux-rdma@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] infiniband: scsi: remove unnecessary unlikely() Message-ID: <20180905215259.GA27512@ziepe.ca> References: <20180831201645.15611-1-igor.stoppa@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20180831201645.15611-1-igor.stoppa@huawei.com> User-Agent: Mutt/1.9.4 (2018-02-28) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Aug 31, 2018 at 11:16:45PM +0300, Igor Stoppa wrote: > WARN_ON() already contains an unlikely(), so it's not necessary to > wrap it into another. > > Signed-off-by: Igor Stoppa > Reviewed-by: Bart Van Assche > Cc: linux-rdma@vger.kernel.org (open list:SCSI RDMA PROTOCOL (SRP) TARGET) > Cc: linux-kernel@vger.kernel.org (open list) > --- > drivers/infiniband/ulp/srpt/ib_srpt.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Applied to for-next, thanks Jason