Received: by 2002:ac0:a5a6:0:0:0:0:0 with SMTP id m35-v6csp69358imm; Wed, 5 Sep 2018 15:09:07 -0700 (PDT) X-Google-Smtp-Source: ANB0VdavQsVxhUd1N2a48LJb5sHrpWGYWZdIKB0vGH5vVphO7yeRB3ENQ//W21oSOdUTvcnYkTVJ X-Received: by 2002:a63:41c4:: with SMTP id o187-v6mr31201206pga.297.1536185347216; Wed, 05 Sep 2018 15:09:07 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1536185347; cv=none; d=google.com; s=arc-20160816; b=o7PH7DmCSGFezlLJyYiHVKISamM58ZIx0dM3NWAMArXPUO03ZcPyBvi6nylAoBK+Rd hlXtciyeDLqWhpcmQFxZotVl7WO7iJ4gz6cGcmJMLD6AbhTftlnk0ilo75PxOYI50MHM rDxOASqq6wiaLMzUUlPXQ1PTshxmPd5+WqnkPJHlMH+Rb/uDqn4UEwefn+JtOFkWktiU WeVelG6WxK/gzahLs/o/Y+xmj8vncWaAVRZ2gwU97S025t6cwSTv8D8uwwL8DhhxOezh 30y0vP/IVDJJTVRWy+sQXyV3E0bYevRVjrPbkTRrVe4flGhJnWPLH3bSbGibxddEBrGM 2gFg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:references:in-reply-to:message-id:date :subject:cc:to:from:dkim-signature; bh=nczrQs/w/1VuxCAE712qbEGi7lgxQN7gt3JF9covVlU=; b=k2mvQNdKRXo7l4yLRubQMJ4n0kKugWprKaqovJ0OLGoWClhM9MAPa/GZLlDT/T6CAv vaaOoQ503MJru/N+DEbVkyeKOb4HiLuIImW70o2pIAs2w9W7lgoUKOL1OtuuHnLOh7pc XNHQyw9v5uOhOm0j4oyt4AnNCyo286LwL9DhJjBBK8YcL8E92m2Ith+Hvv8F6RJ4QEsx PluiqQN/qathA96FNuRAgXlaPQletbsAKbVeBMhvHuySmUWprw07jEtqB5MSQ1c9eLDz b7eD45BMFIVzxl7VySCrqEO+CoGbQxIbxpx3MONGVq6gcQs5Yj5QBEGHoceCe02XVz4T aqog== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=Bi7Xo7fh; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id q17-v6si3272692pfi.183.2018.09.05.15.08.51; Wed, 05 Sep 2018 15:09:07 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=Bi7Xo7fh; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728745AbeIFCjK (ORCPT + 99 others); Wed, 5 Sep 2018 22:39:10 -0400 Received: from mail.kernel.org ([198.145.29.99]:53854 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727593AbeIFCjK (ORCPT ); Wed, 5 Sep 2018 22:39:10 -0400 Received: from jouet.infradead.org (unknown [179.97.41.186]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id CABD420857; Wed, 5 Sep 2018 22:06:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1536185218; bh=x885VOy6dgL9dM2MBUulGXeAhOWlBh1Rto34TRHk5UQ=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=Bi7Xo7fhsecUe/uf50oqnPFAN8wZpVzP30bVLIfpdpsLYPLXvTlCwYY7gCTVpgKXC +nhj9z2unAWUmJDnQq5EODrZNBshCj7AEcResy9nuL0djJxESiWSD+rFgCFmf9BWrx J5aR3c/FlzT9ku9a0/aAgCPR77XOiN6c8/wRauD0= From: Arnaldo Carvalho de Melo To: Ingo Molnar Cc: Clark Williams , linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org, Jiri Olsa , Alexander Shishkin , Andi Kleen , David Ahern , Namhyung Kim , Peter Zijlstra , Arnaldo Carvalho de Melo Subject: [PATCH 46/77] perf stat: Move 'interval_clear' to 'struct perf_stat_config' Date: Wed, 5 Sep 2018 19:04:09 -0300 Message-Id: <20180905220440.20256-47-acme@kernel.org> X-Mailer: git-send-email 2.14.4 In-Reply-To: <20180905220440.20256-1-acme@kernel.org> References: <20180905220440.20256-1-acme@kernel.org> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Jiri Olsa Move the static 'interval_clear' variable to 'struct perf_stat_config', so it can be passed around and used outside the 'perf stat' command. Signed-off-by: Jiri Olsa Cc: Alexander Shishkin Cc: Andi Kleen Cc: David Ahern Cc: Namhyung Kim Cc: Peter Zijlstra Link: http://lkml.kernel.org/r/20180830063252.23729-22-jolsa@kernel.org Signed-off-by: Arnaldo Carvalho de Melo --- tools/perf/builtin-stat.c | 9 ++++----- tools/perf/util/stat.h | 1 + 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/tools/perf/builtin-stat.c b/tools/perf/builtin-stat.c index 4c29e5065e02..89297ab77d21 100644 --- a/tools/perf/builtin-stat.c +++ b/tools/perf/builtin-stat.c @@ -172,7 +172,6 @@ static struct cpu_map *aggr_map; static aggr_get_id_t aggr_get_id; static bool append_file; static bool interval_count; -static bool interval_clear; static const char *output_name; static int output_fd; static int print_free_counters_hint; @@ -1544,12 +1543,12 @@ static void print_interval(struct perf_stat_config *config, FILE *output = config->output; static int num_print_interval; - if (interval_clear) + if (config->interval_clear) puts(CONSOLE_CLEAR); sprintf(prefix, "%6lu.%09lu%s", ts->tv_sec, ts->tv_nsec, config->csv_sep); - if ((num_print_interval == 0 && !config->csv_output) || interval_clear) { + if ((num_print_interval == 0 && !config->csv_output) || config->interval_clear) { switch (config->aggr_mode) { case AGGR_SOCKET: fprintf(output, "# time socket cpus"); @@ -1581,7 +1580,7 @@ static void print_interval(struct perf_stat_config *config, } } - if ((num_print_interval == 0 || interval_clear) && metric_only) + if ((num_print_interval == 0 || config->interval_clear) && metric_only) print_metric_headers(config, " ", true); if (++num_print_interval == 25) num_print_interval = 0; @@ -1911,7 +1910,7 @@ static const struct option stat_options[] = { "(overhead is possible for values <= 100ms)"), OPT_INTEGER(0, "interval-count", &stat_config.times, "print counts for fixed number of times"), - OPT_BOOLEAN(0, "interval-clear", &interval_clear, + OPT_BOOLEAN(0, "interval-clear", &stat_config.interval_clear, "clear screen in between new interval"), OPT_UINTEGER(0, "timeout", &stat_config.timeout, "stop workload and print counts after a timeout period in ms (>= 10ms)"), diff --git a/tools/perf/util/stat.h b/tools/perf/util/stat.h index 18546d8b0279..470ab37601be 100644 --- a/tools/perf/util/stat.h +++ b/tools/perf/util/stat.h @@ -92,6 +92,7 @@ struct perf_stat_config { bool no_inherit; bool identifier; bool csv_output; + bool interval_clear; FILE *output; unsigned int interval; unsigned int timeout; -- 2.14.4