Received: by 2002:ac0:a5a6:0:0:0:0:0 with SMTP id m35-v6csp72870imm; Wed, 5 Sep 2018 15:12:45 -0700 (PDT) X-Google-Smtp-Source: ANB0VdbrJCyvsu/03ixvs0f4NYVfKb5BBPk9biltjcMT2KZ/JU0R/id2w9C+ylG+HBuLMi8jwt5C X-Received: by 2002:a63:731b:: with SMTP id o27-v6mr5785002pgc.216.1536185565126; Wed, 05 Sep 2018 15:12:45 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1536185565; cv=none; d=google.com; s=arc-20160816; b=Qyun2SbLv9z/paCb1IE0ZXc5dbdkcIvW6qs2arSHG3kDe85xbIZ7goifWPnvCzUD4V XQVOhyA6okh2g7Ckx06PMUKUkVXJLkdbkNXN1TWOH1NVtD8m22ObeDrr6yiomgDnOCGS i7dYKVMR2Qbt1XNXcZgqNNDb6kz6hgksRZvL1DhP8dCdDvcFL5k9wHfeLNBo/n041BpH qy6gaSrlyxCIoeLykTpxTbqapR6/ZDiYZnmGN0eNwP/wnv5Z4z5nm4Gc/toqG3Y4fcjW N0OeUtsu87jomzJSZp8260pPidjlQgMv24e3gtcE6L2i2XfhLtKaFeoFdcPlxBcm4m3Q VFeg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:references:in-reply-to:message-id:date :subject:cc:to:from:dkim-signature; bh=tN6t44aT/DHmEg/4GwyAsZEGVP++0f/oejv6+wDaJs4=; b=bToooBxo+AkuWoVjqtTl2kr3hxio5BScE6OJUZ37uLU4rVAA/eFWaMwmukzwMalFDl Qbt1QO53gPkSAA8vkcCJD0xm5rKm6iPOufG6TFzbJ8r8uEQwM2bbii+3H9+sRYErdsds jafx1jPGw2h4h9tCNUnoGUlDt3aTrMUCeNfHMYDWGz0icubuswjm6BivKmW5lU1BTecy Gt5gk3XIRna+kseynboyitpAMhKf05fTcu7VwkHn86bJoJJkcJHAmFvNr9Y/lSSSgm41 Zhx4TgvjeHQCzgeLXnh02FIPW7nFXI8wdBVCOzPRbI3/N8wjketIw4LxfTDYR8cThQeH IU/Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=BCKK0O22; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id q6-v6si1570848pgk.94.2018.09.05.15.12.26; Wed, 05 Sep 2018 15:12:45 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=BCKK0O22; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728835AbeIFCja (ORCPT + 99 others); Wed, 5 Sep 2018 22:39:30 -0400 Received: from mail.kernel.org ([198.145.29.99]:54298 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727593AbeIFCj3 (ORCPT ); Wed, 5 Sep 2018 22:39:29 -0400 Received: from jouet.infradead.org (unknown [179.97.41.186]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 3CF0620857; Wed, 5 Sep 2018 22:07:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1536185237; bh=VIqtUgiBUVvXRmVpjFvp36MHI/D6vgj9CYKLQjQedjY=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=BCKK0O22pdCNPrQM+Hj09JBb2N/YCcKrpH4cbN4vvjVz2Rx42YxYTSVciAgxJGXV+ 2p/8dFgDbuhbC2dhAmBz4/VqbQu0FPW8PgPkGVHRCNQFpOI5PWjCDb5Z1zw9i/hvpx 419MxKqmj80t129vVZx+sQonvY3rLYv0gcY5bpK4= From: Arnaldo Carvalho de Melo To: Ingo Molnar Cc: Clark Williams , linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org, Jiri Olsa , Alexander Shishkin , Andi Kleen , David Ahern , Namhyung Kim , Peter Zijlstra , Arnaldo Carvalho de Melo Subject: [PATCH 53/77] perf stat: Move 'metric_only_len' to 'struct perf_stat_config' Date: Wed, 5 Sep 2018 19:04:16 -0300 Message-Id: <20180905220440.20256-54-acme@kernel.org> X-Mailer: git-send-email 2.14.4 In-Reply-To: <20180905220440.20256-1-acme@kernel.org> References: <20180905220440.20256-1-acme@kernel.org> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Jiri Olsa Move the static 'metric_only_len' variable to 'struct perf_stat_config', so that it can be passed around and used outside the 'perf stat' command. Signed-off-by: Jiri Olsa Cc: Alexander Shishkin Cc: Andi Kleen Cc: David Ahern Cc: Namhyung Kim Cc: Peter Zijlstra Link: http://lkml.kernel.org/r/20180830063252.23729-29-jolsa@kernel.org Signed-off-by: Arnaldo Carvalho de Melo --- tools/perf/builtin-stat.c | 10 +++++----- tools/perf/util/stat.h | 1 + 2 files changed, 6 insertions(+), 5 deletions(-) diff --git a/tools/perf/builtin-stat.c b/tools/perf/builtin-stat.c index 1276596840c9..e96cef526ef0 100644 --- a/tools/perf/builtin-stat.c +++ b/tools/perf/builtin-stat.c @@ -176,7 +176,6 @@ static int print_mixed_hw_group_error; static u64 *walltime_run; static bool ru_display = false; static struct rusage ru_data; -static unsigned int metric_only_len = METRIC_ONLY_LEN; struct perf_stat { bool record; @@ -200,6 +199,7 @@ static struct perf_stat_config stat_config = { .scale = true, .unit_width = 4, /* strlen("unit") */ .run_count = 1, + .metric_only_len = METRIC_ONLY_LEN, }; static bool is_duration_time(struct perf_evsel *evsel) @@ -854,14 +854,14 @@ static const char *fixunit(char *buf, struct perf_evsel *evsel, return unit; } -static void print_metric_only(struct perf_stat_config *config __maybe_unused, +static void print_metric_only(struct perf_stat_config *config, void *ctx, const char *color, const char *fmt, const char *unit, double val) { struct outstate *os = ctx; FILE *out = os->fh; char buf[1024], str[1024]; - unsigned mlen = metric_only_len; + unsigned mlen = config->metric_only_len; if (!valid_only_metric(unit)) return; @@ -902,7 +902,7 @@ static void new_line_metric(struct perf_stat_config *config __maybe_unused, { } -static void print_metric_header(struct perf_stat_config *config __maybe_unused, +static void print_metric_header(struct perf_stat_config *config, void *ctx, const char *color __maybe_unused, const char *fmt __maybe_unused, const char *unit, double val __maybe_unused) @@ -916,7 +916,7 @@ static void print_metric_header(struct perf_stat_config *config __maybe_unused, if (config->csv_output) fprintf(os->fh, "%s%s", unit, config->csv_sep); else - fprintf(os->fh, "%*s ", metric_only_len, unit); + fprintf(os->fh, "%*s ", config->metric_only_len, unit); } static int first_shadow_cpu(struct perf_evsel *evsel, int id) diff --git a/tools/perf/util/stat.h b/tools/perf/util/stat.h index 351a36f5f5b0..e70e6d93ee1b 100644 --- a/tools/perf/util/stat.h +++ b/tools/perf/util/stat.h @@ -99,6 +99,7 @@ struct perf_stat_config { unsigned int timeout; unsigned int initial_delay; unsigned int unit_width; + unsigned int metric_only_len; int times; int run_count; struct runtime_stat *stats; -- 2.14.4