Received: by 2002:ac0:a5a6:0:0:0:0:0 with SMTP id m35-v6csp136581imm; Wed, 5 Sep 2018 16:32:43 -0700 (PDT) X-Google-Smtp-Source: ANB0VdaYVjUPs0N3/dx1Fbb3zOiym/kKi/tGUNa9cz5t4SINi88MxvCDG9z1PJWQETPneuwX6Krg X-Received: by 2002:a65:4849:: with SMTP id i9-v6mr70009pgs.350.1536190363085; Wed, 05 Sep 2018 16:32:43 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1536190363; cv=none; d=google.com; s=arc-20160816; b=AvkT97HeOsc19SdDIlQE/j+RNMZRk/xfji5c+khGvhVOgQ+N9waaU80un0DDGAUDXk 4rz76fnyPo47dAyHiHDxJub/Vsi08Q0gB8laqCKN3soBxM7MsXiRPPKVHo3TyGfQ9eA1 +t3/68M8VKTl/H/dc6SCZYXzVNt4DtxXA7W0c6bD/l37KDicNjgygAi5cGB9p7U7MRQV jmHykTE++YdVLIHBp7NSS9W8DRsidkks7NY54sP/pbtzzuN+TneCK6Clpwz5muLM5rHu J+641eYzByIsLnBdxLuOv5WBkCbguvfHr3sKyx34jdSGQSVilVmzWheponXS9ObTOmQF 5Aqg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:cc:to:subject:message-id:date:from :references:in-reply-to:mime-version:dkim-signature; bh=n5roczbVBjuyr3RkTd7v8JkHuLRrvCkLrxlQRyWV2FQ=; b=nvtgZxxmQREHzdkbIeHGMZw5jMV060CaZ7wxpvT0VTev6THC5kigul06CvCsP2NClz 8c9sUALjddk6FB1Tb0JyevtpYz1G/HNaMHVR22qXT8AiH0ztIMOXjlAoUj968duwazkI mtRrMWr2EwZZkrPFHWsA4rHS7Tqgqz675yK0WvJAyIMJDY95KA/SJEdNz0QI75b5bDUH ZLqmc+WbJPhbWn4NzKrQAh+NDdUFYloWg0KwH7ixwgpuFXBeDAZT+MUSxMcpG2dHNzq0 VvVOiXZ6+UZJPcPTO7lpIMTJUbkj1Q/grxXiz6flq8y9WNN2Wtwdt9kanZ6YwQ5hLBXe nICg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=aDdXC32R; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id k4-v6si3096104pll.118.2018.09.05.16.32.27; Wed, 05 Sep 2018 16:32:43 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=aDdXC32R; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1725913AbeIFEDu (ORCPT + 99 others); Thu, 6 Sep 2018 00:03:50 -0400 Received: from mail-yb1-f195.google.com ([209.85.219.195]:42292 "EHLO mail-yb1-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725741AbeIFEDu (ORCPT ); Thu, 6 Sep 2018 00:03:50 -0400 Received: by mail-yb1-f195.google.com with SMTP id j8-v6so3396787ybg.9 for ; Wed, 05 Sep 2018 16:31:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=n5roczbVBjuyr3RkTd7v8JkHuLRrvCkLrxlQRyWV2FQ=; b=aDdXC32RTQCZktyfg+SqlpTiEZvorCbh4WbM56ADAy5Lrj7RBvnjeUX3szV7Al238C fbF5XWm2itp7vx4PIe0yZbtPCiIJAkp0oVdZ3lvGhYwqVxoBoMWchCfz6Q3/Tq2LoDt9 5NrxYm5/lDlFkblLmghleifOYwofd+eJhxSVA= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=n5roczbVBjuyr3RkTd7v8JkHuLRrvCkLrxlQRyWV2FQ=; b=AmSDtoRe78/+M+6jMCctXUfsP1MIq/76Tu1DpeG7hadDEVBHdWvjh/298hEdApWwoo w2bLUsG+D+Y6WxdYII48VCeT20c1EVb8vp6/xlWe2oBKNF9apaJ08lN5n2W6QGTMLX60 oASuvBhD04H7HA5DLLTTvET4yR4jhuMtFx1CidOM1QO5DxNpf3VFEC2uPNqqLQCzMnDd CQBHniVxOTXRoDvPyKOECm6ncbOZjzmnhsMT5EaMsfx5kI62zlhSgsF3jdmjxzNKumY/ HTE0vMuHUjaq2NjtkgkMuYtS3LW4lCf4wuSiSOdO1ej2hMTltARspHssUkovq+ynK039 rkfQ== X-Gm-Message-State: APzg51BIDQNfG0cqG1YJttihW+HA+jdDaGu9CBm+b7U1NxfuXJugJ+/U d7eY4AwUPXFGDVVBntfXQsPHGZskUqI= X-Received: by 2002:a25:53c3:: with SMTP id h186-v6mr24814ybb.472.1536190281084; Wed, 05 Sep 2018 16:31:21 -0700 (PDT) Received: from mail-yb1-f169.google.com (mail-yb1-f169.google.com. [209.85.219.169]) by smtp.gmail.com with ESMTPSA id p62-v6sm1189900ywh.73.2018.09.05.16.31.19 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 05 Sep 2018 16:31:19 -0700 (PDT) Received: by mail-yb1-f169.google.com with SMTP id h22-v6so3393436ybg.12 for ; Wed, 05 Sep 2018 16:31:19 -0700 (PDT) X-Received: by 2002:a25:a28f:: with SMTP id c15-v6mr19193ybi.137.1536190279091; Wed, 05 Sep 2018 16:31:19 -0700 (PDT) MIME-Version: 1.0 Received: by 2002:a25:5f04:0:0:0:0:0 with HTTP; Wed, 5 Sep 2018 16:31:18 -0700 (PDT) In-Reply-To: <2192189d-b8bb-3233-c9f3-14cbeeddaf34@gmail.com> References: <20180905203443.32289-1-igor.stoppa@huawei.com> <2192189d-b8bb-3233-c9f3-14cbeeddaf34@gmail.com> From: Kees Cook Date: Wed, 5 Sep 2018 16:31:18 -0700 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH] seccomp: remove unnecessary unlikely() To: Igor Stoppa Cc: Igor Stoppa , linux-security-module , LKML Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Sep 5, 2018 at 3:49 PM, Igor Stoppa wrote: > > > On 06/09/18 01:23, Kees Cook wrote: > >> Should I take this, or is it part of your series going somewhere else? > > > It turned out it doesn't really work to have a generic series against 20 > trees :-/ I know that pain very well! > I'm submitting them individually to each subsystem. > So this one is just for security. Sounds good. James, can you take this directly, or would you prefer a pull request from me? -Kees -- Kees Cook Pixel Security