Received: by 2002:ac0:a5a6:0:0:0:0:0 with SMTP id m35-v6csp3315imm; Wed, 5 Sep 2018 17:14:59 -0700 (PDT) X-Google-Smtp-Source: ANB0Vdb5atptwuZWJ2Ap2NtinMOk3oHnbPEM6mY+4krGyuT9OFGOEBYIwTOm/2217ULax2W7xCQT X-Received: by 2002:a62:57dc:: with SMTP id i89-v6mr193200pfj.45.1536192899899; Wed, 05 Sep 2018 17:14:59 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1536192899; cv=none; d=google.com; s=arc-20160816; b=U6TGuAQFHP3e1+J/lYi0K6yBJ/nYmgY3PW69YObMXUlYg0wtN8nIOVapP+LEFNdqDQ xqaQ3NQCySRHD5z/dB7QBI18ki/qHvz9L1/NZ6dO0g4Z5bom6XldT01HV9ZYd6RzoR/x aEHgaQpWEBY62n09qQs19p8HqlqIUu6sy09Y1V6/uJr+BPAjfoUZrBi3Ah00qX82D7Y7 oj85Um6L4OcynMpjpedfv3+viwnvSRxKYa/kZ3eY6INuu/ZmQ7qzvLY38sryglwYzp8H XzEBeXqWPi+w7UFeG6WvdIiXYGErIc/j9OcfWp7fS7MpF0S9vxhujVtHIHfnpVQHuvWW Qemg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:cc:to:subject:message-id:date:from :references:in-reply-to:mime-version:dkim-signature; bh=24pYI4KddXJnrAcu6s0pb76+kLW85+ssqvzp2xeeESI=; b=x7e3hQUTAhCmC86mpmHgBhIdQ5qmkD8Hu4dlJTJ5G0cOvsAwpVu0/ch9CCEFMgg5HM CYwaGe9xsIxz2KGNvDpORwqO241F68L7wH2K3DFyruSkrYShfnxoPAsIVv35XIn/aOKr qehxPamQcMmxMmwRUAGRQarPjnh27m0lhYfpIXkjUZ1dB89gQHnSmKhdTJ2SHPhrfDjS xj20VIGTFDojWAu1Y+c6bQ83DAWU9dPpyQ/XdRaOMFGVgX7sPW7Ei/aYGwUhEIhwEQ2S EqmGOhq7qvIKO+5ungH1+TVUoPcMdnxwmBx6Ar9Z3KRHuypyN6d3he9KCMP/ZjWuqL9z a5WA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=gHvdcBo5; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id w1-v6si3426797pgt.629.2018.09.05.17.14.32; Wed, 05 Sep 2018 17:14:59 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=gHvdcBo5; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726025AbeIFEpp (ORCPT + 99 others); Thu, 6 Sep 2018 00:45:45 -0400 Received: from mail-yw1-f67.google.com ([209.85.161.67]:40318 "EHLO mail-yw1-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725850AbeIFEpp (ORCPT ); Thu, 6 Sep 2018 00:45:45 -0400 Received: by mail-yw1-f67.google.com with SMTP id z143-v6so3389466ywa.7 for ; Wed, 05 Sep 2018 17:13:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=24pYI4KddXJnrAcu6s0pb76+kLW85+ssqvzp2xeeESI=; b=gHvdcBo5VWqbBoKG1aDZRFdvL3zV+mHuWdANPt1IcU+DeNl19BwIf+tqL5oAC9WT+m BmVCv3tqPBH3nCvoT6TmDaIAUtxOnA3l08cHF/zA6IdH+w9ebusP0o1avwH5MpMAlwDK LV7y4NeaImbONd/GOa35KAVHk+gyd5wnHYyxg= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=24pYI4KddXJnrAcu6s0pb76+kLW85+ssqvzp2xeeESI=; b=R97YPJXHFZ3M/eJK1s0THcZg3meFd3uZFK1D7X8DvOsgqRlA8DKe67B9X/IqigSF1B e7X/DLJkA0b2PYgK4+e2OJvMZsJWJZr6OFpMh4qNpF6UKOhzi/+8J2g1VhFLhYO21i6x cjZWN61sXbpvO8zNB0UHu/R8OT1ffV2nHf+zuarborvPYEQbYlEBreSdzo72/oeJxCMk hQ4ARJVkP0m/X0e2zOCCbt/W9EXwOMGZQlG6u91Ue7jFdllOyNrDwrIxHDerCuBtNeSv n2KP/4fPEQ2RZlyKHbMEZ9sKKmNgHQdtessypGQ5OsLPrJsWzLY869dfdzafZ/J5Hhei Cmcg== X-Gm-Message-State: APzg51AX7XKDKsQ6ZIb2TCHJ17Qt3h2dMtB3GbXpZyHameV+7QEK4BM/ 4/zEFfbbRVR2fuM1NpfSVPDRgXHFjfA= X-Received: by 2002:a81:b65f:: with SMTP id h31-v6mr96995ywk.144.1536192788104; Wed, 05 Sep 2018 17:13:08 -0700 (PDT) Received: from mail-yw1-f48.google.com (mail-yw1-f48.google.com. [209.85.161.48]) by smtp.gmail.com with ESMTPSA id n187-v6sm2492933ywn.76.2018.09.05.17.13.06 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 05 Sep 2018 17:13:06 -0700 (PDT) Received: by mail-yw1-f48.google.com with SMTP id x83-v6so3398071ywd.4 for ; Wed, 05 Sep 2018 17:13:06 -0700 (PDT) X-Received: by 2002:a81:4418:: with SMTP id r24-v6mr76623ywa.407.1536192786105; Wed, 05 Sep 2018 17:13:06 -0700 (PDT) MIME-Version: 1.0 Received: by 2002:a25:5f04:0:0:0:0:0 with HTTP; Wed, 5 Sep 2018 17:13:05 -0700 (PDT) In-Reply-To: References: <20180905203443.32289-1-igor.stoppa@huawei.com> <2192189d-b8bb-3233-c9f3-14cbeeddaf34@gmail.com> From: Kees Cook Date: Wed, 5 Sep 2018 17:13:05 -0700 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH] seccomp: remove unnecessary unlikely() To: James Morris Cc: Igor Stoppa , Igor Stoppa , linux-security-module , LKML Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Sep 5, 2018 at 5:08 PM, James Morris wrote: > On Wed, 5 Sep 2018, Kees Cook wrote: > >> On Wed, Sep 5, 2018 at 3:49 PM, Igor Stoppa wrote: >> > >> > >> > On 06/09/18 01:23, Kees Cook wrote: >> > >> >> Should I take this, or is it part of your series going somewhere else? >> > >> > >> > It turned out it doesn't really work to have a generic series against 20 >> > trees :-/ >> >> I know that pain very well! >> >> > I'm submitting them individually to each subsystem. >> > So this one is just for security. >> >> Sounds good. >> >> James, can you take this directly, or would you prefer a pull request from me? > > I'll take it with your ack. Already included! :) (This was a v2, split from a separate series, so Igor already included my Ack from the other thread.) But, for completeness: Acked-by: Kees Cook -Kees -- Kees Cook Pixel Security