Received: by 2002:ac0:a5a6:0:0:0:0:0 with SMTP id m35-v6csp24660imm; Wed, 5 Sep 2018 17:44:54 -0700 (PDT) X-Google-Smtp-Source: ANB0Vda0JMa/zZ/9qvsT5cmzzUKm1MQYiTAfQI8KZcL1h/20AGf+KXg03+X1lli3T11ktoaUiFk4 X-Received: by 2002:a17:902:64c1:: with SMTP id y1-v6mr276261pli.45.1536194694438; Wed, 05 Sep 2018 17:44:54 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1536194694; cv=none; d=google.com; s=arc-20160816; b=rYRj1xxS4vfOWzxkZQXa46nDhi6CoHW6zX4AXP4OBSuyE89EVEodNMIE/zB/WTnyj/ wuyX0MLeZnftYlAtbUltrMOdWGZF7lGzs3t6zJs92BNyjghN5yi0QJmb4i9p0IHKqPs5 /MIqYMgnvcd8sibrMRXSqaxNmGZXi3R9XvFIv0c7V73gaxQ1ObDW6AU0emgA/qv6/kJK 57Esh6VBXMZblO9N/NivCybDBn4/ZpKJ7sO8q0QDyHnGaG02mvzZE9sQQNQemAu660ic 39Y2r1cGi2ZxJNS8t6i58noq9wSpEiZiRL3zBM/xERN9rQxSoG5bUl41Kmh8uRUcdSXS /uzw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:dkim-signature; bh=UJjNRZW02t3hNql0XCvGthnqLRqIyWKeVqZxno1ULgA=; b=PO8IiwFg9BBlHZykKi9jb33mV/IuVXGW+oVATPF07wNT/DQ24JUQYR+xaGAcNKPqkN bwz9xSRkHBP0LaZCVYRA0q22kCehvmg9M3cjBy4HlXYtchSM7lN/w63dGeXOJ88oQWob lD7nTB1H3PGxJ5SAWKJNXAZJ4/ROPowi1m4667V0UsxglSFGZm4s+bGYV5cXCGTWId4j CzvN+Cy4libb5nU9rpBtHQBpbwJV5ZWRGRK543gUX4v1RMhA/b6L7Hizwz1RSRMzJLQG pJxRnKhfdyJ5WhK11sl7dKqJVcUCcNXK7f329zT7rWqomita9DClXQ5TPBZkLDOINLad BWOA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b="w/czHqeb"; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id j91-v6si3473365pld.474.2018.09.05.17.44.30; Wed, 05 Sep 2018 17:44:54 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b="w/czHqeb"; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726001AbeIFFQF (ORCPT + 99 others); Thu, 6 Sep 2018 01:16:05 -0400 Received: from mail.kernel.org ([198.145.29.99]:35188 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725850AbeIFFQF (ORCPT ); Thu, 6 Sep 2018 01:16:05 -0400 Received: from mail-wm0-f45.google.com (mail-wm0-f45.google.com [74.125.82.45]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id A4AC82086C for ; Thu, 6 Sep 2018 00:43:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1536194602; bh=w8kUUAnmV58kQf7B7pTNmPrDU1fK+tzpRlvHYRVHCbA=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=w/czHqebmzF4KXeOEyVlKo3ipEq8hVZ5VyYNrOOcDNyQ+eauhl2M5V5I9DC7ADTsd WwK5AaciO5ni6OXzDP6vsSxVLZj0Wfv0O3n60Zd8IaQ3gdgKjsqxNfNxGN+lVgLHD4 7lPHuJf+DuC4SHdS0Nd40LZINWNfctO78dDPTwO8= Received: by mail-wm0-f45.google.com with SMTP id j25-v6so15248139wmc.1 for ; Wed, 05 Sep 2018 17:43:22 -0700 (PDT) X-Gm-Message-State: APzg51Du06Z3aeu4HEDORZXtweSSRF1Qjgq4nKAwxgflDxAbj+XTzcZ/ zsEN41AW0GBBI1hUss0L6EOeBsshk0iC4XPiNH0yIQ== X-Received: by 2002:a1c:780c:: with SMTP id t12-v6mr457102wmc.133.1536194601132; Wed, 05 Sep 2018 17:43:21 -0700 (PDT) MIME-Version: 1.0 References: <62dae1828ade759584bbf1507fe4a9e69d247a50.1536138304.git.ren_guo@c-sky.com> In-Reply-To: <62dae1828ade759584bbf1507fe4a9e69d247a50.1536138304.git.ren_guo@c-sky.com> From: Rob Herring Date: Wed, 5 Sep 2018 19:43:10 -0500 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH V3 21/26] dt-bindings: interrupt-controller: C-SKY APB intc To: ren_guo@c-sky.com Cc: linux-arch@vger.kernel.org, Linux Kernel Mailing List , Thomas Gleixner , Daniel Lezcano , Jason Cooper , Arnd Bergmann , c-sky_gcc_upstream@c-sky.com, gnu-csky@mentor.com, thomas.petazzoni@bootlin.com, wbx@uclibc-ng.org, Greentime Hu Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Sep 5, 2018 at 7:10 AM Guo Ren wrote: > > Signed-off-by: Guo Ren > --- > .../interrupt-controller/csky,apb-intc.txt | 45 ++++++++++++++++++++++ > 1 file changed, 45 insertions(+) > create mode 100644 Documentation/devicetree/bindings/interrupt-controller/csky,apb-intc.txt > > diff --git a/Documentation/devicetree/bindings/interrupt-controller/csky,apb-intc.txt b/Documentation/devicetree/bindings/interrupt-controller/csky,apb-intc.txt > new file mode 100644 > index 0000000..faa482c > --- /dev/null > +++ b/Documentation/devicetree/bindings/interrupt-controller/csky,apb-intc.txt > @@ -0,0 +1,45 @@ > +============================== > +C-SKY APB Interrupt Controller > +============================== > + > +C-SKY APB Interrupt Controller is a simple soc interrupt controller > +on the apb bus and we only use it as root irq controller. > + > + - csky,apb-intc is used in a lot of csky fpgas and socs, it support 64 irq nums. > + - csky,dual-apb-intc consists of 2 apb-intc and 128 irq nums supported. Can't this be described in DT as 2 csky,apb-intc nodes? > + - csky,gx6605s-intc is gx6605s soc internal irq interrupt controller, 64 irq nums. > + > +============================= > +intc node bindings definition > +============================= > + > + Description: Describes APB interrupt controller > + > + PROPERTIES > + > + - compatible > + Usage: required > + Value type: > + Definition: must be "csky,apb-intc" > + "csky,dual-apb-intc" > + "csky,gx6605s-intc" > + - interrupt-cells #interrupt-cells > + Usage: required > + Value type: > + Definition: must be <1> No edge or level configuration? > + - reg > + Usage: required > + Value type: > + Definition: in soc from cpu view > + - interrupt-controller: > + Usage: required > + > +Examples: > +--------- > + > + intc: interrupt-controller { Needs a unit-address. > + compatible = "csky,apb-intc"; > + #interrupt-cells = <1>; > + reg = <0x00500000 0x400>; > + interrupt-controller; > + }; > -- > 2.7.4 >