Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Subject: Re: [PATCH] platform/x86: ideapad-laptop: Use __func__ instead of
 read_ec_cmd in pr_err
To:     Zhang Xianwei <zhang.xianwei8@zte.com.cn>, dvhart@infradead.org,
        andy@infradead.org
Cc:     platform-driver-x86@vger.kernel.org, linux-kernel@vger.kernel.org,
        zhong.weidong@zte.com.cn, jiang.biao2@zte.com.cn
References: <1536044899-10452-1-git-send-email-zhang.xianwei8@zte.com.cn>
From:   Ike Panhc <ike.pan@canonical.com>
Message-ID: <9fce93c1-ad6f-8d02-0cf7-42680b78a924@canonical.com>
Date:   Thu, 6 Sep 2018 16:49:22 +0800
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101
 Thunderbird/52.9.1
MIME-Version: 1.0
In-Reply-To: <1536044899-10452-1-git-send-email-zhang.xianwei8@zte.com.cn>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On 09/04/2018 03:08 PM, Zhang Xianwei wrote:
> Refer to the commit f1395edbcec8 ("platform/x86: ideapad-laptop: Use
> __func__ instead of write_ec_cmd in pr_err"), prefer using '"%s...",
> __func__' to using 'read_ec_cmd' in read_ec_data.
> 
> Signed-off-by: Zhang Xianwei <zhang.xianwei8@zte.com.cn>
> ---
>  drivers/platform/x86/ideapad-laptop.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/platform/x86/ideapad-laptop.c b/drivers/platform/x86/ideapad-laptop.c
> index d4f1259..f856d59 100644
> --- a/drivers/platform/x86/ideapad-laptop.c
> +++ b/drivers/platform/x86/ideapad-laptop.c
> @@ -212,7 +212,7 @@ static int read_ec_data(acpi_handle handle, int cmd, unsigned long *data)
>  			return 0;
>  		}
>  	}
> -	pr_err("timeout in read_ec_cmd\n");
> +	pr_err("timeout in %s\n", __func__);
>  	return -1;
>  }
>  
> 

Good catch. Thanks.

Acked-by: Ike Panhc <ike.pan@canonical.com>