Received: by 2002:ac0:a5a6:0:0:0:0:0 with SMTP id m35-v6csp440656imm; Thu, 6 Sep 2018 05:06:16 -0700 (PDT) X-Google-Smtp-Source: ANB0VdYxZ10JuqSJZmOx6vzFfKwSuFL4A0NozddJsDnk1MUIyYR0Rz2dIy1HU4ddsJG/yPP3QED2 X-Received: by 2002:a63:d206:: with SMTP id a6-v6mr1315371pgg.99.1536235576259; Thu, 06 Sep 2018 05:06:16 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1536235576; cv=none; d=google.com; s=arc-20160816; b=boXMOqwSS4lAU9d/kHqNCr/ABUnClgOw7Ojpk00xhYuIVSxGiGgPyP2GilQz6rrSNl vMyTB97zkvW1e/jXNIeRuGJ0LnSQixdU+EfVVei2myXC1EUXHhuYijjGkvhWON1ACQyP EkxkoKukjHn2d6cuWB5ffaQm4mBJVTca6Y33bV3mqw39ASz7rfvNrI6k9U/hdvhelSkD LFNduWEeDtKhTn7LrvSqk1fxtKRoLhBw5EVlx/asqg0fdAFdWtpoHLE1tAkfHAF5rq1r wBo9i9t0JdLnJbmDiZWp4YMzsjgUnVZHMYH8kb6do1Q6YCEeRerIEi+7MHtmtvKEq2Cm AyXg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:message-id:from:cc:to:subject :content-transfer-encoding:mime-version:references:in-reply-to:date; bh=nbya5ZfDgyavKu9pEd6/DwvINp7QHDRyJT/4v96wYBQ=; b=vnZfX3/jg4RVU08HJL3IXpsFa/ob9wDd6Mb+iL3+yHpnU8yduqGO3CWxPdWUBEESLf 0DzSnI2Rq+1PnbPrF4Bf/f/rawetWVy1glDwznwM55KlwLpG5vIniTMj7XJHHjvrS9as DYaLxqGlEJ0n3wJf+qcpXj7yd8mMXi4o7/a3nWQuhnGCek81LOjiTxcOXgQVa4TvkFUr blgWdZIX/eFJ8J4JzlbXJCHw2QNZTG4wv/71yL/XWO1tnsBg4wXRW5B/HPFPW07Z8lCw K3vNPqvSpPOIAsaEJZzPsbcyEFIpYF8DOkgzdZRnDRuotCXFx2AFF0AkaP0K5/fOCu+k go6Q== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id t127-v6si5212799pfc.118.2018.09.06.05.05.59; Thu, 06 Sep 2018 05:06:16 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727741AbeIFQkC convert rfc822-to-8bit (ORCPT + 99 others); Thu, 6 Sep 2018 12:40:02 -0400 Received: from hermes.aosc.io ([199.195.250.187]:42831 "EHLO hermes.aosc.io" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726436AbeIFQkB (ORCPT ); Thu, 6 Sep 2018 12:40:01 -0400 Received: from localhost (localhost [127.0.0.1]) (Authenticated sender: icenowy@aosc.io) by hermes.aosc.io (Postfix) with ESMTPSA id 7ADA211C1AF; Thu, 6 Sep 2018 12:04:38 +0000 (UTC) Date: Thu, 06 Sep 2018 20:04:11 +0800 In-Reply-To: <20180906115114.inc6dhqhy47obo25@flea> References: <20180830154518.29507-1-embed3d@gmail.com> <20180830154518.29507-28-embed3d@gmail.com> <20180904184623.e4386b8e6b657b1b25e90c09@bidouilliste.com> <55579dd6-625d-e71b-1482-4592dccac665@gmail.com> <20180906115114.inc6dhqhy47obo25@flea> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8BIT Subject: Re: [linux-sunxi] Re: [PATCH v3 27/30] ARM: dts: sun8i: h3: use calibration for ths To: maxime.ripard@bootlin.com, Maxime Ripard , Philipp Rossak CC: Emmanuel Vadot , lee.jones@linaro.org, robh+dt@kernel.org, mark.rutland@arm.com, wens@csie.org, linux@armlinux.org.uk, jic23@kernel.org, knaack.h@gmx.de, lars@metafoo.de, pmeerw@pmeerw.net, eugen.hristev@microchip.com, rdunlap@infradead.org, vilhelm.gray@gmail.com, clabbe.montjoie@gmail.com, quentin.schulz@bootlin.com, geert+renesas@glider.be, lukas@wunner.de, arnd@arndb.de, broonie@kernel.org, arnaud.pouliquen@st.com, linux-iio@vger.kernel.org, devicetree@vger.kernel.org, linux-sunxi@googlegroups.com, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org From: Icenowy Zheng Message-ID: Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 于 2018年9月6日 GMT+08:00 下午7:51:15, Maxime Ripard 写到: >On Thu, Sep 06, 2018 at 01:47:47PM +0200, Philipp Rossak wrote: >> On 04.09.2018 18:46, Emmanuel Vadot wrote: >> > > + /* Data cells */ >> > > + thermal_calibration: calib@234 { >> > > + reg = <0x234 0x8>; >> > > + }; >> > You are declaring 8 bytes of calibration data but to my knowledge >it's >> > only 2 bytes per sensor, so 2 bytes for H3. >> > Am I missing something ? >> > >> > Thanks, >> >> Emmanuel you are right, it is 2 bytes per Sensor and should be 2 >bytes for >> H3, but the thermal calibration data field is on all chips 64 bit >wide - so >> 8 bytes. So I'm reading here the complete calibration data field. > >Having one cell per channel would make more sense I guess. I have mentioned that this is impossible because of wrong addressing caused by LE2BE in SID driver. > >Maxime