Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S262128AbTKHUXp (ORCPT ); Sat, 8 Nov 2003 15:23:45 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S262139AbTKHUXp (ORCPT ); Sat, 8 Nov 2003 15:23:45 -0500 Received: from parcelfarce.linux.theplanet.co.uk ([195.92.249.252]:2441 "EHLO www.linux.org.uk") by vger.kernel.org with ESMTP id S262128AbTKHUXn (ORCPT ); Sat, 8 Nov 2003 15:23:43 -0500 Message-ID: <3FAD50B6.2020502@pobox.com> Date: Sat, 08 Nov 2003 15:23:18 -0500 From: Jeff Garzik User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.4) Gecko/20030703 X-Accept-Language: en-us, en MIME-Version: 1.0 To: Sergey Vlasov CC: linux-kernel@vger.kernel.org Subject: Re: [BK PATCHES] libata fixes References: <20031108172621.GA8041@gtf.org> In-Reply-To: Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 744 Lines: 24 Sergey Vlasov wrote: > (Not about this particular libata update) > > static void __init quirk_intel_ide_combined(struct pci_dev *pdev) > ... > { PCI_FIXUP_FINAL, PCI_VENDOR_ID_INTEL, PCI_ANY_ID, > quirk_intel_ide_combined }, > > Won't this oops if some Intel device would be hotplugged? A similar > problem with quirk_via_bridge was just fixed. We should probably start marking entries as "no hotplug" because many of the quirks have no need to be run after initial boot. Jeff - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/