Received: by 2002:ac0:a5a6:0:0:0:0:0 with SMTP id m35-v6csp1044935imm; Thu, 6 Sep 2018 14:27:30 -0700 (PDT) X-Google-Smtp-Source: ANB0VdYKKDHd7H5WktEhUhtR9MIQm5d5es2EPyqaecWa3vaPvkgvwE7oO29vlhPLJwJKySsp2QwI X-Received: by 2002:a63:e811:: with SMTP id s17-v6mr4928976pgh.176.1536269250874; Thu, 06 Sep 2018 14:27:30 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1536269250; cv=none; d=google.com; s=arc-20160816; b=KvjCOblVXL73yxMclZl/FqloWq+aciGRCIdefAl9wQ4ug1/YrEyppB9kQ9tR9aMM4e kwk2Omn0YxgCXY21Oi/FUr2h278WkAngh+gyuXIFCBtQyEmeBpV6fsuRAgjug0ZUvdKA 2FnYzTQOq/MXS6UQDKhVj4Lpz9d+4HPvMHzfI9Ua5wo0ZWUF7J2pMyG23gE0kAb7VDZ6 zKIo4kPNlHg8N6DclkCN+GdhtwJEVBv0ejDMm5JT63d4ogcLVgt9HCoXFeSq74LqQ2K6 5MTZS8pOsehGMvbAJUNIGWTcyj1LWzKdGqqzR8OffrBpq7rhvJGWEoij9j2JWeQBX4Zc imPw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:user-agent:references :message-id:in-reply-to:subject:cc:to:from:date; bh=mVWJz0LXa+MkBoJA5EzcCm42anpIQsaDPtV82wEVXyw=; b=NSGZ7CrR8b0vc+eCDr2oywEEVmfEUOr9r4IPHlAJ0SbpTiN2IleT60FnMMp38TmVO3 RKCY4Kce91TDbD4XZhep7B/L2J1vZC2EmCbksysQuPQSJBpxVHDX+HyPs1p32dfuhYo2 d3iUGW1NJwXo28baXNqd8wSoyOdhik6RuTYNip9t+2xe4PO5eJJPrwLSzmUyCs5zCn7n yhN6lgTbMJvaEdBVTsRvPoN5/RzykpTbupKpSKR1ebiUPPF5G0Rw/z5s5qspQ5W6XwSw IQaYC1MMPYMF7nrTaR6n6ETBcDASF8ns+me3agOCvonmx2qLJKFq360ld8+ZHb/eRcZo 0FVw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id f15-v6si6198430pgb.666.2018.09.06.14.27.15; Thu, 06 Sep 2018 14:27:30 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729923AbeIGBIr (ORCPT + 99 others); Thu, 6 Sep 2018 21:08:47 -0400 Received: from namei.org ([65.99.196.166]:46276 "EHLO namei.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726116AbeIGBIr (ORCPT ); Thu, 6 Sep 2018 21:08:47 -0400 Received: from localhost (localhost [127.0.0.1]) by namei.org (8.14.4/8.14.4) with ESMTP id w86KVXNF013643; Thu, 6 Sep 2018 20:31:33 GMT Date: Fri, 7 Sep 2018 06:31:33 +1000 (AEST) From: James Morris To: Igor Stoppa cc: Kees Cook , Igor Stoppa , linux-security-module@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] seccomp: remove unnecessary unlikely() In-Reply-To: <20180905203443.32289-1-igor.stoppa@huawei.com> Message-ID: References: <20180905203443.32289-1-igor.stoppa@huawei.com> User-Agent: Alpine 2.21 (LRH 202 2017-01-01) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 5 Sep 2018, Igor Stoppa wrote: > WARN_ON() already contains an unlikely(), so it's not necessary to wrap it > into another. > > Signed-off-by: Igor Stoppa > Acked-by: Kees Cook > Cc: linux-security-module@vger.kernel.org > Cc: linux-kernel@vger.kernel.org Applied to git://git.kernel.org/pub/scm/linux/kernel/git/jmorris/linux-security.git next-general and next-testing. Thanks! -- James Morris