Received: by 2002:ac0:a5a6:0:0:0:0:0 with SMTP id m35-v6csp1104849imm; Thu, 6 Sep 2018 15:40:46 -0700 (PDT) X-Google-Smtp-Source: ANB0VdYOcKeGkaN41ur1n7EzFj+3OG0HSagAznBmSvuoT8bp6mjRRac2/r80EVKdf0VVQFG/qMv6 X-Received: by 2002:a62:ed5:: with SMTP id 82-v6mr5299333pfo.198.1536273646127; Thu, 06 Sep 2018 15:40:46 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1536273646; cv=none; d=google.com; s=arc-20160816; b=Bik55FpsNQJoaP+/mgfz3VHVFf7HFZvIpGiJVwDP6Ll7wp2k2aafnsSuZEZO0DPXL0 RXdCJM9Zo98etqZ4nlwT/zrAyXhN6mZDEd9jvfpy8bduARfHKxmrdUimsqOXawJXFCQT 7dKCTm57uoICzx/OZFfC59qo1rGu2tto6GGihVnJ26bcYf5hsNgPGA+ITpR2jfYFzW1+ 8wPZQ4DmAGeXERrCYVQYsP/DxKbMnUtrur6vLfzHyAZsKdwYWSNvzQPvpjfmGcPFwmX3 B60+EIcSuIu6uN09oYPzNtXAP2e+14yEEDmMQN5raIgZc5fRS9tGFOx7rj/rGeQBocqQ qttg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:references:in-reply-to:message-id:date :subject:cc:to:from:dkim-signature; bh=MFbflLwNRU5WISREwEFNq/SoarHy9028ZMj0YzXF0MU=; b=HxNz3MKGqLYeHgpD4Vhj6euyNeUBx00DS2g0QOuJ4IYhXzTm/m7JjJvXzhVPA9id73 CZn/k2X/GBKd2e6Xq1oJ+YPYoF+dZovbtAiIvN3Ar/1vxJ6VLksOLsAHPbxfY/UbgoKA 3wGJRw+qZoMNHF4oalYPcl0x0U/cI+gKxhWxNbR/vyF3+h6iguApUJnhuqKNng5XKXTZ h2+yGBtLcrisNT+P4neN8Bu1ooEn6w/ZHrDRWuDso2gGvHrB15dHzdDAk6OWKjNrn4VE dipNBGI6eyRw0h/iqKiKzzhWqeTZBC1r2TkRoPYebFMSvEQsq1C45Z3t2cvbf0uCXISS UqSA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@lekensteyn.nl header.s=s2048-2015-q1 header.b=MBBHoXAO; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id l6-v6si6617573pgi.534.2018.09.06.15.40.30; Thu, 06 Sep 2018 15:40:46 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@lekensteyn.nl header.s=s2048-2015-q1 header.b=MBBHoXAO; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728270AbeIGCzx (ORCPT + 99 others); Thu, 6 Sep 2018 22:55:53 -0400 Received: from lekensteyn.nl ([178.21.112.251]:43855 "EHLO lekensteyn.nl" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728089AbeIGCzx (ORCPT ); Thu, 6 Sep 2018 22:55:53 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lekensteyn.nl; s=s2048-2015-q1; h=References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From; bh=MFbflLwNRU5WISREwEFNq/SoarHy9028ZMj0YzXF0MU=; b=MBBHoXAO+B/5pwf8jSKkvqnWjumaxyxebZ1mGrLVACLc/rFp/EylFfpzuSKd+P1RGGee7srVKgamjh0cp4vvntMolaGus2ts2Bl5xr0nhUE4bMBCBpklSzrMS8LITgO3IhtKgomnaeuscCEPACgYu4H1DH/NEBeAGZRqmrwameW7ztC8LyQRqTlV+L56RNjJ2g5SAattUqJcjHUJ7/2R4Ig8+pOQc7lEu14SqAjzO3VohfFZa9oNnXMgAtYaOEk1hqyZVwjdp/mx0bsuQhA5FBOiQtlLy5xk5O/VAX9on2O7pKKuDhosjdaiM7UM3967srzu1oyyftfqZJ9pMlXajA==; Received: by lekensteyn.nl with esmtpsa (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.84_2) (envelope-from ) id 1fy2bM-0005Us-DR; Fri, 07 Sep 2018 00:18:12 +0200 From: Peter Wu To: Gerd Hoffmann Cc: virtualization@lists.linux-foundation.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org Subject: [PATCH v2 1/4] bochs: use drm_fb_helper_set_suspend_unlocked in suspend/resume Date: Fri, 7 Sep 2018 00:18:07 +0200 Message-Id: <20180906221810.20170-2-peter@lekensteyn.nl> X-Mailer: git-send-email 2.18.0 In-Reply-To: <20180906221810.20170-1-peter@lekensteyn.nl> References: <20180906221810.20170-1-peter@lekensteyn.nl> X-Spam-Score: -0.0 (/) X-Spam-Status: No, hits=-0.0 required=5.0 tests=NO_RELAYS=-0.001 autolearn=no autolearn_force=no Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The "initialized" member is going away. suspend/resume still works (even if bochsfb_create is forced to fail). Signed-off-by: Peter Wu --- drivers/gpu/drm/bochs/bochs_drv.c | 12 ++---------- 1 file changed, 2 insertions(+), 10 deletions(-) diff --git a/drivers/gpu/drm/bochs/bochs_drv.c b/drivers/gpu/drm/bochs/bochs_drv.c index c61b40c72b62..0e79d9acf89e 100644 --- a/drivers/gpu/drm/bochs/bochs_drv.c +++ b/drivers/gpu/drm/bochs/bochs_drv.c @@ -107,11 +107,7 @@ static int bochs_pm_suspend(struct device *dev) drm_kms_helper_poll_disable(drm_dev); - if (bochs->fb.initialized) { - console_lock(); - drm_fb_helper_set_suspend(&bochs->fb.helper, 1); - console_unlock(); - } + drm_fb_helper_set_suspend_unlocked(&bochs->fb.helper, 1); return 0; } @@ -124,11 +120,7 @@ static int bochs_pm_resume(struct device *dev) drm_helper_resume_force_mode(drm_dev); - if (bochs->fb.initialized) { - console_lock(); - drm_fb_helper_set_suspend(&bochs->fb.helper, 0); - console_unlock(); - } + drm_fb_helper_set_suspend_unlocked(&bochs->fb.helper, 0); drm_kms_helper_poll_enable(drm_dev); return 0; -- 2.18.0