Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
References: <1536223870-6324-1-git-send-email-dingxiang@cmss.chinamobile.com>
In-Reply-To: <1536223870-6324-1-git-send-email-dingxiang@cmss.chinamobile.com>
From:   Linus Torvalds <torvalds@linux-foundation.org>
Date:   Thu, 6 Sep 2018 22:04:49 -0700
Message-ID: <CA+55aFxuha1tQXcn+WtbOKzwwmtA8AORb04tMM=hk6jT3ntt3w@mail.gmail.com>
Subject: Re: [PATCH] vme: remove unneeded kfree
To:     dingxiang@cmss.chinamobile.com
Cc:     martyn@welchs.me.uk, manohar.vanga@gmail.com,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Staging subsystem List <devel@driverdev.osuosl.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Thu, Sep 6, 2018 at 1:51 AM Ding Xiang
<dingxiang@cmss.chinamobile.com> wrote:
>
> put_device will call vme_dev_release to free vdev, kfree is
> unnecessary here.

That does seem to be the case.  I think "unnecessary" is overly kind,
it does seem to be a double free.

Looks like the issue was introduced back in 2013 by commit
def1820d25fa ("vme: add missing put_device() after device_register()
fails").

It seems you should *either* kfree() the vdev, _or_ do put_device(),
but doing both seems wrong.

I presume the device_register() has never failed, and this being
vme-only I'm guessing there isn't a vibrant testing community.

Greg?

              Linus