Received: by 2002:ac0:a5a6:0:0:0:0:0 with SMTP id m35-v6csp1516071imm; Fri, 7 Sep 2018 01:22:59 -0700 (PDT) X-Google-Smtp-Source: ANB0VdZBXcDfqtPT9QebqkWU6pSQlknePFUPwFsl0mtK9Ah4fimlgHy6MUopKr8SKUZ9QwqkVJWK X-Received: by 2002:a17:902:740a:: with SMTP id g10-v6mr6948723pll.22.1536308579827; Fri, 07 Sep 2018 01:22:59 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1536308579; cv=none; d=google.com; s=arc-20160816; b=AuVnjnIftJ5EXTKMroUOqOGhK5S0Cw9snjpybEFp+9/+9MqTH5nirLNCztxET21Umd Ifo7oc39Hfu/Kx0LEHhPm5EMvA7gAZJVKeouFFzbqzRyG7VSsXJCrokGcPGYHYIkmfwA D2KnexoVeU6zQoqSFx9pP0meWhV16gVY5sAe3loZVwIPyyqWd7pwY9G3udrB8Nwuec6t 7uF/OFNDXlm1ZRneas1bmBrlu4QPrcS0C1U2vAEjrhckCF/TU6KzED1KYyVHX/FHEJdj uXpfxlKIWnq2hQJc9p5aq773w+dwYntli16+ErqsQLXCnyAmi9y7DGDXtegDbU1PKQAj vLlw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=IrCg6O00xZRMFaVwDmDS6t28bHlDyx1+bPOmmLA2wEQ=; b=qnbVs/o1dD9AT11q2htec9RRNgeG3otBFTzKmp49m0YhW0REN+yNbsZ0VvyH7r1BkB BB9jCysDdkQzQHf9AP54Hl4DeeuCL6Bo0/5owryE8du8cZ07GtD6BqW/C6EQrO2KpdNp +pzqElVdWDxPXEVaJas2OMRXVr/mXeBLwoNBJSzraJmF1/2rKz/5k5ACr0xu2W3jVrdC 3Q+Gu93vvZbJz2Ze+eR6pDygR5w+ISp/wOA3VZ9QRPAVMp0fIEQ4q6ftHiP1zvEUb6Vo lFQNofcrv2/KtAirdrWjSHEq56c5CO7UnKdq1yfcjJqEq8wECUoofKeLIXyBu45kkZdw 0FHw== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@infradead.org header.s=merlin.20170209 header.b=UkTYU9pq; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id q6-v6si6050442pgk.94.2018.09.07.01.22.44; Fri, 07 Sep 2018 01:22:59 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=fail header.i=@infradead.org header.s=merlin.20170209 header.b=UkTYU9pq; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727856AbeIGM0m (ORCPT + 99 others); Fri, 7 Sep 2018 08:26:42 -0400 Received: from merlin.infradead.org ([205.233.59.134]:52874 "EHLO merlin.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726655AbeIGM0l (ORCPT ); Fri, 7 Sep 2018 08:26:41 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=merlin.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=IrCg6O00xZRMFaVwDmDS6t28bHlDyx1+bPOmmLA2wEQ=; b=UkTYU9pq6D3tYcNU1JPANxfmw 8BGqo5HN0TOLbKq0qIXKkoIa7mohaADXtRJrXr80zw2chhl/ouYx/Efsphp6tMdPxaMqZUnT4gsGu Ec2HBDkVNlevi84GcG/Ce05ExJaGwwx2QkIhF3FZSND2kVbfwXs4WKeV+/V6+PJFMcZI6PijSikXP Z/gTElwjAEgf4toGfJYk4LeilVLPfjKybFwDSa1WX1OG0m6mgi1P+Y7iW6cRrW4W/BBUomCvlwoRU 7Cf13TIZt31oO2UWrH6cG6ot52cXYVn2cutpLhfSB9/0VkBFZWBFd8jtNRttJZBqz6K92aaHviM3d uZc22//Bw==; Received: from j217100.upc-j.chello.nl ([24.132.217.100] helo=hirez.programming.kicks-ass.net) by merlin.infradead.org with esmtpsa (Exim 4.90_1 #2 (Red Hat Linux)) id 1fyBTX-0007og-BO; Fri, 07 Sep 2018 07:46:43 +0000 Received: by hirez.programming.kicks-ass.net (Postfix, from userid 1000) id 566C820210310; Fri, 7 Sep 2018 09:46:42 +0200 (CEST) Date: Fri, 7 Sep 2018 09:46:42 +0200 From: Peter Zijlstra To: Johannes Weiner Cc: Ingo Molnar , Andrew Morton , Linus Torvalds , Tejun Heo , Suren Baghdasaryan , Daniel Drake , Vinayak Menon , Christopher Lameter , Peter Enderborg , Shakeel Butt , Mike Galbraith , linux-mm@kvack.org, cgroups@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-team@fb.com Subject: Re: [PATCH 0/9] psi: pressure stall information for CPU, memory, and IO v4 Message-ID: <20180907074642.GN24106@hirez.programming.kicks-ass.net> References: <20180828172258.3185-1-hannes@cmpxchg.org> <20180905214303.GA30178@cmpxchg.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20180905214303.GA30178@cmpxchg.org> User-Agent: Mutt/1.10.0 (2018-05-17) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Sep 05, 2018 at 05:43:03PM -0400, Johannes Weiner wrote: > On Tue, Aug 28, 2018 at 01:22:49PM -0400, Johannes Weiner wrote: > > This version 4 of the PSI series incorporates feedback from Peter and > > fixes two races in the lockless aggregator that Suren found in his > > testing and which caused the sample calculation to sometimes underflow > > and record bogusly large samples; details at the bottom of this email. > > Peter, do the changes from v3 look sane to you? I'll go have a look.