Received: by 2002:ac0:a5a6:0:0:0:0:0 with SMTP id m35-v6csp1603503imm; Fri, 7 Sep 2018 03:10:21 -0700 (PDT) X-Google-Smtp-Source: ANB0VdYvwMA64aGU0Ykz0ohDYBMVv+iccugZLDVcKyyIY8H9NBX0s2BzYwm5Pl5i48ZgS0uKkwhm X-Received: by 2002:a63:2906:: with SMTP id p6-v6mr7337429pgp.204.1536315021747; Fri, 07 Sep 2018 03:10:21 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1536315021; cv=none; d=google.com; s=arc-20160816; b=fusyXGUvqA9bXEu70zHOLugHJ9PbNP/PTYD++yk4iY/IshXnxUydK6f09eS/S8Xhmt S8mqhkzfDLBdxJsu/+rU7F9Mlr19SIol46G+XpPbGRLa3kPYIJl3S4ewZoIvjNmSzyp1 c+TuzciX2fY6Gs3P7ShyjzoyCEK6GmeWF30DkKiJVHHQk+it4UvhBDg+kAzuFVjelw98 /AQpnKXSr2FdyrVyTP1IAN2rwOPAkkxhJv1o1M+hQdu1c9BDf4bhb2BBFaJ/jwRNrUL/ Qh7O49l6XarUY8HXUVjgpMs0ql9LhI1t7+B9mlJZfXdQyK6th5F85WChPDCKrpZTu5kc fyDw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:autocrypt:openpgp:from:references:cc:to:subject; bh=wCB5bkelrPr6VYMv0G0qEBMV/E5HBskdxwKfjhk+XSI=; b=Ptl7bkzOOMN7iFMDrzj3pn+/8ndkVdBhJFCfIAFakeRYz7cYhkwvIJPtpPogCgi0F6 IILqW3iQMut+rU+ABzhWpsWNo9C0pF1xku49aXQkWZZuJrXDoWHiDkOQeHuqxmpWx+CT gIqOBxI0geHAWf9RzQEW90tjlmrlN8exGPc7bgwXD6EdBblZzQ9rmKekO3L7zOUPbfcC VaLNmfcRBBoYR3l1zuzryU8pVd0vCY50OVS9N+siUQRfu87gQW2mcoKBuGyiITU3TEid 344GRdNHfn0kDXeEpoUNiFONe1eBN7acOY/hQ1E8yI9iFBqYtXzMHzTorl6d7qQTLGuW jgqw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id z1-v6si7145661pln.63.2018.09.07.03.10.06; Fri, 07 Sep 2018 03:10:21 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728597AbeIGOaT (ORCPT + 99 others); Fri, 7 Sep 2018 10:30:19 -0400 Received: from mx2.suse.de ([195.135.220.15]:56048 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726031AbeIGOaT (ORCPT ); Fri, 7 Sep 2018 10:30:19 -0400 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay1.suse.de (unknown [195.135.220.254]) by mx1.suse.de (Postfix) with ESMTP id 5EC29AE61; Fri, 7 Sep 2018 09:50:09 +0000 (UTC) Subject: Re: [PATCH v3] xen: avoid crash in disable_hotplug_cpu To: Olaf Hering Cc: xen-devel@lists.xenproject.org, Boris Ostrovsky , open list References: <20180907063023.16913-1-olaf@aepfle.de> <20180907112451.442b46fe.olaf@aepfle.de> From: Juergen Gross Openpgp: preference=signencrypt Autocrypt: addr=jgross@suse.com; prefer-encrypt=mutual; keydata= xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjrioyspZKOB ycWxw3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2kaV2KL9650I1SJve dYm8Of8Zd621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i1TXkH09XSSI8mEQ/ouNcMvIJ NwQpd369y9bfIhWUiVXEK7MlRgUG6MvIj6Y3Am/BBLUVbDa4+gmzDC9ezlZkTZG2t14zWPvx XP3FAp2pkW0xqG7/377qptDmrk42GlSKN4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEB AAHNHkp1ZXJnZW4gR3Jvc3MgPGpncm9zc0BzdXNlLmRlPsLAeQQTAQIAIwUCU4xw6wIbAwcL CQgHAwIBBhUIAgkKCwQWAgMBAh4BAheAAAoJELDendYovxMvi4UH/Ri+OXlObzqMANruTd4N zmVBAZgx1VW6jLc8JZjQuJPSsd/a+bNr3BZeLV6lu4Pf1Yl2Log129EX1KWYiFFvPbIiq5M5 kOXTO8Eas4CaScCvAZ9jCMQCgK3pFqYgirwTgfwnPtxFxO/F3ZcS8jovza5khkSKL9JGq8Nk czDTruQ/oy0WUHdUr9uwEfiD9yPFOGqp4S6cISuzBMvaAiC5YGdUGXuPZKXLpnGSjkZswUzY d9BVSitRL5ldsQCg6GhDoEAeIhUC4SQnT9SOWkoDOSFRXZ+7+WIBGLiWMd+yKDdRG5RyP/8f 3tgGiB6cyuYfPDRGsELGjUaTUq3H2xZgIPfOwE0EU4xwFgEIAMsx+gDjgzAY4H1hPVXgoLK8 B93sTQFN9oC6tsb46VpxyLPfJ3T1A6Z6MVkLoCejKTJ3K9MUsBZhxIJ0hIyvzwI6aYJsnOew cCiCN7FeKJ/oA1RSUemPGUcIJwQuZlTOiY0OcQ5PFkV5YxMUX1F/aTYXROXgTmSaw0aC1Jpo w7Ss1mg4SIP/tR88/d1+HwkJDVW1RSxC1PWzGizwRv8eauImGdpNnseneO2BNWRXTJumAWDD pYxpGSsGHXuZXTPZqOOZpsHtInFyi5KRHSFyk2Xigzvh3b9WqhbgHHHE4PUVw0I5sIQt8hJq 5nH5dPqz4ITtCL9zjiJsExHuHKN3NZsAEQEAAcLAXwQYAQIACQUCU4xwFgIbDAAKCRCw3p3W KL8TL0P4B/9YWver5uD/y/m0KScK2f3Z3mXJhME23vGBbMNlfwbr+meDMrJZ950CuWWnQ+d+ Ahe0w1X7e3wuLVODzjcReQ/v7b4JD3wwHxe+88tgB9byc0NXzlPJWBaWV01yB2/uefVKryAf AHYEd0gCRhx7eESgNBe3+YqWAQawunMlycsqKa09dBDL1PFRosF708ic9346GLHRc6Vj5SRA UTHnQqLetIOXZm3a2eQ1gpQK9MmruO86Vo93p39bS1mqnLLspVrL4rhoyhsOyh0Hd28QCzpJ wKeHTd0MAWAirmewHXWPco8p1Wg+V+5xfZzuQY0f4tQxvOpXpt4gQ1817GQ5/Ed/wsDtBBgB CAAgFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAlrd8NACGwIAgQkQsN6d1ii/Ey92IAQZFggA HRYhBFMtsHpB9jjzHji4HoBcYbtP2GO+BQJa3fDQAAoJEIBcYbtP2GO+TYsA/30H/0V6cr/W V+J/FCayg6uNtm3MJLo4rE+o4sdpjjsGAQCooqffpgA+luTT13YZNV62hAnCLKXH9n3+ZAgJ RtAyDWk1B/0SMDVs1wxufMkKC3Q/1D3BYIvBlrTVKdBYXPxngcRoqV2J77lscEvkLNUGsu/z W2pf7+P3mWWlrPMJdlbax00vevyBeqtqNKjHstHatgMZ2W0CFC4hJ3YEetuRBURYPiGzuJXU pAd7a7BdsqWC4o+GTm5tnGrCyD+4gfDSpkOT53S/GNO07YkPkm/8J4OBoFfgSaCnQ1izwgJQ jIpcG2fPCI2/hxf2oqXPYbKr1v4Z1wthmoyUgGN0LPTIm+B5vdY82wI5qe9uN6UOGyTH2B3p hRQUWqCwu2sqkI3LLbTdrnyDZaixT2T0f4tyF5Lfs+Ha8xVMhIyzNb1byDI5FKCb Message-ID: Date: Fri, 7 Sep 2018 11:50:08 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <20180907112451.442b46fe.olaf@aepfle.de> Content-Type: text/plain; charset=windows-1252 Content-Language: de-DE Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 07/09/18 11:24, Olaf Hering wrote: > Am Fri, 7 Sep 2018 09:48:28 +0200 > schrieb Juergen Gross : > >> On 07/09/18 08:30, Olaf Hering wrote: >>> + if (cpu_online(cpu)) >>> + return; >>> if (cpu_present(cpu)) >>> xen_arch_unregister_cpu(cpu); > >> Could you merge the two if conditions? >> if (!cpu_online(cpu) && cpu_present(cpu)) >> xen_arch_unregister_cpu(cpu); > > Is that any different, beside being wrong, from what the patch actually does? No. Just a matter of style. > It would still clear the present bit later on. This should be part of the if clause, of course. Juergen