Received: by 2002:ac0:a5a6:0:0:0:0:0 with SMTP id m35-v6csp1885039imm; Fri, 7 Sep 2018 07:37:13 -0700 (PDT) X-Google-Smtp-Source: ANB0Vdb8WU7O9fNV+2HDpaxtpglepnT/d1nqFl6NuyGSBjn5cBdSxo4MfCPbWGnZYwBJpdYVwJ3B X-Received: by 2002:a17:902:8542:: with SMTP id d2-v6mr8369267plo.285.1536331032971; Fri, 07 Sep 2018 07:37:12 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1536331032; cv=none; d=google.com; s=arc-20160816; b=luV0/3l41+FkwDgW4qIuOV65V/bhyMZt2+g7/glBDcSZGFAZxxNjTktDmyUZP5PV/z 4DD5Wz8r+OCDQUpNpOE7etmkfjwyD3EV+2sNLLSMieEQVwIYz1DE3TKATObqSCP5D2vH TC1qEPVNbEn6GY0t4zl1Ex0bYzWb1yy38c9GBtqz+pIiQKmWow0P1UxMM6cBuEryPHLp BL7qZBSFox5a+NlVX5YNA+48U2/UfbwA9Azbro0Jd3emOTjuyJhsU2MkLKbFby2uQoyA qpB3/tNaxYCQWeKGP3dg/Q6M3PAsA7kz5kx3/shUE3PINBjnpvGS180Dpy7AB3Fpirnj qxfg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=Z3Nd7ZIp4WmOWGI94vPTqYGjqDJTj78oMv5r92i9wXc=; b=DxZ5aE1AICxs+MyCfA6v6kLDZl92hLyP4r7zVff+XSfCUj6USCrKcNiSScGBghZ6TR pT2XWLonfGyNgMCrf6wAfNgh0R0jZcl75iE0/EU8cX91KP0fauF2t6+f1omXD20gHYf+ pqGvVSCTbuzrpQBVZYVhXgqUg3MFbHeJzD2ffzgmYTEcKaQ7Xf3Az/a46ULeeIJdTDli yROYCx9+p6lrhbu9QzKbZHTDZcut/l8efhmlbQNUZwIDKQhWmVCrnP7ETT9OwISiwrlI CxBlN249b9BBNpNtrvQikDtEzYeTpArQyjFs4fB6V0/NKN7iQP2usK9bhoVy/2AEDaTY F2Lg== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@infradead.org header.s=merlin.20170209 header.b=hQ6qmHJi; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id c17-v6si8312154pgg.628.2018.09.07.07.36.57; Fri, 07 Sep 2018 07:37:12 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=fail header.i=@infradead.org header.s=merlin.20170209 header.b=hQ6qmHJi; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728082AbeIGQCp (ORCPT + 99 others); Fri, 7 Sep 2018 12:02:45 -0400 Received: from merlin.infradead.org ([205.233.59.134]:55404 "EHLO merlin.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727597AbeIGQCp (ORCPT ); Fri, 7 Sep 2018 12:02:45 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=merlin.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=Z3Nd7ZIp4WmOWGI94vPTqYGjqDJTj78oMv5r92i9wXc=; b=hQ6qmHJiNE1pRwqPOK1o51ZQh zrUfSl3U9qCdz/WtV5jMbPoneitrQyT2m3WrmP0OnufkHrZneG7FfcKPSCfghWt1VGW+WqPZkp6ty 0DEjtIqzQ17VB+AdpHOUSzpIXn61ioNQbOEgwBYWpdJFd6YPGOyqmZxz0Fn3dUYDPYYpTE/2y8lDd T+m8VMN+GBwMYmeQhooQpXOwITvBl6DG3gzNGLWCJiOWN9XTBH/cY9pGV3phVZqkdfrmM6MEJZ8pI yMxMGsfOYotRjaAZixXwBMkTR1TTfSkKQRuakvHF6KHQNOq38NyhbODUPOs4hH+KwCvTp6LA3ff4e D25v6Yzmw==; Received: from j217100.upc-j.chello.nl ([24.132.217.100] helo=hirez.programming.kicks-ass.net) by merlin.infradead.org with esmtpsa (Exim 4.90_1 #2 (Red Hat Linux)) id 1fyEq0-0001R7-Ne; Fri, 07 Sep 2018 11:22:08 +0000 Received: by hirez.programming.kicks-ass.net (Postfix, from userid 1000) id 80C3820191BFB; Fri, 7 Sep 2018 13:22:07 +0200 (CEST) Date: Fri, 7 Sep 2018 13:22:07 +0200 From: Peter Zijlstra To: Sai Praneeth Prakhya Cc: linux-efi@vger.kernel.org, linux-kernel@vger.kernel.org, x86@kernel.org, ricardo.neri@intel.com, matt@codeblueprint.co.uk, Al Stone , Borislav Petkov , Ingo Molnar , Andy Lutomirski , Bhupesh Sharma , Thomas Gleixner , Ard Biesheuvel Subject: Re: [PATCH V4 3/3] x86/efi: Introduce EFI_PAGE_FAULT_HANDLER Message-ID: <20180907112207.GS24106@hirez.programming.kicks-ass.net> References: <1536276468-28499-1-git-send-email-sai.praneeth.prakhya@intel.com> <1536276468-28499-4-git-send-email-sai.praneeth.prakhya@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1536276468-28499-4-git-send-email-sai.praneeth.prakhya@intel.com> User-Agent: Mutt/1.10.0 (2018-05-17) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Sep 06, 2018 at 04:27:48PM -0700, Sai Praneeth Prakhya wrote: > From: Sai Praneeth > > There may exist some buggy UEFI firmware implementations that might > access efi regions other than EFI_RUNTIME_SERVICES_ even > after the kernel has assumed control of the platform. This violates UEFI > specification. > > If selected, this debug option will print a warning message if the UEFI > firmware tries to access any memory region which it shouldn't. Along > with the warning, the efi page fault handler will also try to recover > from the page fault triggered by the firmware so that the machine > doesn't hang. Why make this optional?