Received: by 2002:ac0:a5a6:0:0:0:0:0 with SMTP id m35-v6csp2081963imm; Fri, 7 Sep 2018 10:29:48 -0700 (PDT) X-Google-Smtp-Source: ANB0VdYcnL4QrLMamn27lUNKGZZFdh5di7TrcQRj8PgCOcwNtmwDrbQAG0kBmcNDf3gh7A9ai8FO X-Received: by 2002:a63:d806:: with SMTP id b6-v6mr9217330pgh.347.1536341388738; Fri, 07 Sep 2018 10:29:48 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1536341388; cv=none; d=google.com; s=arc-20160816; b=x5S9F4AKAY7uAmqadbOBgwBAQ/+1DULnLJynk3OtghmdRMwTXIGxaEFjLOjiqAbheX llSeLOxhE+NIOPC6EKWBsQCEYBhSa5k5p1VqCT4btBXIlzp22f9VN5eUBnPYcXhEwARZ zW4ZfK2avJz7B20wVLPtnNrVGOztRihp0C4m6SGxiq9bnzBfdV9t+Nx9LryunK6cNvxJ 32FFoeuCiRY8wTgaME4vr87r/XY+/+cN42XPV2Jw0kh0mCGqZi0kX3iNSaadls7CNrmx f2css53RoUWUZ8w1L7fYqANRXdQvOlh+2GQn9pY+Qy2LGXZvfRt/RPzfXmduZohyTzhF Co7g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:message-id:date:subject:cc:to:from :dkim-signature; bh=wskbfu9PoVt18paWqNjzNRbWi9VPmOfU2FcnPWqS3ko=; b=YEOOHXAZch6vX1vOg20k8uKK6LLEN6cQjKUGUhN8z+joJHPzUIKaeqq1pPaSAOoYI7 T6s3F4kS+NirfXVca19WsybqEY41jGtwiWmA0DRiKEjfTxbuJGduXQ0vYSW9Tgjk3yWV FAmrCpu1FolAuTf7uBFveQlunqocbWAeyUFETZXlhbzavFy8XgZbIXkUbJ5ReCDKdaOh lE4sGzaK26+5J63s1hw9tCS3WR4KdaISCjE3x5nAP0cVQY2c8/wrCuYgr6jlDdEdjm2h YKeBEW6yAy1yC4aEPsw6ddMOSaDQz3n8a2DX9l3u4pKUXjJExTkLNmMRL7XKQHwcVIAv kevA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@163.com header.s=s110527 header.b=myKKd6I6; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id w11-v6si9253462pgm.616.2018.09.07.10.29.33; Fri, 07 Sep 2018 10:29:48 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@163.com header.s=s110527 header.b=myKKd6I6; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727636AbeIGWJf (ORCPT + 99 others); Fri, 7 Sep 2018 18:09:35 -0400 Received: from m12-15.163.com ([220.181.12.15]:59576 "EHLO m12-15.163.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725963AbeIGWJe (ORCPT ); Fri, 7 Sep 2018 18:09:34 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=163.com; s=s110527; h=From:Subject:Date:Message-Id; bh=wskbfu9PoVt18paWqN jzNRbWi9VPmOfU2FcnPWqS3ko=; b=myKKd6I6P2x6VsF8+csl5uDFJBSFHJW1GV uxd3hw/aTv4o3RomcrwwFUMdq0NTuWBrYKuKgnpvZvDOq77in++mRdvjMJn/qL0Q XMc2mK+LYiozGDTD9hf6HfCBEix8Jy5eJQX6sc7sJG7FUmB+u98m60OuAKG/x2MN EqHpqX+sY= Received: from localhost (unknown [183.156.140.9]) by smtp11 (Coremail) with SMTP id D8CowAAHYMsDtZJbkGTKGQ--.3266S5; Sat, 08 Sep 2018 01:27:33 +0800 (CST) From: jun qian To: Jens Axboe Cc: linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, jun qian Subject: [PATCH] block: umem: replace spin_lock_bh with spin_lock in tasklet callback Date: Fri, 7 Sep 2018 10:27:20 -0700 Message-Id: <20180907172720.48621-1-hangdianqj@163.com> X-Mailer: git-send-email 2.17.1 X-CM-TRANSID: D8CowAAHYMsDtZJbkGTKGQ--.3266S5 X-Coremail-Antispam: 1Uf129KBjvdXoW7Xr43KryDAF1fCr1fCr1kuFg_yoWfCwcEvr yrWF9IgrWqkwn0kr1Yv3ZxZryqka1jgFn5KFy2qa43J3srZas3Gw1vqrW3ZryDuFyxC3sx u342q347ur1xKjkaLaAFLSUrUUUUUb8apTn2vfkv8UJUUUU8Yxn0WfASr-VFAUDa7-sFnT 9fnUUvcSsGvfC2KfnxnUUI43ZEXa7IU81SoJUUUUU== X-Originating-IP: [183.156.140.9] X-CM-SenderInfo: pkdqwvpldq1yi6rwjhhfrp/1tbiRAW6R1SIX1xGYQAAsE Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org As you are already in a tasklet, it is unnecessary to call spin_lock_bh. Signed-off-by: jun qian --- drivers/block/umem.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/block/umem.c b/drivers/block/umem.c index 5c7fb8cc4149..9094ca60949c 100644 --- a/drivers/block/umem.c +++ b/drivers/block/umem.c @@ -421,7 +421,7 @@ static void process_page(unsigned long data) struct cardinfo *card = (struct cardinfo *)data; unsigned int dma_status = card->dma_status; - spin_lock_bh(&card->lock); + spin_lock(&card->lock); if (card->Active < 0) goto out_unlock; page = &card->mm_pages[card->Active]; @@ -496,7 +496,7 @@ static void process_page(unsigned long data) mm_start_io(card); } out_unlock: - spin_unlock_bh(&card->lock); + spin_unlock(&card->lock); while (return_bio) { struct bio *bio = return_bio; -- 2.17.1