Received: by 2002:ac0:a5a6:0:0:0:0:0 with SMTP id m35-v6csp2089474imm; Fri, 7 Sep 2018 10:36:20 -0700 (PDT) X-Google-Smtp-Source: ANB0VdZcdG68MTcbslO2x6KOa0v5C8ey+862nISfZjulTveb/VjrNhLFpQIuLk8N//EEaOjr86Xu X-Received: by 2002:aa7:86cb:: with SMTP id h11-v6mr9687492pfo.58.1536341780700; Fri, 07 Sep 2018 10:36:20 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1536341780; cv=none; d=google.com; s=arc-20160816; b=qK3Yz7HmH0/0vt6tX3CPUQJfDawMKpMVCatDoFCFZXzgXhT7pZGnzF8jrINekFvqNk d+bBAKDQ/ynPC1HiOOLe8KPzXbwVwk/2FRlv89mnjzYd5ON4VZQ7lJT2j+3jXUyaNS45 JN5OzPxQO4ZMrRPoY0QSWvkK/rWqWCRX4tSGDaEfC/vNiU5gAEiFd/uxLAKRuQoghfED hC2SEUD56HE3fExkANLU6xqqV3J4DBoTO/omEUn8XZhzGFcQdLz6/L07wuUJGSr36D0a dJd/iK6PW1B9Y1t7QQbqPq/Ps6Olcvuy5EVGQEMBFI5BKImx7lBbsYHoncorgld57siH qr8w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:from:references:cc:to:subject:dkim-signature; bh=IIVOPw0IT7dO2RNQN5S2lfVSdkqKlRPxxf7kzVHADsM=; b=qxQiyJO9ETOBX2msbwqKnovGLq3O95nBAfdXXkV8JtJEBQcijx533biABm60LQJ0Qp Fi1BoZTSFNbfa085aEx32TYYmQkOdVdwoCrLW61Jbx/4Kb2IXnZnyhvTe+d5iBdd9Y3J y/wcAMZs/2rYwJRxhz4Zlm9JsnJAYTE+hWQwz5pPrMrqowe0mQYvSdlJQXWcsYW1VXIb bhac+KFZXsb38m7+e5ANo2j7zi1Cnxuz9AvzQhDTCUbD2qDLQeCFM1F3kb+cJsDzPNBN KDWArWtFq2qSY5hIqx1AYqT9oL23zO3hGPAiTZOsxk2P1QfQ4BJgYBLAKZ/2mnkeC412 w0zQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel-dk.20150623.gappssmtp.com header.s=20150623 header.b=wfrJ5bR3; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id n17-v6si9546010pgh.501.2018.09.07.10.36.05; Fri, 07 Sep 2018 10:36:20 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel-dk.20150623.gappssmtp.com header.s=20150623 header.b=wfrJ5bR3; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727282AbeIGWQn (ORCPT + 99 others); Fri, 7 Sep 2018 18:16:43 -0400 Received: from mail-it0-f67.google.com ([209.85.214.67]:36507 "EHLO mail-it0-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726453AbeIGWQn (ORCPT ); Fri, 7 Sep 2018 18:16:43 -0400 Received: by mail-it0-f67.google.com with SMTP id u13-v6so20870511iti.1 for ; Fri, 07 Sep 2018 10:34:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel-dk.20150623.gappssmtp.com; s=20150623; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=IIVOPw0IT7dO2RNQN5S2lfVSdkqKlRPxxf7kzVHADsM=; b=wfrJ5bR3uRHTPfI9NLfLqTEZg7wuNlbzhwSVfbIUbYZjC4PVl7GbWT1CtAyFEucjAh Ftl6VavFNXiI8EbAxAOOiYc/WHoz9NK97Lw7IwPzkCzeul/lle/Nc0wuecH0Tw4gGo7z AyC2MfLLHqwXpMJ2/a8UVV7gPYVPCcMk02t5cG1amOdVmk6xa8Cs04AMYsEmzzKiKJYH czzo3hcZaFT3QYosTsNrXuMbS8ESxfww4123BjFJNIJWEoV4tmKy5ZdDbjIKfJU43iup FbIu/+60vHemSq+rLa+df7QNNznj9ScFc+djJ7+xSX9MGg16KB6QnV3Dn6UnPxDoTTRq 45Wg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=IIVOPw0IT7dO2RNQN5S2lfVSdkqKlRPxxf7kzVHADsM=; b=ud77UMiU8ON+GbJ9Kf5lULjpY3uQixQ/Iyk+mUEvpjC2cVylXcWdy50/Q+Ecaat7ex j10iMVH4GsZl2o+7ZDt3sLZD6wVgOJYyYAhWgRWW+/bPJb0y+iLDfLMntTZl9Vz9rpbo aj6KQpjYi/vlZUs0yWmTdCbp4vt7QuxSSnHJGv+n1kl5eCyPAXRyisd5mSqGka5fJbAW 9vvk7k517qx5w9H3An8SUeCh76cEH6Ik4DixbbTrTHA8PMi8FTtRv9nE8VKWDTjWexLB pWX6njA1e7pT55DQ4r6fcPf4KWQXehB46cacGeaTMzHjfCdUUrjwhHqGEoeA4cGDJ/iS ks9w== X-Gm-Message-State: APzg51AVSfz3BE787w56QApXggOV/NNlYWdcO3qESk7W/r74OsP+9w88 V/eThZLWK3nabuffQngK265Y0H8WH7c= X-Received: by 2002:a24:14d8:: with SMTP id 207-v6mr7600424itg.41.1536341684111; Fri, 07 Sep 2018 10:34:44 -0700 (PDT) Received: from [192.168.1.212] (107.191.0.22.static.utbb.net. [107.191.0.22]) by smtp.gmail.com with ESMTPSA id i2-v6sm2589500ioh.80.2018.09.07.10.34.42 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 07 Sep 2018 10:34:42 -0700 (PDT) Subject: Re: [PATCH] block: umem: replace spin_lock_bh with spin_lock in tasklet callback To: jun qian Cc: linux-block@vger.kernel.org, linux-kernel@vger.kernel.org References: <20180907172720.48621-1-hangdianqj@163.com> From: Jens Axboe Message-ID: <530bb11e-30a2-6088-913a-5edee1d5d63c@kernel.dk> Date: Fri, 7 Sep 2018 11:34:41 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.0 MIME-Version: 1.0 In-Reply-To: <20180907172720.48621-1-hangdianqj@163.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 9/7/18 11:27 AM, jun qian wrote: > As you are already in a tasklet, it is unnecessary to call spin_lock_bh. Looks good to me, applied. -- Jens Axboe