Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Fri, 07 Sep 2018 10:35:08 -0700 (PDT)
Message-Id: <20180907.103508.586853927030824859.davem@davemloft.net>
To:     jakub.kicinski@netronome.com
Cc:     hangdianqj@163.com, dirk.vandermerwe@netronome.com,
        daniel@iogearbox.net, quentin.monnet@netronome.com,
        oss-drivers@netronome.com, netdev@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ethernet:netronome:nfp:move spin_lock_bh to spin_lock
 in tasklet
From:   David Miller <davem@davemloft.net>
In-Reply-To: <20180907183636.48a681f4@cakuba>
References: <20180907162117.47361-1-hangdianqj@163.com>
        <20180907183636.48a681f4@cakuba>
Mime-Version: 1.0
Content-Type: Text/Plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

From: Jakub Kicinski <jakub.kicinski@netronome.com>
Date: Fri, 7 Sep 2018 18:36:36 +0200

> On Fri,  7 Sep 2018 09:21:17 -0700, jun qian wrote:
>> As you are already in a tasklet, it is unnecessary to call spin_lock_bh.
>> 
>> Signed-off-by: jun qian <hangdianqj@163.com>
> 
> FWIW you should put spaces after the colons.  It's generally a good
> practice to look at the prefix previous authors used for a given piece
> of code with 
> 
> git log -- $file_path
> 
> This would be a better subject:
> 
> nfp: replace spin_lock_bh with spin_lock in tasklet callback

Yes, please fix your subject styling.