Received: by 2002:ac0:a5a6:0:0:0:0:0 with SMTP id m35-v6csp2097026imm; Fri, 7 Sep 2018 10:43:48 -0700 (PDT) X-Google-Smtp-Source: ANB0VdaW1mqz9XGCOAbTQzDdIOdmhgc7FyfS9AoHCVTtH70eA/z+dt+93/gHkUkw1XGDztnzexxM X-Received: by 2002:a62:54c7:: with SMTP id i190-v6mr9645300pfb.155.1536342228560; Fri, 07 Sep 2018 10:43:48 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1536342228; cv=none; d=google.com; s=arc-20160816; b=Hx9pYVo/yd8QWL48rMWL22VRX92Opdx9noGqX+1R5dDAZpoPZmanRZ+J/bJZmCcuho hYfHNyKWihZ5xlOiadHdhuVP8FoAqddcdKuuPR3lLsq3maYz7nE9AV30OKTbKG2Ik5gr q0wW0GGb380ZOEpot7EQeWxIeBB+E+z3x7CIJw0874cF3JCZQ7OEM8W/255D4hnuYLPf clZ+fXKi7EvBeHwRKBN99NLTHYGQeBDE5tlJwRxekwNqi6WoOXWRn7kCmAw2inTtzi72 Z79T1q1332Q5yQFZ+yvWTGIMgnVXNTq2gtz8cjl3V4v7tdBTcvGPfIb1oQ98OuiW5VVi eWdg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :organization:references:in-reply-to:message-id:subject:cc:to:from :date:dkim-signature; bh=SDBqecwFp3ibGx/Oq42nQJf2flCk+viNp8p/Is/DPJ0=; b=AxUNAKN81mskBwG/fFRDUV1OYVN5B4mCwi45KLDoWfjk467BbqyrKllJThHHSYRQOw 1eEItY2tgbfX9fETy2noFLHb4fhZEKgznG31M/u93qXjR35/epWFdL71DuFDCaKROp3n xG8wOqxmyQ899UuQMiFJ+B5Ql1SWXhrpchfuTbdsFE2r5MUQSs2XYZuJpzKpUrNEI6Mv 6puy15iNotUs7Zpoq1lDRLRaIipoJjhb373Y6NRMoGftk7FeTZjMo+BfISB6BKGqr2ZQ SRsXqEsct5VR5znFURH3zUX1+beo7+bxVKoVuNn/3G+iWn5jUl5GWZ26Gwwo+cmVkiFv jl/w== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@netronome-com.20150623.gappssmtp.com header.s=20150623 header.b=apPGmYDC; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id f62-v6si8414190plf.164.2018.09.07.10.43.32; Fri, 07 Sep 2018 10:43:48 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@netronome-com.20150623.gappssmtp.com header.s=20150623 header.b=apPGmYDC; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727692AbeIGWYP (ORCPT + 99 others); Fri, 7 Sep 2018 18:24:15 -0400 Received: from mail-pg1-f194.google.com ([209.85.215.194]:38647 "EHLO mail-pg1-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726591AbeIGWYP (ORCPT ); Fri, 7 Sep 2018 18:24:15 -0400 Received: by mail-pg1-f194.google.com with SMTP id t84-v6so5490789pgb.5 for ; Fri, 07 Sep 2018 10:42:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=netronome-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:in-reply-to:references :organization:mime-version:content-transfer-encoding; bh=SDBqecwFp3ibGx/Oq42nQJf2flCk+viNp8p/Is/DPJ0=; b=apPGmYDCrix9ckHqHpxMDpLy2+qN2UXv4BdLNMzp2wNwa49y3XejU3d9kokgwr72jm 1LhXaktxWhPhoJRRd7epzUndHIvIQ3wqhxY7ZtdGX7IHxi3XN6oCBfhUtZvoExZ9HqEm VkmBOVFy4Rz77NwAPTCraJlkS40v980i6tNzGcQrX0bsN5Ky9kWbaC7kFJgHT9Rb/GEI 9KwsUeeUp6arIm1aDHWZTVL2RIsQLaXV/ZypujvEnhxlaUt+6gXqNhe0GzS09+4h0BaS s8gOQRTnC2C0LPgkobwOnHhELoJmfpyzGgt3XaFNHcYOsIMvjocM28tqaMNnp6Ie05J8 xzzQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:organization:mime-version:content-transfer-encoding; bh=SDBqecwFp3ibGx/Oq42nQJf2flCk+viNp8p/Is/DPJ0=; b=oMmN/4iTsgzdlM7d0enNjAImGXxqp4syEgg06fwO5RmjW2fRG13XGlVeTpvK7+jc2e MxBquE1+MkHNRs32pm9nXV1fSpiWtQvCGkTKk6iBC4kc3Yj3x4NcQXmT1vFe0KV5y9ig cUAXdscqhrhxi+ZspSnqAc9kkyb5mp+8ZjzhZVXGQD0D5ywsNbLT6Sa9t/1xl2SIH9Zv SbwfQe2nNkMqj4S7iFMsU5YKd6JSo6sEQSsS+M68UnNaS4y8G8LmuX3S6NIcy+lLtwye z8vg2mKe7uH7Zianwfl3bGDmsmSLNHoR5dqH+nExarMFjTTgwzRfa39NI/cpdpyWt+JH U5Yg== X-Gm-Message-State: APzg51AsORuiqsui6xodTO2MyzGRWNcywteViu2hfdafRoSHoJG/R4I1 h+1EtpLG3FvdwkSIIrY3v1n92g== X-Received: by 2002:a62:d113:: with SMTP id z19-v6mr9687344pfg.98.1536342135214; Fri, 07 Sep 2018 10:42:15 -0700 (PDT) Received: from cakuba (89-66-82-92.dynamic.chello.pl. [89.66.82.92]) by smtp.gmail.com with ESMTPSA id a15-v6sm16686153pfe.32.2018.09.07.10.42.12 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Fri, 07 Sep 2018 10:42:15 -0700 (PDT) Date: Fri, 7 Sep 2018 19:42:07 +0200 From: Jakub Kicinski To: jun qian Cc: Dirk van der Merwe , Daniel Borkmann , Quentin Monnet , oss-drivers@netronome.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] nfp: replace spin_lock_bh with spin_lock in tasklet callback Message-ID: <20180907194207.5f7c7386@cakuba> In-Reply-To: <20180907170109.48150-1-hangdianqj@163.com> References: <20180907170109.48150-1-hangdianqj@163.com> Organization: Netronome Systems, Ltd. MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 7 Sep 2018 10:01:09 -0700, jun qian wrote: > As you are already in a tasklet, it is unnecessary to call spin_lock_bh. > > Signed-off-by: jun qian Acked-by: Jakub Kicinski