Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Fri, 7 Sep 2018 13:50:14 -0400
From:   Kent Overstreet <kent.overstreet@gmail.com>
To:     Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp>
Cc:     linux-kernel@vger.kernel.org, Dave Hansen <dave.hansen@intel.com>,
        Matthew Wilcox <willy@infradead.org>,
        linux-security-module@vger.kernel.org
Subject: Re: [PATCH 3/6] selinux: convert to kvmalloc
Message-ID: <20180907175014.GA29485@kmo-pixel>
References: <20180907165635.8469-1-kent.overstreet@gmail.com>
 <20180907165635.8469-4-kent.overstreet@gmail.com>
 <89c167ff-91d3-7a27-78c6-82710bb11771@I-love.SAKURA.ne.jp>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <89c167ff-91d3-7a27-78c6-82710bb11771@I-love.SAKURA.ne.jp>
User-Agent: Mutt/1.10.1 (2018-07-13)
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Sat, Sep 08, 2018 at 02:08:03AM +0900, Tetsuo Handa wrote:
> On 2018/09/08 1:56, Kent Overstreet wrote:
> > @@ -329,8 +328,7 @@ int avtab_alloc(struct avtab *h, u32 nrules)
> >  		nslot = MAX_AVTAB_HASH_BUCKETS;
> >  	mask = nslot - 1;
> >  
> > -	h->htable = flex_array_alloc(sizeof(struct avtab_node *), nslot,
> > -				     GFP_KERNEL | __GFP_ZERO);
> > +	h->htable = kvmalloc_array(nslot, sizeof(void *), GFP_KERNEL);
> >  	if (!h->htable)
> >  		return -ENOMEM;
> >  
> 
> kvmalloc_array() does not imply __GFP_ZERO.

Thanks, fixed