Received: by 2002:ac0:a5a6:0:0:0:0:0 with SMTP id m35-v6csp2189005imm; Fri, 7 Sep 2018 12:11:42 -0700 (PDT) X-Google-Smtp-Source: ANB0VdaRs3xvSwM2EIxzimmyL4u+TVhkdkTd86Gq9IbXqxBDS07ux2ODAU7Kh/BrqfwlbEwOo9iZ X-Received: by 2002:a17:902:5381:: with SMTP id c1-v6mr9583720pli.296.1536347502885; Fri, 07 Sep 2018 12:11:42 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1536347502; cv=none; d=google.com; s=arc-20160816; b=C8Wxia/tP8ubsuCwkjKm/Blg2eWJ6Cl9nte1Muwo9/wqsTj1N931MUhr5rwYsNSpm0 Zf0gooEYHWm7fBEu4dIfVJQ4XVQPViTndgIw/idSXYM3rnuwOEvP46A+lEldAbSh9li8 RNnnC+Qu1XRZYxO6wjm1xUG6tzUkD9EgiLWBt14KpObP03aIB66piwQbWZMdnyDUm3Q5 7PMchGIRKsPPa7LpDP8t0H2EqGvC1fBK8oEI/gB1ro10l3dEDKYRzX0ZaS8G6K2GE1NA eYi3rixN6qD7if+FP9rD8P/SqF9/nQQWG7mi4xtNHMzYGqPphhZ/gftvWHHy98uSIake hThg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-language :content-transfer-encoding:in-reply-to:mime-version:user-agent:date :message-id:from:references:cc:to:subject:dkim-signature; bh=6lYFa4N5C0k1wO6SvIBdnBOHFiTQ1r0+eU5R9FcHBiA=; b=oZKgkVUC4z92qy3Gl2ThrBoiNAQVrgmGQU4GpgOaaqRdppiUp4/IyW53bfr8yeTf6j 0b5+8YqcLFfZKH8Pg39hH4jMeSpu3hlvT96pwNAOe3ag1mBv5l/6AuIxAJKU/DmRjwtg 0K0dS41aOVU7jYTem0i1VIAxUjPibmJV0G869b9r0pYSrLMD+OSDWx0lGUWtlsKOVEQP bd+dLyLod+Ifb1dNT5fksLKcW84sEoFQjvUZ+lBOHdHfHjyTjnoYaifEtRLBQMem2+sX 6K13xT+j57Clh4ZUtpGeMUMnRjpgKt4+pCOASwuW+XP3oRY3MAbR3rOJ3/mqd1jjJcLP nzqw== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@obeliks.de header.s=jul2017 header.b=cE+DtvO2; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=obeliks.de Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id e12-v6si8429667pfn.322.2018.09.07.12.11.26; Fri, 07 Sep 2018 12:11:42 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=fail header.i=@obeliks.de header.s=jul2017 header.b=cE+DtvO2; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=obeliks.de Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726447AbeIGXu4 (ORCPT + 99 others); Fri, 7 Sep 2018 19:50:56 -0400 Received: from scopuli.esotechnik.de ([79.143.188.15]:56368 "EHLO mail.esotechnik.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725963AbeIGXu4 (ORCPT ); Fri, 7 Sep 2018 19:50:56 -0400 Received: by mail.esotechnik.net (Postfix) with ESMTPSA id 4B20AAE0B80; Fri, 7 Sep 2018 21:08:35 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=obeliks.de; s=jul2017; t=1536347315; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=6lYFa4N5C0k1wO6SvIBdnBOHFiTQ1r0+eU5R9FcHBiA=; b=cE+DtvO2Umqay0t5vUHViTV8JfaF2Z7IXzjc/eBVqN+AFQih/guQt6BEmJ5/p+drxasrGT R9oCPlVWnZfXU+JD9m5IOcy0Ih3DsIZ1LvCnYM6VAYAo7rlssi9ChAIYpemJ4l+FTyJ1Yu B5tqmYNtoc7gLNl2dFLJHLMWXaILINlD0jOOp1DG33wex+ii/x/kVGwKARpdqfcXXhJt0x L0M2qjH/uV490tVx3HaSlgraFs4IEIz3PiKR6oEpuUDT0oalfjhyhJoCtgr/crgT8R4v3S A0hPGcwqvK/1JS3J5ASvT4c/I6+Y4fjTwKJAzd31mklCPDXbQugU9C4wyGXV5w== Subject: Re: [PATCH v2 0/3] mtd concat device driver To: Bernhard Frauendienst , David Woodhouse , Brian Norris , Boris Brezillon , Marek Vasut , Richard Weinberger Cc: linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org, Miquel Raynal References: <20180907173515.19990-1-kernel@nospam.obeliks.de> <20180907173515.19990-2-kernel@nospam.obeliks.de> <7ea0a54e-fc10-8e21-aa2f-864c40297369@nospam.obeliks.de> From: Bernhard Frauendienst Message-ID: <828f1767-a937-b081-fe9a-447f5b9f0a3b@nospam.obeliks.de> Date: Fri, 7 Sep 2018 21:08:34 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <7ea0a54e-fc10-8e21-aa2f-864c40297369@nospam.obeliks.de> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello, it looks like I didn't even manage to correctly CC the device tree maintainers and list, which was the main reason for sending out this second roll. This is getting embarrassing, but I guess I will simply prepare a 3rd roll and try even harder to send it to the right people this time (without relying on any script magic). Of course I'm happy to include any suggestions you have in the meantime. Sorry for the disturbance! Best regards, Bernhard Am 07.09.2018 um 20:12 schrieb Bernhard Frauendienst: > Apologies, again, I seem not to be able to handle git-send-mail > correctly, the cover letter got lost in operation (using get_maintainers > on a cover letter is not a good idea). Here it is again: > > > Hi everybody, > > when porting my router board from a mach-file based OpenWRT target to a > device-tree based target, I found that there is no generic way to create > a mtd_concat device from within the dts. The following patches attempt > to provide that possibility. > > This is a second roll of that patch series, the first one can be seen at > [1]. Apologies for not including the correct recipients in the first > roll. > > In this first discussion, concerns were raised that a driver for a > "virtual" device like this might have no place in the device tree > system. However, I would argue that this very similar to specifying the > partitions of a mtd device, which can also done in the device tree. In > fact, I believe this is the only way to be able to specify the > partitions of such a concat device in the dts file (but I'm happy to be > corrected if I'm mistaken). > I have made the example in the dt-binding documentation a little bit > more expressive in this detail. > > In this second roll I have also addressed all issues that reviewers have > brought up so far, hopefully to their satisfaction. > > Best Regards > Bernhard > > [1] http://lists.infradead.org/pipermail/linux-mtd/2018-September/083832.html > > > Bernhard Frauendienst (3): > mtd: core: add get_mtd_device_by_node > dt-bindings: add bindings for mtd-concat devices > mtd: mtdconcat: add dt driver for concat devices > > .../devicetree/bindings/mtd/mtd-concat.txt | 36 +++++ > drivers/mtd/Kconfig | 2 + > drivers/mtd/Makefile | 3 + > drivers/mtd/composite/Kconfig | 12 ++ > drivers/mtd/composite/Makefile | 7 + > drivers/mtd/composite/virt_concat.c | 128 ++++++++++++++++++ > drivers/mtd/mtdcore.c | 38 ++++++ > include/linux/mtd/mtd.h | 2 + > 8 files changed, 228 insertions(+) > create mode 100644 Documentation/devicetree/bindings/mtd/mtd-concat.txt > create mode 100644 drivers/mtd/composite/Kconfig > create mode 100644 drivers/mtd/composite/Makefile > create mode 100644 drivers/mtd/composite/virt_concat.c >