Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S262864AbTKJEgK (ORCPT ); Sun, 9 Nov 2003 23:36:10 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S262868AbTKJEgK (ORCPT ); Sun, 9 Nov 2003 23:36:10 -0500 Received: from pat.uio.no ([129.240.130.16]:16112 "EHLO pat.uio.no") by vger.kernel.org with ESMTP id S262864AbTKJEgK (ORCPT ); Sun, 9 Nov 2003 23:36:10 -0500 To: Linus Torvalds Cc: Neil Brown , Andrew Morton , Burton Windle , Subject: Re: slab corruption in test9 (NFS related?) References: From: Trond Myklebust Date: 09 Nov 2003 23:36:00 -0500 In-Reply-To: Message-ID: User-Agent: Gnus/5.0808 (Gnus v5.8.8) XEmacs/21.4 (Honest Recruiter) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-MailScanner-Information: This message has been scanned for viruses/spam. Contact postmaster@uio.no if you have questions about this scanning. X-UiO-MailScanner: No virus found Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 736 Lines: 13 >>>>> " " == Linus Torvalds writes: > In other words, your patch certainly looks obviously correct, > but it also looks _so_ obviously correct that my alarm bells > are going off. If the code was quite that broken at counting > dentries, how the hell did it ever work AT ALL? Given that d_free() now uses rcu, and hence defers the actual call to kmem_cache_free(), might that not suffice to explain why actual consequences are rare? Cheers, Trond - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/