From: Dmitry Torokhov <dtor_core@ameritech.net>
To: Andrew Morton <akpm@osdl.org>, arief_mulya <arief_m_utama@telkomsel.co.id>
Subject: Re: [PATCH?] psmouse-base.c
Date: Mon, 10 Nov 2003 01:43:58 -0500
User-Agent: KMail/1.5.4
Cc: vojtech@suse.cz, linux-kernel@vger.kernel.org
References: <3FAEF7BC.8060503@telkomsel.co.id> <20031109201211.2ce2edce.akpm@osdl.org>
In-Reply-To: <20031109201211.2ce2edce.akpm@osdl.org>
MIME-Version: 1.0
Content-Type: text/plain;
  charset="us-ascii"
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
Message-Id: <200311100143.58955.dtor_core@ameritech.net>
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1175
Lines: 34

On Sunday 09 November 2003 11:12 pm, Andrew Morton wrote:
> arief_mulya <arief_m_utama@telkomsel.co.id> wrote:
> > static int psmouse_pm_callback(struct pm_dev *dev, pm_request_t
> > request, void *data)
> >  {
> >          struct psmouse *psmouse = dev->data;
> >          struct serio_dev *ser_dev = psmouse->serio->dev;
> >
> >
> >          switch (request) {
> >          case PM_RESUME:
> >                  psmouse->state = PSMOUSE_IGNORE;
> >                  serio_rescan(psmouse->serio);
> >          default:
> >                  return 0;
> >          }
> >  }
>
> What does the driver do without this change?  ie: what problem is this
> fixing?
>
> Why is it calling serio_rescan() rather than serio_reconnect()?
>

serio_reconnect() is only in your tree (-mm), it has not been pushed to
Linus yet... Unfortunately using rescan can cause input devices be shifted
if some program has them open while suspending.

Dmitry
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/