Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Fri, 07 Sep 2018 14:46:59 -0700 (PDT)
Message-Id: <20180907.144659.284526279757617907.davem@davemloft.net>
To:     igor.stoppa@gmail.com
Cc:     huangdaode@hisilicon.com, igor.stoppa@huawei.com,
        yisen.zhuang@huawei.com, salil.mehta@huawei.com,
        netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ethernet: hnae: add unlikely() to assert()
From:   David Miller <davem@davemloft.net>
In-Reply-To: <20180907172650.29408-1-igor.stoppa@huawei.com>
References: <20180907172650.29408-1-igor.stoppa@huawei.com>
Mime-Version: 1.0
Content-Type: Text/Plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

From: Igor Stoppa <igor.stoppa@gmail.com>
Date: Fri,  7 Sep 2018 20:26:50 +0300

> The assert() condition is likely to be true.

Worse than that is that drivers should not be definiting their own
private "assert()" macro.

I'd rather have that fixed instead.  We have tons of standard kernel
facilities that do what they are trying to do here, without overloading
the standard C namespace in this way.