Received: by 2002:ac0:a5a6:0:0:0:0:0 with SMTP id m35-v6csp2334829imm; Fri, 7 Sep 2018 14:53:16 -0700 (PDT) X-Google-Smtp-Source: ANB0VdYytekLGf/QCpbeKNP0e6LA9SieEPX4uRZa8+XJIg5hir86W/2XGYAOV1idOsk4YUZalVH/ X-Received: by 2002:a63:2b4d:: with SMTP id r74-v6mr10447317pgr.406.1536357196707; Fri, 07 Sep 2018 14:53:16 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1536357196; cv=none; d=google.com; s=arc-20160816; b=j504tPyVhv7acKNcBXPS5Sv/1OFuZipG307/WbdNaJK4rPbCy/WEOQ0JWW9hm24gDt gL/UntjNKmK1MMx7a6FXe5LZ+uMaa8j3RpyF4QqZFOYHCrHIufpKn8/Ku0sWCC8FrP7c EsLFYNcuVywazpEUg+gNx/IgDhMSFQxKR3BVb2hDYGcf+qZBhjLkdZrbz3pSMaWDpq0i FpdoK0v098Sv9wmWU674WES10A+rpMT2l/T6EUoEf5Z0sTA7JF8nWQzAf17xPREciI55 vqoj4MHADmOqQxhslHu+JKPr61RLaPuoTwg7EKQihYUa8DMKsRiSUVJzTeDABYLeqKG4 i+8Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:from:subject:cc:to:message-id:date; bh=4j8YapbeffkGwAJcFvNNtL7sgRFPRlfdmJ8YZEaabRc=; b=HCy59o5Q2Jk/eo4Jjcm+vMz4HoqVFqsMP3fTroLTjFlPn9oiLDChpRi7AY2jjQAupk ot0ISDiSzcQ2rG1Xke/ptceueonzvvYyFEZXLNVze+x3Nqqz3P/T6fuow2cc6aZG1wcf ALGPXNtN6lcHbzL0lKmJ8gRK8McQZgoPfjVq1WqzA3fT638oEo3usRpt8fLhqqTWUbdL sybQJj4jCqIHe4BVDtAnOV22S826V9e6dhz4aHNm1iM1nglMgcmHUdC1BOpaFguAelIs TmAVOQICBv4AxUFD9UBwVZodqjx5Ixz/ka0vM1ALGeasitr1fEG+WezLt2dPwzyPiigg YYmw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id p2-v6si9454420pgj.391.2018.09.07.14.53.01; Fri, 07 Sep 2018 14:53:16 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730876AbeIHCdr (ORCPT + 99 others); Fri, 7 Sep 2018 22:33:47 -0400 Received: from shards.monkeyblade.net ([23.128.96.9]:53322 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729399AbeIHCdq (ORCPT ); Fri, 7 Sep 2018 22:33:46 -0400 Received: from localhost (unknown [207.32.164.225]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id C9A0E147B789D; Fri, 7 Sep 2018 14:50:48 -0700 (PDT) Date: Fri, 07 Sep 2018 14:50:48 -0700 (PDT) Message-Id: <20180907.145048.132302042564688282.davem@davemloft.net> To: igor.stoppa@gmail.com Cc: madalin.bucur@nxp.com, igor.stoppa@huawei.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] freescale: ethernet: remove unnecessary unlikely() From: David Miller In-Reply-To: <20180907172318.29014-1-igor.stoppa@huawei.com> References: <20180907172318.29014-1-igor.stoppa@huawei.com> X-Mailer: Mew version 6.7 on Emacs 26 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Fri, 07 Sep 2018 14:50:49 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Igor Stoppa Date: Fri, 7 Sep 2018 20:23:18 +0300 > Both WARN_ON() and WARN_ONCE() already contain an unlikely(), so it's not > necessary to wrap it into another. > > Signed-off-by: Igor Stoppa Applied.