Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
From:   Anurag Kumar Vulisha <anuragku@xilinx.com>
To:     Thinh Nguyen <Thinh.Nguyen@synopsys.com>,
        "balbi@kernel.org" <balbi@kernel.org>,
        "gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>
CC:     "linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "v.anuragkumar@gmail.com" <v.anuragkumar@gmail.com>
Subject: RE: [PATCH v3 4/8] usb: dwc3: implement stream transfer timeout
Thread-Topic: [PATCH v3 4/8] usb: dwc3: implement stream transfer timeout
Thread-Index: AQHURqy2XdgImSxcKE+4+6HL+fInlqTlvogg
Date:   Sat, 8 Sep 2018 03:48:58 +0000
Message-ID: <BN3PR0201MB099333AF66E6D205AD1520EEA7070@BN3PR0201MB0993.namprd02.prod.outlook.com>
References: <1536326029-16327-1-git-send-email-anurag.kumar.vulisha@xilinx.com>
 <1536326029-16327-5-git-send-email-anurag.kumar.vulisha@xilinx.com>
 <30102591E157244384E984126FC3CB4F544AD89B@us01wembx1.internal.synopsys.com>
In-Reply-To: <30102591E157244384E984126FC3CB4F544AD89B@us01wembx1.internal.synopsys.com>
Accept-Language: en-US
Content-Language: en-US
received-spf: None (protection.outlook.com: xilinx.com does not designate
 permitted sender hosts)
spamdiagnosticoutput: 1:99
spamdiagnosticmetadata: NSPM
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: ff052d4e-18b7-44a4-86de-08d6153e022c
X-MS-Exchange-CrossTenant-originalarrivaltime: 08 Sep 2018 03:48:58.2257
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 657af505-d5df-48d0-8300-c31994686c5c
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN3PR0201MB0867
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


HI Thinh,

>> ---
>>  drivers/usb/dwc3/core.h   |  7 +++++++
>>  drivers/usb/dwc3/gadget.c | 36 ++++++++++++++++++++++++++++++++++++
>>  2 files changed, 43 insertions(+)
>>
>> diff --git a/drivers/usb/dwc3/core.h b/drivers/usb/dwc3/core.h index
>> 5bfb625..0b255e97 100644
>> --- a/drivers/usb/dwc3/core.h
>> +++ b/drivers/usb/dwc3/core.h
>> @@ -633,6 +633,11 @@ struct dwc3_event_buffer {
>>
>>  #define DWC3_TRB_NUM		256
>>
>> +/*
>> + * Timeout value in msecs used by stream_timeout_timer when streams
>> +are enabled  */
>> +#define STREAM_TIMEOUT_MS	50
>> +
>>  /**
>>   * struct dwc3_ep - device side endpoint representation
>>   * @endpoint: usb endpoint
>> @@ -656,6 +661,7 @@ struct dwc3_event_buffer {
>>   * @name: a human readable name e.g. ep1out-bulk
>>   * @direction: true for TX, false for RX
>>   * @stream_capable: true when streams are enabled
>> + * @stream_timeout_timer: timer used to aviod deadlock when streams
>> + are used
>
>Change aviod -> avoid. Also, the timer is being used when there's a deadlo=
ck rather
>than to avoid it. You probably need to explain what deadlock it is if you =
mentioned it
>here, but I think it's ok to simply say timeout timer for streams (unless =
Felipe has any
>objection).

Thanks for correcting again , will fix it in the next version of patch,

Thanks,
Anurag Kumar Vulisha