Received: by 2002:ac0:a5a6:0:0:0:0:0 with SMTP id m35-v6csp314885imm; Fri, 7 Sep 2018 22:57:54 -0700 (PDT) X-Google-Smtp-Source: ANB0VdbZw3Tbdk8Wl1DbGa/DzmCHX293cG7NIqW/0uJUg4tNzYEJqeItZVTC/ydDe2y3jwvC/ERF X-Received: by 2002:a65:668f:: with SMTP id b15-v6mr9187057pgw.426.1536386274175; Fri, 07 Sep 2018 22:57:54 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1536386274; cv=none; d=google.com; s=arc-20160816; b=qbpXU36IZs/feWCa1TeEJ0TbD5t8fnTFxO8GvsIBSgMInCFK4vMmEC2ndJDY3Alrhi H/lCaIAJT1CI+MvDbjinPr0UDjCgNHv5K9tOGJBSv2rqoR354IRVybvB8OYsJNM8GkVT 8bS4QLfz92A8+2NigKY6VcEeBJvitxWLqvMU43FQfda+WIyPw/wpdAFTV8KcTDAFV+wo MX7lWJWSHWVlbwHR7u24WP5VCPNsArojUTXwzMtrMkZAQFECP52Vt7dtkwKzCch57tnl 9AmXpIeDXXs+xaXo+VphezrkUn4ppBEx9YmzxkQW+S/0nZDRXt9/OYRTjkySPo/2KIrf xHYA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:from:subject:cc:to:message-id:date; bh=qoYSxAaBr8Z0Fjd8MTWSXdUv3tbkcZHtFxBxJu9y7Uw=; b=n+8XaimW1+RmUSziJ13LSWGko4OUXrECEHIc6dly74tsZDc6tf5v+ggogOPGILVHxE u1A+CQgYmprZI5kGROzr1yqNw+tW9rU5mFx4pHqWdgpxT+H/0jBUGCITH673MIQfBkgj +vCZFR/fW5YqwjakZQlONmLiiF7EfQHraYq+8e6oOkwv1wd8u098YQ+JwAyJMdaI522u 1RtEGQCvJynDfaw1nJtX3vdKXYq3VPHbahF/w+lIor3J11XIcFyn0/4vkEtASD8XpxGn UOqzpNc7x/Q9Ij90lEhxF6QyMxFDzXcOD35isSdDcG//4wXhXl31RSMa6VpEI1nCXUAV sfmA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id x66-v6si10857406pfx.129.2018.09.07.22.57.36; Fri, 07 Sep 2018 22:57:54 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726343AbeIHKkx (ORCPT + 99 others); Sat, 8 Sep 2018 06:40:53 -0400 Received: from shards.monkeyblade.net ([23.128.96.9]:57286 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725999AbeIHKkx (ORCPT ); Sat, 8 Sep 2018 06:40:53 -0400 Received: from localhost (74-93-104-98-Washington.hfc.comcastbusiness.net [74.93.104.98]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id 7F9D010082598; Fri, 7 Sep 2018 22:56:22 -0700 (PDT) Date: Fri, 07 Sep 2018 22:56:18 -0700 (PDT) Message-Id: <20180907.225618.1479462649726004474.davem@davemloft.net> To: hangdianqj@163.com Cc: jakub.kicinski@netronome.com, dirk.vandermerwe@netronome.com, daniel@iogearbox.net, quentin.monnet@netronome.com, oss-drivers@netronome.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] nfp: replace spin_lock_bh with spin_lock in tasklet callback From: David Miller In-Reply-To: <20180907170109.48150-1-hangdianqj@163.com> References: <20180907170109.48150-1-hangdianqj@163.com> X-Mailer: Mew version 6.7 on Emacs 25.3 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Fri, 07 Sep 2018 22:56:22 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: jun qian Date: Fri, 7 Sep 2018 10:01:09 -0700 > As you are already in a tasklet, it is unnecessary to call spin_lock_bh. > > Signed-off-by: jun qian Applied to net-next, thanks.