Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Sat, 8 Sep 2018 15:18:10 +0200 (CEST)
From:   Stefan Wahren <stefan.wahren@i2se.com>
To:     Takashi Iwai <tiwai@suse.de>
Cc:     Eric Anholt <eric@anholt.net>,
        linux-rpi-kernel@lists.infradead.org,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        linux-kernel@vger.kernel.org
Message-ID: <2050605805.39126.1536412690563@email.1und1.de>
In-Reply-To: <20180904155858.8001-1-tiwai@suse.de>
References: <20180904155858.8001-1-tiwai@suse.de>
Subject: Re: [PATCH 00/29] staging: bcm2835-audio: Cleanups and fixes
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Importance: Medium
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Hi Takashi,

> Takashi Iwai <tiwai@suse.de> hat am 4. September 2018 um 17:58 geschrieben:
> 
> 
> Hi,
> 
> since I had an opportunity to play with RPi3B+ recently, I took a look
> at the existing bcm2835-audio driver code and was amused very much :)
> 
> So here is the result, a cleanup and fix patch series.
> 
> Most of the patches are trivial cleanups, just brushing up, removing
> many redundant and buggy codes, as well as code simplifications.
> 
> A big functional change is that now it uses non-atomic PCM ops, so
> that we can kill the ugly workqueue usages.  Also, the resource
> management was simplified.

first of all, thank you very much for this series.

Eric has no time as maintainer, so i will try to give you some feedback (beware of very little audio driver knowledge).

I functionally tested your patch series on a Raspberry Pi 1 B (bcm2835_defconfig), so this whole series is at least:

Tested-by: Stefan Wahren <stefan.wahren@i2se.com>

Unfortunately there is still an corruption issue with underlying vchiq and multi_v7_defconfig, so no wider tests.

I don't know if you tested this series on a Raspberry Pi. Maybe you have some specific scenarios, which should be tested.

As a reviewer i have some suggestions, but only trivia. I don't know if it's a problem that this series hasn't been send to devel@driverdev.osuosl.org

Stefan