Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Subject: Re: [PATCH] ethernet: hnae: add unlikely() to assert()
To:     David Miller <davem@davemloft.net>
Cc:     huangdaode@hisilicon.com, igor.stoppa@huawei.com,
        yisen.zhuang@huawei.com, salil.mehta@huawei.com,
        netdev@vger.kernel.org, linux-kernel@vger.kernel.org
References: <20180907172650.29408-1-igor.stoppa@huawei.com>
 <20180907.144659.284526279757617907.davem@davemloft.net>
From:   Igor Stoppa <igor.stoppa@gmail.com>
Message-ID: <aaa1a5f7-6809-794b-f6e6-b5b2ae34b046@gmail.com>
Date:   Sat, 8 Sep 2018 18:00:27 +0300
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101
 Thunderbird/52.9.1
MIME-Version: 1.0
In-Reply-To: <20180907.144659.284526279757617907.davem@davemloft.net>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk


On 08/09/18 00:46, David Miller wrote:
> From: Igor Stoppa <igor.stoppa@gmail.com>
> Date: Fri,  7 Sep 2018 20:26:50 +0300
> 
>> The assert() condition is likely to be true.
> 
> Worse than that is that drivers should not be definiting their own
> private "assert()" macro.
> 
> I'd rather have that fixed instead.  We have tons of standard kernel
> facilities that do what they are trying to do here, without overloading
> the standard C namespace in this way.

I've converted into WARN() what passed the compile test.
In one case it didn't even compile :-(

I could only compile-test.

--
igor