Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Sat, 8 Sep 2018 08:54:22 -0700
From:   Matthew Wilcox <willy@infradead.org>
To:     Johannes Weiner <hannes@cmpxchg.org>
Cc:     Alexey Dobriyan <adobriyan@gmail.com>,
        linux-kernel@vger.kernel.org, vjitta@codeaurora.org,
        sumit.semwal@linaro.org, rientjes@google.com, mhocko@kernel.org,
        mgorman@techsingularity.net, labbott@redhat.com,
        iamjoonsoo.kim@lge.com, guro@fb.com, cl@linux.com, vbabka@suse.cz
Subject: Re: + mm-slab-shorten-kmalloc-cache-names-for-large-sizes.patch
 added to -mm tree
Message-ID: <20180908155422.GA26807@bombadil.infradead.org>
References: <20180906224849.1JOWr%akpm@linux-foundation.org>
 <20180907195816.GA28375@avx2>
 <20180908140306.GB17637@cmpxchg.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20180908140306.GB17637@cmpxchg.org>
User-Agent: Mutt/1.9.2 (2017-12-15)
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Sat, Sep 08, 2018 at 10:03:06AM -0400, Johannes Weiner wrote:
> On Fri, Sep 07, 2018 at 10:58:16PM +0300, Alexey Dobriyan wrote:
> > On Thu, Sep 06, 2018 at 03:48:49PM -0700, akpm@linux-foundation.org wrote:
> > > -	{"kmalloc-1024",         1024},		{"kmalloc-2048",         2048},
> > > -	{"kmalloc-4096",         4096},		{"kmalloc-8192",         8192},
> > > -	{"kmalloc-16384",       16384},		{"kmalloc-32768",       32768},
> > > -	{"kmalloc-65536",       65536},		{"kmalloc-131072",     131072},
> > > -	{"kmalloc-262144",     262144},		{"kmalloc-524288",     524288},
> > > -	{"kmalloc-1048576",   1048576},		{"kmalloc-2097152",   2097152},
> > > -	{"kmalloc-4194304",   4194304},		{"kmalloc-8388608",   8388608},
> > > -	{"kmalloc-16777216", 16777216},		{"kmalloc-33554432", 33554432},
> > > -	{"kmalloc-67108864", 67108864}
> > > +	{"kmalloc-1k",           1024},		{"kmalloc-2k",           2048},
> > > +	{"kmalloc-4k",           4096},		{"kmalloc-8k",           8192},
> > > +	{"kmalloc-16k",         16384},		{"kmalloc-32k",         32768},
> > > +	{"kmalloc-64k",         65536},		{"kmalloc-128k",       131072},
> > > +	{"kmalloc-256k",       262144},		{"kmalloc-512k",       524288},
> > > +	{"kmalloc-1M",        1048576},		{"kmalloc-2M",        2097152},
> > > +	{"kmalloc-4M",        4194304},		{"kmalloc-8M",        8388608},
> > > +	{"kmalloc-16M",      16777216},		{"kmalloc-32M",      33554432},
> > > +	{"kmalloc-64M",      67108864}
> > 
> > I'd rather use KB and MB suffixes or at least capital 'K'.
> 
> I like k and M better.

k and M work for me too.  It we were going to be anal then we should
go with the IEC standard of KiB and MiB, but we're trying to make
/proc/slabinfo a little less ugly, and so we have 16 characters to work
with.  "dma-kmalloc-256KiB" is 18 characters.  The obvious place to lose
two characters is the "iB" which are implicit; we know we're measuring
bytes and the binary nature is assumed in this context of memory bytes
(not storage bytes).  "dma-kmalloc-256k" is better.