Received: by 2002:ac0:a5a6:0:0:0:0:0 with SMTP id m35-v6csp1279178imm; Sat, 8 Sep 2018 21:40:55 -0700 (PDT) X-Google-Smtp-Source: ANB0Vdby3dIsek/Z6FwvkKt1ZoGGKRMRl83ki1CA9q6/cCAZfwBAT9N7IVzPYfCe0P9slYZFUa8q X-Received: by 2002:a63:225f:: with SMTP id t31-v6mr15982583pgm.275.1536468055069; Sat, 08 Sep 2018 21:40:55 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1536468055; cv=none; d=google.com; s=arc-20160816; b=edyK708LeAFa/K1F3lvj6D7RQiki3z6a0GHVaRn/+Ln8bnE22HqTZ0D848sRLG21sx pPjXuzXDpjB053dBuaZzDz+g2bZ5amQjjJLW5+FtlELg6iyM9eCsUWZtkzmRJWcRJX0d KC7NL3a3ftRQ+VUf6hG8iLBrny9fxMjfywVE/yldvkmoaJTUJT4lm3TrX6nQA/kN6dz8 HIRoraNR/jmngEthBQlQ1eSgBOGq5m/cxIT5eOUotfEnc4eyMoQsUNjDj3dUDsgmBUxv Ef3wixNzYucOfKwVE88FHIgiIbbPFGSmimEx4I+wQeir4TZ6+CDdyotbzrRYvE+1FdyB UA4A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date; bh=y0areSqNar1XKrutD0FENxtVVKInIdVxEMqvi/eJ6kE=; b=sEobmzLGEJQ6rtWBSiXw3avbFUqnx6vWa9v2IjfaYrYxhSrEe5ZXEbqHuX3xgVzlNd RB3CSHsfm24kBaztcLOscMJuEnKp/odW/fyX0G/6Qclup8M/3cFgXH6/ObQQ/A7cCing pwqaRpRg/FfMTcmUd1JXadZRv70BwRn8ynsgPQ7p4GbrSKZh+pnnRovhorSULhNhh3Np 0SydiYKGMrOCXY1OH24tUIpEiuW2qhT4DDSqH3svfJnnmGpaNlNxwMWWgJ8C2PtMAtUb xL3NK6+a22O0AW2o6qEdygbfrMNH+UMhjolA9dTp3aDD+a+TC2AmJy+C4rlfGykWMJXJ yDAg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id r25-v6si13974060pga.489.2018.09.08.21.40.37; Sat, 08 Sep 2018 21:40:55 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726657AbeIIJ1f (ORCPT + 99 others); Sun, 9 Sep 2018 05:27:35 -0400 Received: from zeniv.linux.org.uk ([195.92.253.2]:43322 "EHLO ZenIV.linux.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726152AbeIIJ1f (ORCPT ); Sun, 9 Sep 2018 05:27:35 -0400 Received: from viro by ZenIV.linux.org.uk with local (Exim 4.87 #1 (Red Hat Linux)) id 1fyrTy-0004yf-6F; Sun, 09 Sep 2018 04:38:06 +0000 Date: Sun, 9 Sep 2018 05:37:58 +0100 From: Al Viro To: Arnd Bergmann Cc: "David S. Miller" , Martin Schwidefsky , Heiko Carstens , Willem Riede , "James E.J. Bottomley" , "Martin K. Petersen" , Kai =?iso-8859-1?Q?M=E4kisara?= , linux-kernel@vger.kernel.org, linux-ide@vger.kernel.org, linux-s390@vger.kernel.org, osst-users@lists.sourceforge.net, linux-scsi@vger.kernel.org, linux-fsdevel@vger.kernel.org Subject: Re: [PATCH 11/11] compat_ioctl: move tape handling into drivers Message-ID: <20180909043746.GF19965@ZenIV.linux.org.uk> References: <20180908142837.2819693-1-arnd@arndb.de> <20180908142837.2819693-11-arnd@arndb.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20180908142837.2819693-11-arnd@arndb.de> User-Agent: Mutt/1.9.1 (2017-09-22) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, Sep 08, 2018 at 04:28:17PM +0200, Arnd Bergmann wrote: > MTIOCPOS and MTIOCGET are incompatible between 32-bit and 64-bit user > space, and traditionally have been translated in fs/compat_ioctl.c. > > To get rid of that translation handler, move a corresponding > implementation into each of the four drivers implementing those commands. > > The interesting part of that is now in a new linux/mtio.h header that > wraps the existing uapi/linux/mtio.h header and provides an abstraction > to let drivers handle both cases easily. Ugh... Frankly, this bool compat passed all way down looks wrong. I can live with that; the question is whether block folks will be OK with that thing...