Received: by 2002:ac0:a5a6:0:0:0:0:0 with SMTP id m35-v6csp1941792imm; Sun, 9 Sep 2018 12:08:44 -0700 (PDT) X-Google-Smtp-Source: ANB0VdY34zWTIwZpxkRiIV/2Hpv3RLEpkx6m6vbrOpRYDMYmxoiGC7DoEcXPEqi1YH/CduOvSlg0 X-Received: by 2002:a63:225f:: with SMTP id t31-v6mr18847091pgm.275.1536520124619; Sun, 09 Sep 2018 12:08:44 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1536520124; cv=none; d=google.com; s=arc-20160816; b=FQ9bvhp/vqWE4E9SpllCCb+Ltzz5xbkRDqwN81mGQ/JXbl4hakPqln1XmACRyVp5ip B8Ro5Zqv/0Cbv/D1IaC3u4RRVHj+1UOHDEEqTjoPacDFZ5g3sM1Z1Ggx7JOFjDhOB3Qq QXhoBblnaVjw5Mn6w6ap0q5OJ2EZI3ARqpOAs5WFhI/xaSb1v0dbaHGJthfLSjh+SlR1 aYgalR1lPSHZCHUIlbcGzhT4/DBaDGNemIC9Xm8KkAj94PtOaq2DEHepb7D35hm8RlNC xzhui3I0QAqLw2Ubx1AXyrSOcagbe8CEr/Je3a296MNqio7dHkGeqryPcju84RhETNSH N12Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=KjrSwzQkP+9g54Mvyhd9RDVsRI9YxrzNh6JQadi5Mdg=; b=UiMbJsh0ziyptxSzgmVQ/gEpl+LK8FFQh44adXgbctlM0BMISJg89us+bruvp0mSVQ b9gHh+bgM1pJVub/Us2kL2H6j1jVQ6Id0WHY+RKnzW6BMzfHVrcHZgNfDp9R/Scq7vUz iofl/zmw/EEcy3NJqvUx6u+HQCfRmuP+3A27g0norcrEASyO15b+poO4KS2+Oj86lvGM kF+iWNYMNI7aMw8owTl/BjpT6Z0+L5vYQjyG2pjZ6a2BZ2alXAemLTQsAWwFpRnq+gv7 ruid7WjFovDGD3+7Yiut19/PEFZX2whl9cgVUhD8hUeq5u1U9F8TOQEK1LL9sN90ck0T 6VPA== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@infradead.org header.s=bombadil.20170209 header.b=XjvWeCp8; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id h126-v6si15664970pfe.72.2018.09.09.12.08.28; Sun, 09 Sep 2018 12:08:44 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=fail header.i=@infradead.org header.s=bombadil.20170209 header.b=XjvWeCp8; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727642AbeIIX54 (ORCPT + 99 others); Sun, 9 Sep 2018 19:57:56 -0400 Received: from bombadil.infradead.org ([198.137.202.133]:46112 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726710AbeIIX5z (ORCPT ); Sun, 9 Sep 2018 19:57:55 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20170209; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=KjrSwzQkP+9g54Mvyhd9RDVsRI9YxrzNh6JQadi5Mdg=; b=XjvWeCp8xyxu5aVrdh98Op4pd o/YyEYPLNcTwomDweGta5D3icVkDBNPWyC8Ss/rzm0BhV7ucwHrb2PYuwvJbXzd7rFAxTvS0F9YPI HjsGe0N7NCdHOSy8IqB22FX2VN7xBQuoTQa0Ga7bfX9c9owWzVeLN/pvZOsnMP4MwMnazZNQr8Z2Y 4BKswxE9CRXK5nTNFH29UwuwFDyfqjUtkVXOEDPAeNHoo7FIzEs+L12Ow2osTU9kMGYbsSd/OljnI H8DFXqVpr75CFDQFtfmrN0yNcLO66Yqw4WmajRw2fcax6iciveIuJs4NEZ0yBnzCM/qNTg4M4ppHf 8q7guUh+Q==; Received: from willy by bombadil.infradead.org with local (Exim 4.90_1 #2 (Red Hat Linux)) id 1fz53C-0004rX-D5; Sun, 09 Sep 2018 19:07:14 +0000 Date: Sun, 9 Sep 2018 12:07:14 -0700 From: Matthew Wilcox To: Wang Long Cc: akpm@linux-foundation.org, zwisler@kernel.org, linux-kernel@vger.kernel.org, jack@suse.cz, heguanjun@meituan.com Subject: Re: [PATCH] radix-tree: optimization for radix_tree_init_maxnodes Message-ID: <20180909190714.GA20237@bombadil.infradead.org> References: <1536499260-126634-1-git-send-email-wanglong19@meituan.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1536499260-126634-1-git-send-email-wanglong19@meituan.com> User-Agent: Mutt/1.9.2 (2017-12-15) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, Sep 09, 2018 at 09:21:00PM +0800, Wang Long wrote: > if i == 0, height_to_maxnodes[i] = 0, > if i >= 1, height_to_maxnodes[i] = height_to_maxnodes[i-1] > + __maxindex(i-1) + 1. > > so delete height_to_maxindex and optimize the calculation of > height_to_maxnodes array. Thanks for your patch. Unfortunately, this entire function is scheduled for deletion, so I won't be applying it. If you're interested in the radix tree, I'd recommend looking at its replacement, the XArray. The current version is at http://git.infradead.org/users/willy/linux-dax.git/shortlog/refs/heads/xarray but I'll be pushing another version out in the next few days.