Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Mon, 10 Sep 2018 09:04:36 +0200 (CEST)
From:   Thomas Gleixner <tglx@linutronix.de>
To:     "Yang, Bin" <bin.yang@intel.com>
cc:     "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "Gross, Mark" <mark.gross@intel.com>,
        "peterz@infradead.org" <peterz@infradead.org>,
        "x86@kernel.org" <x86@kernel.org>,
        "Hansen, Dave" <dave.hansen@intel.com>
Subject: Re: [patch 01/10] x86/mm/cpa: Split, rename and clean up
 try_preserve_large_page()
In-Reply-To: <10a05617853975fce8560ec688b6aa1bb58868ae.camel@intel.com>
Message-ID: <alpine.DEB.2.21.1809100902520.1402@nanos.tec.linutronix.de>
References: <20180907150119.325866892@linutronix.de>  <20180907152054.463798054@linutronix.de> <10a05617853975fce8560ec688b6aa1bb58868ae.camel@intel.com>
User-Agent: Alpine 2.21 (DEB 202 2017-01-01)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Mon, 10 Sep 2018, Yang, Bin wrote:

Can you please trim your replies? It's a pain in the neck to find the
single line of information within a large pile of useless quoted text.

> On Fri, 2018-09-07 at 17:01 +0200, Thomas Gleixner wrote:
> >  	/*
> > -	 * We need to check the full range, whether
> > -	 * static_protection() requires a different pgprot for one of
> > -	 * the pages in the range we try to preserve:
> > +	 * Make sure that the requested pgprot does not violate the static
> > +	 * protections. Check the full large page whether one of the pages
> > +	 * in it results in a different pgprot than the first one of the
> > +	 * requested range. If yes, then the page needs to be split.
> >  	 */
> > -	addr = address & pmask;
> > +	new_prot = static_protections(req_prot, address, pfn, 1);
> 
> "npg" is introduced by patch #3. It might be better to keep old API in
> this patch.

Yes. That's bogus. Will fix.

Thanks,

	tglx