Received: by 2002:ac0:a5a6:0:0:0:0:0 with SMTP id m35-v6csp2418252imm; Mon, 10 Sep 2018 00:21:54 -0700 (PDT) X-Google-Smtp-Source: ANB0VdZrO9rT7TjqQXmmd+UlPRx6sV4BwHLWOTIvZkyxozpRXE/8doMJgaqo4M6K7eb7eQTez37k X-Received: by 2002:a17:902:b784:: with SMTP id e4-v6mr20519991pls.204.1536564114287; Mon, 10 Sep 2018 00:21:54 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1536564114; cv=none; d=google.com; s=arc-20160816; b=zcG1EIP/ZV5K3pHO1nMpfSaL5/oR6ZbArJWIO0JNtZ6rwy9uEdfEiy9+mlywYhxXLA pSrKw1L0xb06AwHZNpl7kXFBcmGqxxu6yOlV9yhWcfgQIklFNi1gYxHdSyXOe+D9cEoT 1QD2X5I0+jmI12AhKgfBqd7jj935RnDt0PPyUsWY3l6lr1lnzYG1mt/mB0uR2YbRrHVt qhNNSIMWNvwkpsWXUAORtU3WczrfFL8BQLF6m8dQDGmAcEtKFWa9bZdJGDRkGhA//uIB f/SaTzxmaILV9Q8PHH3NB4URjDP7KtL1v6IhpTVYzrmAcTWot4X6noPBrCrHJ2e6hIIf KGRA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=5Z+nKMPUIK/KD9vHXHbUqJpRwAQq8ArTb+pdGdFdls0=; b=Mhz0C5wsi7IGqG3Nx4oyw8sRZcAcLqmJgaArQSkfFhtDzvAf2hJ5EDef9X0nNjh6Bd 734R945p7nVQCrh1Ubqv4r0JIUP2BNRD0cLrjlGBjlsT2FHyH/vWVB9V8uy9fcdU8eRD BNQi0YrT10vBB9JmtmXNgd8n3oMNpAq50CUPg7LsPB9/v0r6sfMHM/9RUv+5s797LHeV yMxD/c/yQhRwsiiaoQMQE7AtL4pJd2nbt5qGV133umJ68szGFtAL6bmB8NPiz7vwYF0J yXgw8ulbXic6eYGJ9I/lgIaj6zXNrzWhP9pSoB8uhpnHDMNdSSeBpwbGcDSGXl62jHh0 DfqQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@gmail.com header.s=20161025 header.b=p157OlrE; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id cd4-v6si17015186plb.516.2018.09.10.00.21.39; Mon, 10 Sep 2018 00:21:54 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=fail header.i=@gmail.com header.s=20161025 header.b=p157OlrE; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727825AbeIJMNJ (ORCPT + 99 others); Mon, 10 Sep 2018 08:13:09 -0400 Received: from mail-wm0-f67.google.com ([74.125.82.67]:53739 "EHLO mail-wm0-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727311AbeIJMNJ (ORCPT ); Mon, 10 Sep 2018 08:13:09 -0400 Received: by mail-wm0-f67.google.com with SMTP id b19-v6so20380311wme.3; Mon, 10 Sep 2018 00:20:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=5Z+nKMPUIK/KD9vHXHbUqJpRwAQq8ArTb+pdGdFdls0=; b=p157OlrEOFZy4G1l9pL3GiUAS3pxmhPATWoD8qwLur7SIQ8YzrH+RxWCl78fnQqE3B qZfDFsHiEUyVRhgp69z7l5lJ3OXqFnF4SysKv1bcV/uGQxDJp6n8IlmuvJjl0qzx5GGc W6OKsxPKzQPq0cP7mKQ67j5WMmsBA+F2pTLLVtYJS5Z03oABr52dbWSEWF4fFjruCTd6 0WxrwdPolK/YtGF7cdGKLRnfFuSp9sYmpiNh+m2OPb9854mCWllz7JLqotYYPvAjtB9d qU9j9cgZuIuuyDEb+nSH53hC0WoygB/NbGjDRF8ilG3yctmGpMorT1HUkwuFJu7lIbhI nhIA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:date:from:to:cc:subject:message-id :references:mime-version:content-disposition:in-reply-to:user-agent; bh=5Z+nKMPUIK/KD9vHXHbUqJpRwAQq8ArTb+pdGdFdls0=; b=TKwIp5Q0t60WN4kWOg7NvKLKZPY5XK6cpmnnVTOB69fQ5MvcimuS9pnqJqaUMJjKUf yyQGQ/uSYs/8FJub7/g8WjcYhHXFbQEY+Ob6g+p8T9MWNtvPeWGjXoMyfYbvoqVf3LlH u6xIu/BiQN4Z9XmNZFI2sYAFgtSsZs0Cr9LNR29jmT+mBo7MmpiuPOBkMJCbKlla/rnX d+mGYjS2zMdxot0WYA5Wc3py7gtNTNEAoBAc5EtaVWbeYkRduXOyRoc9k6ewueZnJTs1 zxMfB3QabQaXGtw9MX5hy95vkLBjaQ9hHRr41Pe7S2/TqsugzT+OhM1cTnmc1lquMxcG XPJw== X-Gm-Message-State: APzg51C3PixOzkif+LmEceLKUXJHGSE1ONL0zgsrwQqWXi7KIK+p+qVW RVzvx+Ns6432p13f7yPowrg= X-Received: by 2002:a1c:1bca:: with SMTP id b193-v6mr12089740wmb.6.1536564031082; Mon, 10 Sep 2018 00:20:31 -0700 (PDT) Received: from gmail.com (2E8B0CD5.catv.pool.telekom.hu. [46.139.12.213]) by smtp.gmail.com with ESMTPSA id z10-v6sm15740378wrv.22.2018.09.10.00.20.30 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 10 Sep 2018 00:20:30 -0700 (PDT) Date: Mon, 10 Sep 2018 09:20:28 +0200 From: Ingo Molnar To: Aaron Ma Cc: ard.biesheuvel@linaro.org, tglx@linutronix.de, x86@kernel.org, linux-efi@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] x86/efi: earlyprintk - Add 64bit efi fb address support Message-ID: <20180910072028.GA47768@gmail.com> References: <1536423828-5693-1-git-send-email-aaron.ma@canonical.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1536423828-5693-1-git-send-email-aaron.ma@canonical.com> User-Agent: Mutt/1.9.4 (2018-02-28) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org * Aaron Ma wrote: > if (efi_fb) > return (efi_fb + start); Just noticed this detail unrelated to your patch: return is not a function. Thanks, Ingo