Received: by 2002:ac0:a5a6:0:0:0:0:0 with SMTP id m35-v6csp2428246imm; Mon, 10 Sep 2018 00:35:24 -0700 (PDT) X-Google-Smtp-Source: ANB0Vdbjqclc08lF/B1RR/U+fz2Ro1+t7VkmKW0qzRYYvbN8tJy/EknZp8dw2HnSehWjob6dSuPR X-Received: by 2002:aa7:82c3:: with SMTP id f3-v6mr22617266pfn.136.1536564924314; Mon, 10 Sep 2018 00:35:24 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1536564924; cv=none; d=google.com; s=arc-20160816; b=IB4+cE5RZvD0MRImT1L2uVSiuR4aJezvJ8sS8BsaOl1MsN0S0/x/CD1DZpNrMX//43 /BdClH7EMimrblWc+NPonaw7y2bP2gm+2nRQWTtVFfkXyA2yX1M204XGvZyl0M9xlHWo bcNeg71BVzzhFWiQiOA5AdmC/VMyniAc78kAczSadNOe6CISMgVCTOH0Q9T8ENvzb/Op hINNgR3PKsSJ/7QnbEOiFppCgzMjTgMSWJVanFvuFhwidswk2qnfJ4g4xD2LVVTnXDOI Ok1zKxkXu6VNYxdgM0AssSmMLwkpNLc1Yw0hHyRyoY/Cs7pBCjlIQEM0nD0lzOJRId6O AROg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:from:references:cc:to:subject:dkim-signature; bh=LUUUoirvmHIU5XdGXsy7cHFNXt6qB4Azz4LVtzSeqKE=; b=Qh5HchrgeqTt8n3vXGWWTg1ET43bps1vStOvLtgVKLcmMtXcIEh+Wf6CaHuxVX1exC eXRgZWiVDln7panj8ItrklsGTAQbEldW13VXHJRX9dwFbdDCUrTkHOcLdE4+ykxP2Vag lYDsw1Pg9UHTNAOvfVXoNg9b6XO0g5XmVsJHABb3DcyLwOk4eDbPzIJLPSPJr6rc+x4K e/o9r2sdmsqdGTIIoxfdS6x9eVmyugA7CJulqMhd3VTx3RF6ZfrWIxOatBvWGNknrzqF 0/Lo55jeclxtzX3nJE4Y1D48v+VLW3+i7gB1TPfZQp5Vh+LpQzpFKc9WEuy9DOqroXrJ Ej0A== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=BxdF0cMN; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id 21-v6si16319168pfy.169.2018.09.10.00.35.08; Mon, 10 Sep 2018 00:35:24 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=BxdF0cMN; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727985AbeIJM0J (ORCPT + 99 others); Mon, 10 Sep 2018 08:26:09 -0400 Received: from mail-wr1-f68.google.com ([209.85.221.68]:34122 "EHLO mail-wr1-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727754AbeIJM0J (ORCPT ); Mon, 10 Sep 2018 08:26:09 -0400 Received: by mail-wr1-f68.google.com with SMTP id g33-v6so20766674wrd.1 for ; Mon, 10 Sep 2018 00:33:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=LUUUoirvmHIU5XdGXsy7cHFNXt6qB4Azz4LVtzSeqKE=; b=BxdF0cMN/Q4CZ3qMQvGbpkm7fdgFs75rY/tCWV6fkqHxYYmm9Z+RMSS4uD1zBOkLYt VHsX5MuykQjkrv3uHyvXyvMgAL/21mD+M+LPvlDFsY/+E1tciuYB22Rajtw2lq2bhKEC ke5wOhd17H2fKxMLbKXwR0dAzK9whCNRPln84= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=LUUUoirvmHIU5XdGXsy7cHFNXt6qB4Azz4LVtzSeqKE=; b=BP9QLqXBCzca40ZhDpejKKC2bCBSJm3p9wIFg0VMizJTxsCMu0lLrdjl4PNjOKDX14 SxBOZeo3igRNzdTBTXKhdu7BOh3pmuDRMnvUEvZ6CejYhgokFaeWi/icgct3eoEBqiX9 ywHDWTq4LMG7Ed3B6kGFSK1Eh1qxcPyhVLs0VYOgj99Tk1TXvh1elntKl6m/89XN//7O Kogf7YuQ5ynstc7aWWznIM693/MX0kHqjFYeHZHSL/DePDHADlXXSGEaDW/PMExCvzFZ CcdiUGCw8EdyizEf+3AeOteFvJGPbGjKW5ozf3869B6FQfA1gv3tNb8IUFLUX5AMuNGV jj1Q== X-Gm-Message-State: APzg51BlLQJB+KXv+TX2mTk5YhmJEzKnJjK0vZbjLtTjOECtrG6dtJHP f4P2ZEqRsXkPAyw+W1SVUjSloQ== X-Received: by 2002:a5d:428a:: with SMTP id k10-v6mr14748248wrq.225.1536564808107; Mon, 10 Sep 2018 00:33:28 -0700 (PDT) Received: from [192.168.0.18] (cpc90716-aztw32-2-0-cust92.18-1.cable.virginm.net. [86.26.100.93]) by smtp.googlemail.com with ESMTPSA id s13-v6sm19132068wrq.39.2018.09.10.00.33.26 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 10 Sep 2018 00:33:27 -0700 (PDT) Subject: Re: [PATCH v2 07/16] nvmem: change the signature of nvmem_unregister() To: Bartosz Golaszewski , "David S . Miller" , Mauro Carvalho Chehab , Greg Kroah-Hartman , Andrew Morton , Arnd Bergmann , Jonathan Corbet , Sekhar Nori , Kevin Hilman , David Lechner , Boris Brezillon , Andrew Lunn , Alban Bedel , Maxime Ripard , Chen-Yu Tsai Cc: linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Bartosz Golaszewski References: <20180907100750.14564-1-brgl@bgdev.pl> <20180907100750.14564-8-brgl@bgdev.pl> From: Srinivas Kandagatla Message-ID: <545e0e3a-7728-7179-2bc3-fbb813e3c39d@linaro.org> Date: Mon, 10 Sep 2018 08:33:26 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1 MIME-Version: 1.0 In-Reply-To: <20180907100750.14564-8-brgl@bgdev.pl> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 07/09/18 11:07, Bartosz Golaszewski wrote: > From: Bartosz Golaszewski > > This function can no longer fail and there are no more users that check > it return value. Change it to return void. This should be either part of Kref patch or it should state that refcount handling is impoved in Kref patch so there is no need of returning error code from unregister. > > Signed-off-by: Bartosz Golaszewski > --- > drivers/nvmem/core.c | 8 ++------ > include/linux/nvmem-provider.h | 9 +++------ > 2 files changed, 5 insertions(+), 12 deletions(-)