Received: by 2002:ac0:a5a6:0:0:0:0:0 with SMTP id m35-v6csp2511607imm; Mon, 10 Sep 2018 02:14:01 -0700 (PDT) X-Google-Smtp-Source: ANB0VdZRlyfPUNay8h9NUcy6ag3uUGcsd0Od2V5X5OLP8DScMBZQr+yz+8X/rOn8d959BciqlZma X-Received: by 2002:a63:f966:: with SMTP id q38-v6mr20954008pgk.213.1536570841476; Mon, 10 Sep 2018 02:14:01 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1536570841; cv=none; d=google.com; s=arc-20160816; b=WioUfuJNkwuuSkT8TAjFyZcw8goDTy7ZupFyGxHFuF9JT1RSyaF77HgLd4t95aiNxa kLJs7k5XFnVglWfX/G0psUIsi6A4ONUBIAWuSvgV9nUo2lrzGkj+pFeRYciKWX0j/Sr0 UU9BUeM9HgEPGwtfTF0j2f5rUVp3rxZMbnyXtFfg+mPKjNbNPAq9CiABJrXyiaY6WDr0 edWKYrUjHMUfRLhKZk1dfa7SsDKMcrHHrdydocMzyOu9Il/3ZgyMX2W/MR+wwUtctHxL 7uN+vcSQGezJvFtZml5lhgP2OT/Tv37kx83K+xGEN9Sk+6v/exwPUgdHWdvHAqtSYQzY 5H5g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-transfer-encoding:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=p7DX7vguRQm0CFMAfSRvZjCNkNU+/ez59LEQfbFt1VE=; b=b8ntXkIU+owzZHxV3toqd9c1IyWPaixgT3WFNhXHg1HAPRy0kSNaBfDCfwZI0GLk3F thb3PNFtNtJKY/EcHbOdkeIfQDoexJtwrvR4qUclPNrEiwW418ZjjtcjxfZZOQ2qO/kG M60p0CLqzfErDwHZu11kme7zySoZRUblDBiEnlGmgpQaWM1Ojx61DTYpyMv6TqR48WLm wETUp+YGEIIMjyrDHdd4wwfrwTdbn8UPjDpxINSTXqaj2m3GrRxerxrV+Js2ydrlHFu2 jQQtJn2WxcImtCEqwJpcO1q0WtpgqP0HsmSCm0ywiD/X23hycGwRC2xq+31cwfER9wgn yfeg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=bqjbBnrd; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id u8-v6si15604295plz.481.2018.09.10.02.13.45; Mon, 10 Sep 2018 02:14:01 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=bqjbBnrd; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727952AbeIJOFO (ORCPT + 99 others); Mon, 10 Sep 2018 10:05:14 -0400 Received: from mail-wm0-f66.google.com ([74.125.82.66]:55892 "EHLO mail-wm0-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727657AbeIJOFO (ORCPT ); Mon, 10 Sep 2018 10:05:14 -0400 Received: by mail-wm0-f66.google.com with SMTP id f21-v6so20713512wmc.5 for ; Mon, 10 Sep 2018 02:12:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to :user-agent; bh=p7DX7vguRQm0CFMAfSRvZjCNkNU+/ez59LEQfbFt1VE=; b=bqjbBnrdY6Hwn2Ac+rM3dIBaQ5dCBtV50b10NYcZK3V/kUBUg1xOhRkwU17dQLNEOW Gz19YGrtGlMTyYpBgkTBDwJGmmrcV5Qj9GnCtfWAKOWeKRguTp5BvnHtMow92hyajdOK At952xa30d3Y0LTsRUQU2Wia99vcTeEO6B7sI= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to:user-agent; bh=p7DX7vguRQm0CFMAfSRvZjCNkNU+/ez59LEQfbFt1VE=; b=PtHqUUPGgMQX16Un+iJVOA9euRWbUMGZhd5ZCSoJEx7HBK5zdk90a0cEm9wkF/6xSq A5S2FzSp5cyEoBae6ONoqPykxk1bvn/FOmotIbuBi8/1CPTwz9QKtVUHIJ/pA5/gw1+y 8/LTNq9cZ1GZDsL9T2qX9Dk3zgEYurWTkubadx3Rw5j5D9cHHcFFxv1Wywcj+xpHo4Ap 2vqYYrt3XT/4HV/Wu8avuA4QV0eDpofkaKHW6kdBVV99wIvdSSYbeNQql6WMoOiYYU9F oFuiUELSf+mRYz7ZX7Pxl+mLPDCRlZZxWKk0coFDbCJoYM847sTvHx2qHS1DVc35B2At 1hXQ== X-Gm-Message-State: APzg51AC3CsJMne76gzPjnPZ2OsacQtgC3iRbleQ1Pa+dQ2G/OtpRVUn Z27lfcK9BIPEhgjWXD3zYJQ1Ug== X-Received: by 2002:a1c:a94d:: with SMTP id s74-v6mr18863wme.39.1536570729335; Mon, 10 Sep 2018 02:12:09 -0700 (PDT) Received: from dell ([2.27.167.7]) by smtp.gmail.com with ESMTPSA id r140-v6sm24893029wmd.7.2018.09.10.02.12.08 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 10 Sep 2018 02:12:08 -0700 (PDT) Date: Mon, 10 Sep 2018 10:12:08 +0100 From: Lee Jones To: Benson Leung Cc: Enric Balletbo i Serra , linux-kernel@vger.kernel.org, groeck@chromium.org, bleung@chromium.org, kernel@collabora.com Subject: Re: [PATCH 2/2] mfd: cros_ec: Fix and improve kerneldoc comments. Message-ID: <20180910091208.GH28860@dell> References: <20180718160956.19864-1-enric.balletbo@collabora.com> <20180718160956.19864-3-enric.balletbo@collabora.com> <20180907075438.GB95655@rodete-laptop-imager.corp.google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20180907075438.GB95655@rodete-laptop-imager.corp.google.com> User-Agent: Mutt/1.9.4 (2018-02-28) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 07 Sep 2018, Benson Leung wrote: > Hi Enric, > > On Wed, Jul 18, 2018 at 06:09:56PM +0200, Enric Balletbo i Serra wrote: > > cros-ec includes inside the MFD subsystem, specially the file > > cros_ec_commands.h, has been modified several times and it has grown a > > lot, unfortunately, we didn't have care too much about the documentation. > > This patch tries to improve the documentation and also fixes all the > > issues reported by kerneldoc script. > > > > Signed-off-by: Enric Balletbo i Serra > > Applied, thanks. If applying patches from other subsystems, you need to wait for an appropriate Ack before applying. Please send me a succinct pull-request for this patch, so that we might avoid potential conflict at merge time. -- Lee Jones [李琼斯] Linaro Services Technical Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog