Received: by 2002:ac0:a5a6:0:0:0:0:0 with SMTP id m35-v6csp2511712imm; Mon, 10 Sep 2018 02:14:09 -0700 (PDT) X-Google-Smtp-Source: ANB0VdYDodqMWvGIkIZWsf94E3LBk3SURVmbU5IXj+VDeMNN5AtCB/+77i1EOUdNcI8y9Y+eP68j X-Received: by 2002:a63:28c7:: with SMTP id o190-v6mr21466732pgo.84.1536570849133; Mon, 10 Sep 2018 02:14:09 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1536570849; cv=none; d=google.com; s=arc-20160816; b=eDvQFOTdjpsASZZD/DwyCPcgWUJ0HkEnFt3RsCzJiEO5huRKTURVNc/wmGV1TTrJ6c Yf405kEafDqyufIQC28LMNfYvWTIilX35Npb5S3rwdAf4FP/9htDRDq+vXe8R6wkW/+A SX0q9MQ6yAFnGKk28DnFBUI9v6d+flUrQeNlxATsMuLPACItipt/tol84cNJoakvOZZb ISFw/VrWGEtbKEkbzzSLZ/FMBb21/LkxpeStvTGrAdE/yCoeeOEYUKLRZf0hUviCr8XT 5EAVmSozOhdEGmMZsgO2tSEep3rl7CyomhajNnmQgkNfcMxkGp8NGKMAmLR1GI+DIu5C i/hA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date; bh=aE9Q5AKe/KKSnT+kGJrsxwzhoFJKnRHOAos3tT9oJfc=; b=HJ0/N8JRbGSEwfnYXvmXcfI29T6R6wyBoLbdPYCJ8Lc4FI+ZyQIrV8dqwaHHSVCE4a fwcWs2xfw3uOPW3gs7I1zxedQYCVL49sLi8DcXAxFcnMuy2g1G2SDabZub/mXVigkLrU qz+t83DSpBtIux/lvH1joPFNVyO841IzqwGTGTwDmKV4Jnq3SdbEfFGMpKvO34j0DpYL 5Zb7pqZLF4n/YMnpe2TuA15o/B4CrlVnEumkmL5XemGcph1JnYWXD2Impci2K4GFbf9b 7+JYdOwf2QqsDt/ccziQmzTxl3Dlp9lqq+gDae8NYh/sZjeFkl20QzoYG+jLLn/lImSS EauQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id x12-v6si16220141pgg.118.2018.09.10.02.13.54; Mon, 10 Sep 2018 02:14:09 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727867AbeIJOFm (ORCPT + 99 others); Mon, 10 Sep 2018 10:05:42 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:57084 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727059AbeIJOFm (ORCPT ); Mon, 10 Sep 2018 10:05:42 -0400 Received: from localhost (ip-213-127-74-90.ip.prioritytelecom.net [213.127.74.90]) by mail.linuxfoundation.org (Postfix) with ESMTPSA id B0EA0BC6; Mon, 10 Sep 2018 09:12:38 +0000 (UTC) Date: Mon, 10 Sep 2018 11:12:36 +0200 From: Greg Kroah-Hartman To: Takashi Iwai Cc: Stefan Wahren , Eric Anholt , linux-rpi-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 00/29] staging: bcm2835-audio: Cleanups and fixes Message-ID: <20180910091236.GB21533@kroah.com> References: <20180904155858.8001-1-tiwai@suse.de> <2050605805.39126.1536412690563@email.1und1.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, Sep 08, 2018 at 06:21:55PM +0200, Takashi Iwai wrote: > On Sat, 08 Sep 2018 15:18:10 +0200, > Stefan Wahren wrote: > > > > Hi Takashi, > > > > > Takashi Iwai hat am 4. September 2018 um 17:58 geschrieben: > > > > > > > > > Hi, > > > > > > since I had an opportunity to play with RPi3B+ recently, I took a look > > > at the existing bcm2835-audio driver code and was amused very much :) > > > > > > So here is the result, a cleanup and fix patch series. > > > > > > Most of the patches are trivial cleanups, just brushing up, removing > > > many redundant and buggy codes, as well as code simplifications. > > > > > > A big functional change is that now it uses non-atomic PCM ops, so > > > that we can kill the ugly workqueue usages. Also, the resource > > > management was simplified. > > > > first of all, thank you very much for this series. > > > > Eric has no time as maintainer, so i will try to give you some feedback (beware of very little audio driver knowledge). > > > > I functionally tested your patch series on a Raspberry Pi 1 B (bcm2835_defconfig), so this whole series is at least: > > > > Tested-by: Stefan Wahren > > OK, thanks, I'll put to my series in case of resubmission. > Meanwhile I'll keep the series in topic/vc04 branch of sound.git > tree. I'll just take this through my tree now, so there aren't merge issues if there happens to be other cleanups to the driver that show up in the near future. thanks, greg k-h