Received: by 2002:ac0:a5a6:0:0:0:0:0 with SMTP id m35-v6csp2513051imm; Mon, 10 Sep 2018 02:15:36 -0700 (PDT) X-Google-Smtp-Source: ANB0VdbTIZ7hewQUPpPtRt1PRg48u0CgaB3n/8dg4Iv4Fidl8EAE3CqJRjl8xUwo4KvZRI3QO9ii X-Received: by 2002:a17:902:e20b:: with SMTP id ce11-v6mr21101599plb.136.1536570936182; Mon, 10 Sep 2018 02:15:36 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1536570936; cv=none; d=google.com; s=arc-20160816; b=nJ+RoD2oNT2e0gCPPP5xhu1W2DOfeIaKIXPl6u5Lk0S5qJW5sHjnxIjgmrj5if0BWJ KY36ELYcO89CNjyfVsSXm2VeZ/VkEToq51V9BnFEFVPpDYJI8tJgxIUjy8uLt/OOCx8Z uw3jmBOaR7bAXC+xpwQUXj3Kv7wiTmOkXxhpvZkgw18oB0gYdwkyjSJPEQC7cF+7BMSk tsdCNkEof2pI4pQqXHZpKsuJPDqQPJGco4JKCSKSmSns4EG4oVcONRQ/8FFk95eg6sjW UQ9W3mLOGgt5MiL6YHmCvw0yTTuLankRjDKyO1QKxGF/yg4odIMzoxijAETk5rDhjExf wvYw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:dkim-signature; bh=bKwLsGkvnyzYF+jIdXeK91qBWk7wtIOS4afg/iF9Fb0=; b=MKXTzmsAmdJ8JNFDZ98nVHXCxCwEtWgtcg1psUQiQqGYt1dPY+a1BCchHUN05CBDJE egGMpM/PZmZyDdYYl+lVspVuCNPgliKdXxShv5ysMRp3SHVr2xSAN3cdjN94WxV1DPjk ZM4um/CgWXEJ7ONIJjNEdP9s1BSglUgxMoNuU1g3e9qufX8jht790BDBqe/pqMhwSM/H c2SWWX65JqhH6E1fXK4k83kq5jPhGjJ2yc1kVg12g31RCVg9VonDtQDxEMikOvLKItd8 IRysvRr22EQi8M2/zXvUPKSIi81+2Kq/b0VWiyIYaf26PNbEoba0QCa7S2ya9xkUO5iq WTjQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@google.com header.s=20161025 header.b=LpSOnnZR; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=google.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id u8-v6si15604295plz.481.2018.09.10.02.15.20; Mon, 10 Sep 2018 02:15:36 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@google.com header.s=20161025 header.b=LpSOnnZR; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=google.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727946AbeIJOGw (ORCPT + 99 others); Mon, 10 Sep 2018 10:06:52 -0400 Received: from mail-io0-f193.google.com ([209.85.223.193]:45559 "EHLO mail-io0-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726081AbeIJOGw (ORCPT ); Mon, 10 Sep 2018 10:06:52 -0400 Received: by mail-io0-f193.google.com with SMTP id e12-v6so25776iok.12 for ; Mon, 10 Sep 2018 02:13:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=bKwLsGkvnyzYF+jIdXeK91qBWk7wtIOS4afg/iF9Fb0=; b=LpSOnnZR66xGj+ikztCUeMi0WiSBFLsNRdTC5l2cVAxdmF51KJiCBHHvMQ8qlHONsi gITXst3ePXL8BT6UbKx7XwWCSFB5FSNGzn5Vp+pTqzhXlC9NrvajVKNBd5p5Rt1U7VdF bodp/csTE3V9YrZBnXEdSCafnUVZfvrPmfoZRRkji37exUCJUg30E+7mzrHKGloILzGp O+4KUDHd1jWHS33BkcDOp5p5WRs98Bs8I02NrR3MBtrLYMllA/HwwkMVfpEWY0/FeQU+ rF2yUfeDGBGC/LcfqDL0C5hP684YDqpeD/EkdB2NIk+C7t4EFd67J9bwLcxr1dig6GEt apEg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=bKwLsGkvnyzYF+jIdXeK91qBWk7wtIOS4afg/iF9Fb0=; b=oI4tVFwm82473JqGsJ7VQ1bSv/PIIsoxbSv1e0qpP0YWxievcupw+2rD4Ip6xd/Ld6 MHmeDcSwFPyAaKUiCr0vIa91vH3uNRVKk3cr3sQYYYPXw0ty912kOENQGigvJXbmmVeG CeykchfJEaBS0ZQ7TdH7/IFJwMfzqisWMeUA/LRl76f46lsoJIP16m8sb/qS5INYgevB BhMxBxsVpzHGfelW8pwP7QztjPhE1b5b+cmsjAUMHk4iRP+A56kiTAT1ZADaRk1TRBgn 9F4pA3c1xcotBQSgEz+X5qO3Qj6JZU9iLkb2SM+iojqcgG/pKmhwY96a19MjihHlVbGW aOag== X-Gm-Message-State: APzg51B7tCq1PbSkkzy1jjPhQd/dQo8FS7PnY8n3T3KRy1/V5epsIN2b VRtUmkF11tw/gKm49o0PmQwtn6KB30brMVoFEaTAGwh7dDY= X-Received: by 2002:a6b:18c5:: with SMTP id 188-v6mr15388663ioy.211.1536570827585; Mon, 10 Sep 2018 02:13:47 -0700 (PDT) MIME-Version: 1.0 References: <20180718160956.19864-1-enric.balletbo@collabora.com> <20180718160956.19864-3-enric.balletbo@collabora.com> <20180907075438.GB95655@rodete-laptop-imager.corp.google.com> <20180910091208.GH28860@dell> In-Reply-To: <20180910091208.GH28860@dell> From: Benson Leung Date: Mon, 10 Sep 2018 17:13:34 +0800 Message-ID: Subject: Re: [PATCH 2/2] mfd: cros_ec: Fix and improve kerneldoc comments. To: Lee Jones Cc: Enric Balletbo i Serra , Linux Kernel , Guenter Roeck , kernel@collabora.com Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Sep 10, 2018 at 5:12 PM Lee Jones wrote: > > On Fri, 07 Sep 2018, Benson Leung wrote: > > > Hi Enric, > > > > On Wed, Jul 18, 2018 at 06:09:56PM +0200, Enric Balletbo i Serra wrote: > > > cros-ec includes inside the MFD subsystem, specially the file > > > cros_ec_commands.h, has been modified several times and it has grown a > > > lot, unfortunately, we didn't have care too much about the documentation. > > > This patch tries to improve the documentation and also fixes all the > > > issues reported by kerneldoc script. > > > > > > Signed-off-by: Enric Balletbo i Serra > > > > Applied, thanks. > > If applying patches from other subsystems, you need to wait for an > appropriate Ack before applying. Please send me a succinct > pull-request for this patch, so that we might avoid potential conflict > at merge time. > Ok Lee, sorry about that. Actually this hasn't landed in my for-next branch yet so no conflict has happened yet. I will send you a PR shortly. -- Benson Leung Staff Software Engineer Chrome OS Kernel Google Inc. bleung@google.com Chromium OS Project bleung@chromium.org