Received: by 2002:ac0:a5a6:0:0:0:0:0 with SMTP id m35-v6csp2530984imm; Mon, 10 Sep 2018 02:36:01 -0700 (PDT) X-Google-Smtp-Source: ANB0VdYxd+JZXoeCooz8utL+cdkhABj98T1FRjTLxazNE/G6hYqaBzEjqLnZkqGuJH5mHXJ2vF+v X-Received: by 2002:a62:54c7:: with SMTP id i190-v6mr22441749pfb.155.1536572161868; Mon, 10 Sep 2018 02:36:01 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1536572161; cv=none; d=google.com; s=arc-20160816; b=ZaHOaWXkUS/y8pf5T4w+Fg2/s0oOGirAWvD1NQRdy2Tpvh3lNcYVh0mrqhnbRPvs2A qPd3/u0ut5TnIOEWdftLxOmN+6mFrTzJ33uQarn7cwsuE7ye+cMYOTKHwV7NPMjFSvCm y6REguvLV4KNNRjTLci+HmO6N+Kce9q1MRuuN0Y77OHr8VhXOjxAj4CJ3nJboU287CKQ s8a6pmT+CvNupCHegqY9Yi2Z003sN3JSoX5xk3a691w7Do6XwQeY6HiYcoK1/iQwGRpZ sa/eukt/qxt8NsWg1lGI8F5Gt7bc3byWLnTMdg+c7fr1x2h5CVk4NdQD/fWFYVdBYiAG TW3w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:cc:to:subject:message-id:date:from :references:in-reply-to:mime-version:dkim-signature; bh=axeLWSghoDFQLpc11pi/AURy7Pq9cAxxdpbSE6p5YWM=; b=CghfLGxUgcK7PrLduqRK+h4tjvOmhVzPyd4Otw3+kZ8c4jqnuzQuVZYZ3K7rlbQDF9 m9ApH7qE6OAlnCtUTvnabEVav5u0IyQStWV51Ui4RVJdSEfABeNVv52HucMR6sgyMQa/ I0a/j/Vy5yzmLF8s4kmM70bSxqegnpk79TGMMo8yMwJ8uL8AFZCN2VejLQr0q8sQdq4i B6WEm6rfuB8l/igk11bAtXkSyi+Z23stcN4i27e5fwTG4H3RIwhb7kECqDcqNuW0eog+ 1esqPYyByAk7CevTKwPN4l4ZJtL1trTne15nlBOIvW47xC7OprI5rWpx4hr4j5kjKACA RMew== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=K2FsWy2z; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id a20-v6si16293093pgi.184.2018.09.10.02.35.46; Mon, 10 Sep 2018 02:36:01 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=K2FsWy2z; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728048AbeIJO0x (ORCPT + 99 others); Mon, 10 Sep 2018 10:26:53 -0400 Received: from mail-lf1-f67.google.com ([209.85.167.67]:33202 "EHLO mail-lf1-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726148AbeIJO0w (ORCPT ); Mon, 10 Sep 2018 10:26:52 -0400 Received: by mail-lf1-f67.google.com with SMTP id m26-v6so16881075lfb.0 for ; Mon, 10 Sep 2018 02:33:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=axeLWSghoDFQLpc11pi/AURy7Pq9cAxxdpbSE6p5YWM=; b=K2FsWy2z9gO6UMzfzCCXP4gb2RhIeAPw20BevoxqnjK5/jgPs1UNULdQIZpApz5s8Q 8BY8vrE0+Ds++ibL5fwS74TqCZqBYUIHRUN68GHUq/K83ahPk5F2uBz7bnXocv4TXPsO 5e9wpWM629MIMGOIyO6pupDnfgEC4paImiBbA= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=axeLWSghoDFQLpc11pi/AURy7Pq9cAxxdpbSE6p5YWM=; b=BBV7+63mCpA93CC5sJKyAvPN5KWSsESBpmwKCCHPwVQiT/V/nuimKPFo557at9Q4T4 Z9wSCVHQse/yfpnu/xcU9B6sIc9MumegreL6JqbmhDUMSuuATwkHzOI3XMsY2XaPQFD4 +KKGnnOrglMjQnpw+bZAbMuLC/pQCH2wio0/y9kQNmuCjhCow3luDAZpeOBuRB/1fTgm /1lFwzBWlaWWv8++W1ZcWVtB4zcdR2w8PwAIGkQNR9viYvNabrBu+55l9FhehNNSsEI/ haRJlCf6RZ4eTR9ke7i2b4Wkv2q9/Q0hOl7N6d3Nf7KGg6awUmrOHAZEByDDIgZ6dRrs KT2g== X-Gm-Message-State: APzg51AeUDGq8Tmurh8Ef9J7FsKRgMfjiELQsQ0AfmRSy4LPnGOqn6Mj VbPYVHuCWjz1xfdG+K1Q1VDuqD8YdO2qs/VeXu9Byw== X-Received: by 2002:a19:f802:: with SMTP id a2-v6mr11497817lff.33.1536572022681; Mon, 10 Sep 2018 02:33:42 -0700 (PDT) MIME-Version: 1.0 Received: by 2002:a19:118f:0:0:0:0:0 with HTTP; Mon, 10 Sep 2018 02:33:02 -0700 (PDT) In-Reply-To: <20180910092009.y2p5n5owozaz6etw@holly.lan> References: <20180910092009.y2p5n5owozaz6etw@holly.lan> From: Victor Chong Date: Mon, 10 Sep 2018 18:33:02 +0900 Message-ID: Subject: Re: Fwd: [PATCH] tee: optee: log message if dynamic shm is enabled To: Daniel Thompson Cc: Jens Wiklander , tee-dev@lists.linaro.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Sep 10, 2018 at 6:20 PM, Daniel Thompson wrote: > On Mon, Sep 10, 2018 at 05:57:28PM +0900, Victor Chong wrote: > > This (empty) patch description seems unusually terse! Surely there > should be some clues in the description about why this messages > deserves user/dev/admin attention... Ok. Will add description and send out v2. Thanks > > >> Suggested-by: Jerome Forissier >> Signed-off-by: Victor Chong >> Reviewed-by: Jerome Forissier >> --- >> drivers/tee/optee/core.c | 3 +++ >> 1 file changed, 3 insertions(+) >> >> diff --git a/drivers/tee/optee/core.c b/drivers/tee/optee/core.c >> index e1aafe842d66..cca5c091e55a 100644 >> --- a/drivers/tee/optee/core.c >> +++ b/drivers/tee/optee/core.c >> @@ -631,6 +631,9 @@ static struct optee *optee_probe(struct device_node *np) >> >> optee_enable_shm_cache(optee); >> >> + if (optee->sec_caps & OPTEE_SMC_SEC_CAP_DYNAMIC_SHM) >> + pr_info("dynamic shared memory is enabled\n"); >> + >> pr_info("initialized driver\n"); >> return optee; >> err: >> -- >> 2.17.1