Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
References: <20180908045928.26201-1-igor.stoppa@huawei.com>
In-Reply-To: <20180908045928.26201-1-igor.stoppa@huawei.com>
From:   Arnd Bergmann <arnd@arndb.de>
Date:   Mon, 10 Sep 2018 14:16:52 +0200
Message-ID: <CAK8P3a02Q0_r4sqzJzA01GEHf0oUyevwwVg+E0_iCEkLFrwOaw@mail.gmail.com>
Subject: Re: [PATCH v2] asm-generic: bug: unify hints for BUG_ON()
To:     Igor Stoppa <igor.stoppa@gmail.com>
Cc:     igor.stoppa@huawei.com, linux-arch <linux-arch@vger.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Sat, Sep 8, 2018 at 6:59 AM Igor Stoppa <igor.stoppa@gmail.com> wrote:
>
> If BUG_ON() is used instead of BUG(), it means that probably the
> preferred outcome is to not BUG(), therefore the condition tested should
> be unlikely().
>
> However, when CONFIG_PROFILE_ANNOTATED_BRANCHES is enabled, the hint is
> disabled, to avoid generating false-positive warnings caused by
> -Wmaybe-uninitialized.
>
> Signed-off-by: Igor Stoppa <igor.stoppa@huawei.com>
> Cc: Arnd Bergmann <arnd@arndb.de>
> Cc: linux-arch@vger.kernel.org
> Cc: linux-kernel@vger.kernel.org
> ---

Acked-by: Arnd Bergmann <arnd@arndb.de>

I assume this will be included in a longer patch series rather than
going through
my asm-generic tree, right?

     Arnd