Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S264043AbTKJSG4 (ORCPT ); Mon, 10 Nov 2003 13:06:56 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S264045AbTKJSGz (ORCPT ); Mon, 10 Nov 2003 13:06:55 -0500 Received: from zero.aec.at ([193.170.194.10]:10764 "EHLO zero.aec.at") by vger.kernel.org with ESMTP id S264043AbTKJSGx (ORCPT ); Mon, 10 Nov 2003 13:06:53 -0500 To: Adam Litke Cc: linux-kernel@vger.kernel.org Subject: Re: [RFC] Smarter stack traces using the frame pointer From: Andi Kleen Date: Mon, 10 Nov 2003 19:06:03 +0100 In-Reply-To: (Adam Litke's message of "Mon, 10 Nov 2003 19:00:15 +0100") Message-ID: User-Agent: Gnus/5.090013 (Oort Gnus v0.13) Emacs/21.2 (i586-suse-linux) References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 775 Lines: 22 Adam Litke writes: > -static int kstack_depth_to_print = 24; > +static int kstack_depth_to_print = 128; I would not do that. It makes too much of the oops scroll away. > + show_stack_frame((unsigned long) stack, ebp+4); I think this needs much more sanity checking, otherwise the risk of recursive oops etc is too big. I would always check first if the stack value read from ebp is inside the stack page of the current process. If you're paranoid you could even use __get_user() to catch exceptions. -Andi - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/