Received: by 2002:ac0:a5a6:0:0:0:0:0 with SMTP id m35-v6csp2947145imm;
        Mon, 10 Sep 2018 08:41:45 -0700 (PDT)
X-Google-Smtp-Source: ANB0Vda8BRNgCKoDVqO22aW9aHmvaTYxyF2rLD2u6Yaa8RVYcc0O9XTDlhvGy3+DeJhlEOYec3bS
X-Received: by 2002:a62:398c:: with SMTP id u12-v6mr24719493pfj.9.1536594105771;
        Mon, 10 Sep 2018 08:41:45 -0700 (PDT)
ARC-Seal: i=1; a=rsa-sha256; t=1536594105; cv=none;
        d=google.com; s=arc-20160816;
        b=Yv+0sQcBhOIIwWuF/5qFYPI497Wbjppt8zEB+8VRul2JQdI8XjEb9afZZILl8+AUql
         2g30g+NVw5i+otVrstTCw1TcrzYtRaUOLq2gQAA31aixQj25LRS3i8kPNINihr49++Xj
         My9sRuxpTzhYA48UE2i45cthGexrooJM7Y0gmsoSO51tRIe+3oSz7YzHPhS1z2yaIWVi
         Mms2XA1sAoV7SNDF1/keBnfLe3eaizxyy1DyJ8fwXLZ619tKNQcjcYJn41ke+0Fw1XsU
         p6t5lfLwXXG1QgLl3acbpbejnN24WJDcHmDE6urAF4xDnCRpM+VgxPW0FwPP7SwTBpXc
         s0WA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816;
        h=list-id:precedence:sender:content-transfer-encoding:mime-version
         :references:in-reply-to:message-id:subject:cc:to:from:date;
        bh=SSdo1cpLeWJhQ4ukhdPoHJHwRgSOBgF8Vcfeh/pi4eE=;
        b=AFYjFQ999M4nwU89bITgdfCI3GVmebOT0nboF3vyTEPOLKjXMRlyzWtotk754/Jtlo
         bvh+yWoGWVmJvKALlWC2WybIpcVtq1ciSfbYR9MFGoJK7Y1uR218Mtxyyn3o7htJ1fyM
         dQVGJuMkEIWeAHd7ipvi45rFY3s6rdz8uPTmyvVOVYJrWocuJY4IgNx8KjuP3zsZxoni
         o7jb+beoUJ13jQT1UP/pTtI21G0dYxhANPSXAknGzn1ucY/bZGt6lNBuPzXqXlHGtZB8
         B1IjDkRNKNQz/VSEzHW+MZsE19DhY3dAbrLxoDL5Sn3d8N7Ol5Aja6HYwdGhnFuF4jZ/
         5tUA==
ARC-Authentication-Results: i=1; mx.google.com;
       spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org;
       dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=redhat.com
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67])
        by mx.google.com with ESMTP id a7-v6si18640816pln.142.2018.09.10.08.41.30;
        Mon, 10 Sep 2018 08:41:45 -0700 (PDT)
Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Authentication-Results: mx.google.com;
       spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org;
       dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=redhat.com
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1728211AbeIJUem (ORCPT <rfc822;orsonzhai@gmail.com> + 99 others);
        Mon, 10 Sep 2018 16:34:42 -0400
Received: from mx3-rdu2.redhat.com ([66.187.233.73]:57464 "EHLO mx1.redhat.com"
        rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP
        id S1727649AbeIJUel (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Mon, 10 Sep 2018 16:34:41 -0400
Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.rdu2.redhat.com [10.11.54.5])
        (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
        (No client certificate requested)
        by mx1.redhat.com (Postfix) with ESMTPS id D8E8B4023461;
        Mon, 10 Sep 2018 15:40:01 +0000 (UTC)
Received: from localhost (ovpn-204-175.brq.redhat.com [10.40.204.175])
        by smtp.corp.redhat.com (Postfix) with ESMTPS id BEEC663A70;
        Mon, 10 Sep 2018 15:39:59 +0000 (UTC)
Date:   Mon, 10 Sep 2018 17:39:57 +0200
From:   Jiri Benc <jbenc@redhat.com>
To:     zhong jiang <zhongjiang@huawei.com>
Cc:     <davem@davemloft.net>, <edumazet@google.com>,
        <kuznet@ms2.inr.ac.ru>, <yoshfuji@linux-ipv6.org>,
        <netdev@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] net: ipv4: Use BUG_ON directly instead of a if
 condition followed by BUG
Message-ID: <20180910173957.5f3728e6@redhat.com>
In-Reply-To: <1536590282-23899-1-git-send-email-zhongjiang@huawei.com>
References: <1536590282-23899-1-git-send-email-zhongjiang@huawei.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
X-Scanned-By: MIMEDefang 2.79 on 10.11.54.5
X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.11.55.6]); Mon, 10 Sep 2018 15:40:01 +0000 (UTC)
X-Greylist: inspected by milter-greylist-4.5.16 (mx1.redhat.com [10.11.55.6]); Mon, 10 Sep 2018 15:40:01 +0000 (UTC) for IP:'10.11.54.5' DOMAIN:'int-mx05.intmail.prod.int.rdu2.redhat.com' HELO:'smtp.corp.redhat.com' FROM:'jbenc@redhat.com' RCPT:''
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Mon, 10 Sep 2018 22:38:02 +0800, zhong jiang wrote:
> +			BUG(skb_copy_bits(skb, ptr, &tmp, 1));

I doubt this builds.

 Jiri