Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Message-ID: <1536601160.7046.3.camel@collabora.com>
Subject: Re: [PATCH v7] Add udmabuf misc device
From:   Gert Wollny <gert.wollny@collabora.com>
To:     Gerd Hoffmann <kraxel@redhat.com>
Cc:     linux-kernel@vger.kernel.org, David Airlie <airlied@linux.ie>,
        Tomeu Vizoso <tomeu.vizoso@collabora.com>,
        Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
        Daniel Vetter <daniel@ffwll.ch>
Date:   Mon, 10 Sep 2018 19:39:20 +0200
In-Reply-To: <20180910133050.tr2lozfmhimqs4c4@sirius.home.kraxel.org>
References: <1536491489.4810.22.camel@collabora.com>
         <20180910083731.o4rryvermyighbtp@sirius.home.kraxel.org>
         <1536571118.4810.38.camel@collabora.com>
         <20180910105309.zmyoo5yhrmqg47md@sirius.home.kraxel.org>
         <1536579068.4810.68.camel@collabora.com>
         <20180910133050.tr2lozfmhimqs4c4@sirius.home.kraxel.org>
Content-Type: text/plain; charset="UTF-8"
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Using the kernel 4.19.0-rc2 it works now, so With the fix for not
calling fput when memfd == NULL the patch is 
  Reviewed-By: Gert Wollny <gert.wollny@collabora.com>

best,
Gert 

Am Montag, den 10.09.2018, 15:30 +0200 schrieb Gerd Hoffmann:
> On Mon, Sep 10, 2018 at 01:31:08PM +0200, Gert Wollny wrote:
> > Am Montag, den 10.09.2018, 12:53 +0200 schrieb Gerd Hoffmann:
> > > 
> > > By default qemu doesn't use memfd for backing storage, you have
> > > to
> > > explicitly configure qemu that way (see qemu commit log of the
> > > test
> > > branch):
> > > 
> > >     qemu-system-x86_64 -m 2G
> > >             -object memory-backend-memfd,id=ram,size=2G
> > >             -numa node,memdev=ram"
> > 
> > Thanks, but that doesn't seem to help.
> 
> Note the memory is specified twice, once with -m, once for the
> memory-backend-memfd object.  The two must match of course (or, to be
> exact, the sum of all memory backends must match the total memory,
> but
> unless you want create a virtual numa machine there is no reason to
> have
> multiple memory-backends).
> 
> > Are there any host kernel
> > configuration parameters or features that I should set (apart from
> > enabling udmabuf)? 
> 
> I'm not aware of any unusual parameters required.  My config is based
> on
> rhel-7, then stripped down with localmodconfig, then enabled the bits
> I
> want in my test kernel.
> 
> Oh, wait, CONFIG_MEMFD_CREATE could be the one.  I guess I should add
> a
> Kconfig dependency.  Even though udmabuf will build just fine without
> that (because memfd is basically shmem with some features on top) it
> doesn't buy you much if the memfd_create syscall is not available ...
> 
> cheers,
>   Gerd
>