Received: by 2002:ac0:a5a6:0:0:0:0:0 with SMTP id m35-v6csp3119553imm; Mon, 10 Sep 2018 11:20:55 -0700 (PDT) X-Google-Smtp-Source: ANB0Vdb+xHwaW6WtGARoGsqT6IchFjEr8ZCLWXm48FRANeY1mEbg8GiR6uJgA81olcgMlJZDdtD9 X-Received: by 2002:a17:902:24e1:: with SMTP id l30-v6mr23331793plg.315.1536603655201; Mon, 10 Sep 2018 11:20:55 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1536603655; cv=none; d=google.com; s=arc-20160816; b=rQ2Oz+iNGIRBgTey0F7EYVdYVytrc8WM8s4/5N2bw3bqZhgEME+Slwikl+hdfhJHnF 1/h3cVdS476wiyTkMKm2ehDV1xSZFzymvlFakUYU7DUowTGI9D2ti9fJLj4hjgwezj95 7w7iNzgrJ6xujWLcalW+v79lGMkrbYiDxUJDPU4X57f0UkJs9coe0HkOMs43kDXROGrR K80UnBU4h04+i+ELkEWPQ1g8UeuWJyDHrdrbBUXqV42Z4s6Qf307QzHQRotmTn0T5Ix+ wKRNV+dNWoRqC4EOcOKeeYrE22watIQbRAyxAiFgDicakILAt86Lxx7zd/EwJJwd50P0 DU7Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date; bh=OqYTvhRxqiX0YRxG4DHqYqtTV179iYJivfoVh/YQVVE=; b=vEMrw14x7g6fMdCQN+TnRr15cSwddqpekUgeeziq3ExMhwQMM4Kn8dBlYyTX2qeeRV V72hbAH08QrD4ujM7bOBtwsUbGbGSqw/0zlUUmmINl7J+2f35O19VrBfiO42PSVuZuEH lEpWu5lDy0tmfhN2T2jBJzr57o9lTm9PyEDk8NXe+uv+HLIWjKdeI8OHbqefwOxmRrjo b/MKRw9T4SwpLrwboRCHGe3VMkl8AU4ZdZ0FH50uBASC+PX6X8i5g7E3hdwE/4NvC60G 9FjKXRjscwVgE6yzT5JNGw5k9Ud1b4UZz7iohOLmWzWW5wDeIRjOY5Hhmvj8ArLjsQYI wxDg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id h16-v6si16775420plr.343.2018.09.10.11.20.39; Mon, 10 Sep 2018 11:20:55 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728020AbeIJXPa (ORCPT + 99 others); Mon, 10 Sep 2018 19:15:30 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:44672 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726603AbeIJXP3 (ORCPT ); Mon, 10 Sep 2018 19:15:29 -0400 Received: from localhost (ip-213-127-74-90.ip.prioritytelecom.net [213.127.74.90]) by mail.linuxfoundation.org (Postfix) with ESMTPSA id C5B40115E; Mon, 10 Sep 2018 18:20:08 +0000 (UTC) Date: Mon, 10 Sep 2018 20:20:05 +0200 From: Greg Kroah-Hartman To: Pawel Laszczak Cc: Bin Liu , "linux-usb@vger.kernel.org" , Felipe Balbi , "linux-kernel@vger.kernel.org" , Lukasz Tyrala , Alan Douglas Subject: Re: [PATCH 00/31] Introduced new Cadence USBSSP DRD Driver Message-ID: <20180910182005.GC6019@kroah.com> References: <1532023084-28083-1-git-send-email-pawell@cadence.com> <20180817210534.GA11144@uda0271908> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Aug 21, 2018 at 02:50:19PM +0000, Pawel Laszczak wrote: > Hi, > > USBSSP it's the project name and it was the reason for such prefix. > > I agree with you that the shorter prefix could be better and we could get rid of some warnings reported by checkpatch. Currently we have more important issues related to testing and debugging driver so decision about change I leave for the feature. Such modification could be made as separate single patch. No, get it right at the beginning please. Having "my function names are too long" errors right when you first submit the code implies that you don't really care about meeting our normal coding style rules. Now of course I _know_ you don't mean to imply that at all, right? :) thanks, greg k-h