Received: by 2002:ac0:a5a6:0:0:0:0:0 with SMTP id m35-v6csp3225845imm; Mon, 10 Sep 2018 13:09:03 -0700 (PDT) X-Google-Smtp-Source: ANB0VdYsJFUlZtglOFQEVdS9lNRtGnEHuVG2bZQL+SYQlfsT3yPIJ6SE7tZWko+gR7+xeXoJfB/8 X-Received: by 2002:a63:2c8e:: with SMTP id s136-v6mr25008888pgs.390.1536610143531; Mon, 10 Sep 2018 13:09:03 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1536610143; cv=none; d=google.com; s=arc-20160816; b=MFsqOdeSNVTpgoSb1npW6pyakaPQ5C+MOWrb03dUfrF7vX8VbzvbQNU1hEpGyqGH8V Op/fl96nKdVN2J1wOHBAMq+oj0qrHoTWPTi+kpmFRaTjvjyBhpACLtG+c9swHsqf06I1 WBy/YMR3Jo6Y6crOr7AvNKaLxGVmhSpmJxbnr+NKVEvwYdASSkgCL8HGBc6Nfursb+tH CO+mNMg6DACqSnY3szO08h4pO+FJap16diE2GOQYlV2CGLAG1/UVnvnwJe20vsMHUfSN nbIWW/Ez7Cu3RS/eAA7vNEkFvrAeKF5RMjBkmsSgGYkH43GApjOhAUXQ5oTPO+a2INrw cAcQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:autocrypt:openpgp:from:cc:references:to:subject; bh=J/8XEklKZ45IUpQrb5ia6Fo+UKuIRec/0aTLm+JM7f4=; b=HUyS3ad/oE1aOnqzej5asegBhvdB39E300sToRQB+qvlLNNBt9+EVFJx4odWKcAQk2 Hpn2+hXOa5rLX9B3xXuuo5F6/DZJXIkrWpFBq86FifKhxBsjbAGGubJVObGq5LtD85uE Y9P7mfqndk13AgsBnpIr+qKo3Yex9+XkvTBZwNJoGz/qcLq84LmatUiZulrcrs+Jwlfd 1oXOL6qtzvdP4KflDHCDvctyQfvBogj0Wy2RTDUGpqClN2nG9Obqyf8bb48tHXwlWwqI QJoocJ3nsUMZ1FpQxFJQWw7JFyKqjAaFYSVVmV/W81bQu1xgwKTVhZTqBCkB9csydvZC R4gw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id j185-v6si17690198pgc.419.2018.09.10.13.08.42; Mon, 10 Sep 2018 13:09:03 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728840AbeIKBDe (ORCPT + 99 others); Mon, 10 Sep 2018 21:03:34 -0400 Received: from mga03.intel.com ([134.134.136.65]:28332 "EHLO mga03.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727709AbeIKBDe (ORCPT ); Mon, 10 Sep 2018 21:03:34 -0400 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga001.jf.intel.com ([10.7.209.18]) by orsmga103.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 10 Sep 2018 13:07:49 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.53,356,1531810800"; d="scan'208";a="89268918" Received: from ray.jf.intel.com (HELO [10.7.201.22]) ([10.7.201.22]) by orsmga001.jf.intel.com with ESMTP; 10 Sep 2018 13:07:38 -0700 Subject: Re: [RFC][PATCH 1/8] x86/mm: clarify hardware vs. software "error_code" To: Andy Lutomirski References: <20180907194852.3C351B82@viggo.jf.intel.com> <20180907194854.74729D71@viggo.jf.intel.com> <561334F6-9C13-424A-95ED-D377CE48DA46@amacapital.net> Cc: linux-kernel@vger.kernel.org, sean.j.christopherson@intel.com, peterz@infradead.org, tglx@linutronix.de, x86@kernel.org, luto@kernel.org From: Dave Hansen Openpgp: preference=signencrypt Autocrypt: addr=dave.hansen@linux.intel.com; keydata= xsFNBE6HMP0BEADIMA3XYkQfF3dwHlj58Yjsc4E5y5G67cfbt8dvaUq2fx1lR0K9h1bOI6fC oAiUXvGAOxPDsB/P6UEOISPpLl5IuYsSwAeZGkdQ5g6m1xq7AlDJQZddhr/1DC/nMVa/2BoY 2UnKuZuSBu7lgOE193+7Uks3416N2hTkyKUSNkduyoZ9F5twiBhxPJwPtn/wnch6n5RsoXsb ygOEDxLEsSk/7eyFycjE+btUtAWZtx+HseyaGfqkZK0Z9bT1lsaHecmB203xShwCPT49Blxz VOab8668QpaEOdLGhtvrVYVK7x4skyT3nGWcgDCl5/Vp3TWA4K+IofwvXzX2ON/Mj7aQwf5W iC+3nWC7q0uxKwwsddJ0Nu+dpA/UORQWa1NiAftEoSpk5+nUUi0WE+5DRm0H+TXKBWMGNCFn c6+EKg5zQaa8KqymHcOrSXNPmzJuXvDQ8uj2J8XuzCZfK4uy1+YdIr0yyEMI7mdh4KX50LO1 pmowEqDh7dLShTOif/7UtQYrzYq9cPnjU2ZW4qd5Qz2joSGTG9eCXLz5PRe5SqHxv6ljk8mb ApNuY7bOXO/A7T2j5RwXIlcmssqIjBcxsRRoIbpCwWWGjkYjzYCjgsNFL6rt4OL11OUF37wL QcTl7fbCGv53KfKPdYD5hcbguLKi/aCccJK18ZwNjFhqr4MliQARAQABzShEYXZpZCBDaHJp c3RvcGhlciBIYW5zZW4gPGRhdmVAc3I3MS5uZXQ+wsF7BBMBAgAlAhsDBgsJCAcDAgYVCAIJ CgsEFgIDAQIeAQIXgAUCTo3k0QIZAQAKCRBoNZUwcMmSsMO2D/421Xg8pimb9mPzM5N7khT0 2MCnaGssU1T59YPE25kYdx2HntwdO0JA27Wn9xx5zYijOe6B21ufrvsyv42auCO85+oFJWfE K2R/IpLle09GDx5tcEmMAHX6KSxpHmGuJmUPibHVbfep2aCh9lKaDqQR07gXXWK5/yU1Dx0r VVFRaHTasp9fZ9AmY4K9/BSA3VkQ8v3OrxNty3OdsrmTTzO91YszpdbjjEFZK53zXy6tUD2d e1i0kBBS6NLAAsqEtneplz88T/v7MpLmpY30N9gQU3QyRC50jJ7LU9RazMjUQY1WohVsR56d ORqFxS8ChhyJs7BI34vQusYHDTp6PnZHUppb9WIzjeWlC7Jc8lSBDlEWodmqQQgp5+6AfhTD kDv1a+W5+ncq+Uo63WHRiCPuyt4di4/0zo28RVcjtzlGBZtmz2EIC3vUfmoZbO/Gn6EKbYAn rzz3iU/JWV8DwQ+sZSGu0HmvYMt6t5SmqWQo/hyHtA7uF5Wxtu1lCgolSQw4t49ZuOyOnQi5 f8R3nE7lpVCSF1TT+h8kMvFPv3VG7KunyjHr3sEptYxQs4VRxqeirSuyBv1TyxT+LdTm6j4a mulOWf+YtFRAgIYyyN5YOepDEBv4LUM8Tz98lZiNMlFyRMNrsLV6Pv6SxhrMxbT6TNVS5D+6 UorTLotDZKp5+M7BTQRUY85qARAAsgMW71BIXRgxjYNCYQ3Xs8k3TfAvQRbHccky50h99TUY sqdULbsb3KhmY29raw1bgmyM0a4DGS1YKN7qazCDsdQlxIJp9t2YYdBKXVRzPCCsfWe1dK/q 66UVhRPP8EGZ4CmFYuPTxqGY+dGRInxCeap/xzbKdvmPm01Iw3YFjAE4PQ4hTMr/H76KoDbD cq62U50oKC83ca/PRRh2QqEqACvIH4BR7jueAZSPEDnzwxvVgzyeuhwqHY05QRK/wsKuhq7s UuYtmN92Fasbxbw2tbVLZfoidklikvZAmotg0dwcFTjSRGEg0Gr3p/xBzJWNavFZZ95Rj7Et db0lCt0HDSY5q4GMR+SrFbH+jzUY/ZqfGdZCBqo0cdPPp58krVgtIGR+ja2Mkva6ah94/oQN lnCOw3udS+Eb/aRcM6detZr7XOngvxsWolBrhwTQFT9D2NH6ryAuvKd6yyAFt3/e7r+HHtkU kOy27D7IpjngqP+b4EumELI/NxPgIqT69PQmo9IZaI/oRaKorYnDaZrMXViqDrFdD37XELwQ gmLoSm2VfbOYY7fap/AhPOgOYOSqg3/Nxcapv71yoBzRRxOc4FxmZ65mn+q3rEM27yRztBW9 AnCKIc66T2i92HqXCw6AgoBJRjBkI3QnEkPgohQkZdAb8o9WGVKpfmZKbYBo4pEAEQEAAcLB XwQYAQIACQUCVGPOagIbDAAKCRBoNZUwcMmSsJeCEACCh7P/aaOLKWQxcnw47p4phIVR6pVL e4IEdR7Jf7ZL00s3vKSNT+nRqdl1ugJx9Ymsp8kXKMk9GSfmZpuMQB9c6io1qZc6nW/3TtvK pNGz7KPPtaDzvKA4S5tfrWPnDr7n15AU5vsIZvgMjU42gkbemkjJwP0B1RkifIK60yQqAAlT YZ14P0dIPdIPIlfEPiAWcg5BtLQU4Wg3cNQdpWrCJ1E3m/RIlXy/2Y3YOVVohfSy+4kvvYU3 lXUdPb04UPw4VWwjcVZPg7cgR7Izion61bGHqVqURgSALt2yvHl7cr68NYoFkzbNsGsye9ft M9ozM23JSgMkRylPSXTeh5JIK9pz2+etco3AfLCKtaRVysjvpysukmWMTrx8QnI5Nn5MOlJj 1Ov4/50JY9pXzgIDVSrgy6LYSMc4vKZ3QfCY7ipLRORyalFDF3j5AGCMRENJjHPD6O7bl3Xo 4DzMID+8eucbXxKiNEbs21IqBZbbKdY1GkcEGTE7AnkA3Y6YB7I/j9mQ3hCgm5muJuhM/2Fr OPsw5tV/LmQ5GXH0JQ/TZXWygyRFyyI2FqNTx4WHqUn3yFj8rwTAU1tluRUYyeLy0ayUlKBH ybj0N71vWO936MqP6haFERzuPAIpxj2ezwu0xb1GjTk4ynna6h5GjnKgdfOWoRtoWndMZxbA z5cecg== Message-ID: <6f75823d-ce8b-d483-6046-4efbe20d0410@linux.intel.com> Date: Mon, 10 Sep 2018 13:07:38 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <561334F6-9C13-424A-95ED-D377CE48DA46@amacapital.net> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 09/07/2018 03:48 PM, Andy Lutomirski wrote: >> >> For part of the page fault handler, "error_code" does exactly >> match PFEC. But, during later parts, it diverges and starts to >> mean something a bit different. >> >> Give it two names for its two jobs. > How hard would it be to just remove sw_error_code instead? It seems > like it adds little value and much confusion. I think it would be really nice to have hw_error_code stand by itself and be limited in scope to just __do_page_fault() and then have FAULT_FLAG_* for everything else. But, I was a little scared off of that. For one, I think we fill in signal info with error_code, which makes it nominally part of the ABI. So, I wanted to muck with it as little as possible in this set. But, if we just said that 1. hw_error_code goes out to userspace, always, and 2. We drive all kernel behavior off of FAULT_FLAG_*, not error_code, I think we can get away with it. > I’m also unconvinced that the warning is terribly useful. We’re going > to oops when this happens anyway. One thing I wanted to get out of the warning was the contents of hw_error_code before we go screwing with it. I also don't mind a nice, clarifying warning showing up just before an oops. Maybe it could be a pr_warn/err() instead of a full warning?