Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
From:   Thinh Nguyen <Thinh.Nguyen@synopsys.com>
To:     Anurag Kumar Vulisha <anurag.kumar.vulisha@xilinx.com>,
        "balbi@kernel.org" <balbi@kernel.org>,
        "gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>
CC:     "linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "Thinh.Nguyen@synopsys.com" <Thinh.Nguyen@synopsys.com>,
        "v.anuragkumar@gmail.com" <v.anuragkumar@gmail.com>
Subject: Re: [PATCH v4 6/8] usb: dwc3: check for requests in started list
 for stream capable endpoints
Thread-Topic: [PATCH v4 6/8] usb: dwc3: check for requests in started list
 for stream capable endpoints
Thread-Index: AQHUR4UYRgxFEofqUUKoe+A6FKwC1w==
Date:   Mon, 10 Sep 2018 20:13:51 +0000
Message-ID: <30102591E157244384E984126FC3CB4F544ADE8E@us01wembx1.internal.synopsys.com>
References: <1536418986-16609-1-git-send-email-anurag.kumar.vulisha@xilinx.com>
 <1536418986-16609-7-git-send-email-anurag.kumar.vulisha@xilinx.com>
Accept-Language: en-US
Content-Language: en-US
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Hi Anurag,=0A=
=0A=
On 9/8/2018 8:03 AM, Anurag Kumar Vulisha wrote:=0A=
> For stream capable endpoints, uas layer can queue mulpile requests on=0A=
> single ep with different stream ids. So, there can be multiple pending=0A=
> requests waiting to be transferred. This patch changes the code to check=
=0A=
> for any pending requests waiting to be transferred on ep started_list and=
=0A=
> calls __dwc3_gadget_kick_transfer() if any.=0A=
=0A=
Whenever a function driver queues a request, then=0A=
__dwc3_gadget_kick_transfer() will be called right? What case exactly is=0A=
this for? Scatter gathering? If so, then we probably need further=0A=
explanation. (e.g. Why wait to call __dwc3_gadget_kick_transfer() on=0A=
XferComplete event rather than sending a START_TRANSFER command for=0A=
every prepared TRB whenever we do __dwc3_gadget_kick_transfer()?).=0A=
=0A=
Thanks,=0A=
Thinh=0A=
=0A=
>=0A=
> Signed-off-by: Anurag Kumar Vulisha <anurag.kumar.vulisha@xilinx.com>=0A=
> Reviewed-by: Thinh Nguyen <thinhn@synopsys.com>=0A=
> ---=0A=
>  Changes in v4:=0A=
> 	1. None=0A=
>=0A=
>  Changes in v3:=0A=
> 	1. None=0A=
>=0A=
>  Changes in v2:=0A=
> 	1. None=0A=
> ---=0A=
>  drivers/usb/dwc3/gadget.c | 3 +++=0A=
>  1 file changed, 3 insertions(+)=0A=
>=0A=
> diff --git a/drivers/usb/dwc3/gadget.c b/drivers/usb/dwc3/gadget.c=0A=
> index 97bfdf0..c50cad8 100644=0A=
> --- a/drivers/usb/dwc3/gadget.c=0A=
> +++ b/drivers/usb/dwc3/gadget.c=0A=
> @@ -2433,6 +2433,9 @@ static void dwc3_gadget_endpoint_transfer_in_progre=
ss(struct dwc3_ep *dep,=0A=
>  =0A=
>  	dwc3_gadget_ep_cleanup_completed_requests(dep, event, status);=0A=
>  =0A=
> +	if (dep->stream_capable && !list_empty(&dep->started_list))=0A=
> +		__dwc3_gadget_kick_transfer(dep);=0A=
> +=0A=
>  	if (stop) {=0A=
>  		dwc3_stop_active_transfer(dep, true);=0A=
>  		dep->flags =3D DWC3_EP_ENABLED;=0A=
=0A=
=0A=