To: linux-kernel@vger.kernel.org
Path: gatekeeper.tmr.com!davidsen
From: davidsen@tmr.com (bill davidsen)
Newsgroups: mail.linux-kernel
Subject: Re: [patch] reproducible athlon mce fix
Date: 10 Nov 2003 23:55:10 GMT
Organization: TMR Associates, Schenectady NY
Message-ID: <bop8gu$7uk$1@gatekeeper.tmr.com>
References: <20031102055748.GA1218@anakin.wychk.org> <20031102072519.GD530@alpha.home.local>
Originator: davidsen@gatekeeper.tmr.com
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1366
Lines: 38

In article <20031102072519.GD530@alpha.home.local>,
Willy Tarreau  <willy@w.ods.org> wrote:

| I don't know if the patch is correct, but :
| 
| On Sun, Nov 02, 2003 at 01:57:48PM +0800, Geoffrey Lee wrote:
| >  	preempt_disable(); 
| > +#if CONFIG_MK7
| > +	for (i=1; i<nr_mce_banks; i++) {
| > +#else
| >  	for (i=0; i<nr_mce_banks; i++) {
| > +#endif
| 
| Including opening braces within #if often fools editors such as emacs
| which count them and don't know about #if. Then, editing the rest of
| the file can become annoying because it simply thinks that there are
| two embedded for loops.

Wouldn't it be easier to just move the brace out of the ifdef and put it
on a line by itself? Readable, doesn't confuse, etc?

  	preempt_disable(); 
 +#if CONFIG_MK7
 +	for (i=1; i<nr_mce_banks; i++) {
 +#else
 - 	for (i=0; i<nr_mce_banks; i++) {
 + 	for (i=0; i<nr_mce_banks; i++)
 +#endif
        {

or similar. Otherwise I guess the solution defining a starting value
would be "less unreadable."


-- 
bill davidsen <davidsen@tmr.com>
  CTO, TMR Associates, Inc
Doing interesting things with little computers since 1979.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/