Received: by 2002:ac0:a5a6:0:0:0:0:0 with SMTP id m35-v6csp3660894imm; Mon, 10 Sep 2018 23:19:01 -0700 (PDT) X-Google-Smtp-Source: ANB0Vda4M8J97/jcaM+Y5b5eREocE9jwwUlrmml0nWSD8Thb+Feoo+iHynvVK+TBSS4rabirQjxQ X-Received: by 2002:a63:1e63:: with SMTP id p35-v6mr26642278pgm.376.1536646740960; Mon, 10 Sep 2018 23:19:00 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1536646740; cv=none; d=google.com; s=arc-20160816; b=ZZ0WyGmBdaUhcGxLSJrQPzYqeHQ8dV86ndB5jSE325bo/vwJM0uwt0LEp8yuQsHRo5 bfAW8aK9xA/OV24ClqaW9UG89lsKw2IVC7GsYkeQmV6KoX6Y7tpvLJOqnHOpWXbHCbKY bU5HI92zLCmvQ0agWJRKmWFqbKPLuVpmvGZ60cl7j0Ql28tBF5ivJqTjPmDsIgEiD+W1 1eMDiQ2d6xXQHiuoqm9M1hC6+eQYhiCZ7cW65XAEXoj5fF0JpRH9Rq/P4/POklquuD6/ 30XPbvC0+4Qt2Ly6demWEp6C9QOj2xySYVzgeQkGB+UwRUJTQKY9snJud0ApZ4HRqU9N IKVw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=2eG37OC2wnxmCbpj1EI33KsWp564vwH+16wC3j2WKhI=; b=huB+tGeHrL+F688dH8uUgoZUv83gQXa0u3u0U1noI8fWbR9cOfojszRS6teiRaCvfA CX5TWLIMJkCB32iCZnv9vdjJtSOl+kFhDkOu7BcVx/XNFikv2stVMDaDLcafE4p0xMc+ 9kOLpqyT5Drqv9mz9xmrV7wx7cQalSFrxUZ3gTi3pVNE0tQGwqxfDxLS8m+P4YXXZrOv 6t9gJcMFbxfLbfxiRoS4a6Q66NIM2JdsQGXIoRTNLjpa6BUdIr8PMJhS/tX/MdeXM8FN RVfG6GltTMEOvQw0XUBH/+e3nInN8YNlXmRM5XhZd+gIoVf6e6hDZIf3kL5hr/8xGxCr 4mlA== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@infradead.org header.s=bombadil.20170209 header.b=q2utruhc; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id v66-v6si19836764pfb.368.2018.09.10.23.18.45; Mon, 10 Sep 2018 23:19:00 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=fail header.i=@infradead.org header.s=bombadil.20170209 header.b=q2utruhc; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726819AbeIKLPe (ORCPT + 99 others); Tue, 11 Sep 2018 07:15:34 -0400 Received: from bombadil.infradead.org ([198.137.202.133]:34422 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726332AbeIKLPe (ORCPT ); Tue, 11 Sep 2018 07:15:34 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20170209; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=2eG37OC2wnxmCbpj1EI33KsWp564vwH+16wC3j2WKhI=; b=q2utruhc7tqokiS4l7ID0uq7M kuxbECaSvGzkg6iZ/VIl6kWALWxYDZLtxrIbMY5kEw7KVn33qxNFGQ00GMvw3/krCODyyRbSNYkqX D2WqQ9NjR1KuuQlBp8ht+DtB8AS1mOUu7v4Yakhlf55gGlriJ5CTPfcgrjcG0LbJLfgSWowUSAFj8 pktQdjxOKlZD1Ijuz9Qvvtfji4e/HfqEnkV+RECkzYBW6PHkCMuVxUsD54ufIQ7xdW+wjM11TpAcj Cee0ZF5XNeeOfEJzTjPtzpYAo5rJlouKfCIxKGMD9pv39Wa1JnGgZKvOq/IM8QQ0prNYf9gpkkOQ/ G3pEc1X8g==; Received: from hch by bombadil.infradead.org with local (Exim 4.90_1 #2 (Red Hat Linux)) id 1fzbzd-00064j-Sp; Tue, 11 Sep 2018 06:17:45 +0000 Date: Mon, 10 Sep 2018 23:17:45 -0700 From: Christoph Hellwig To: Atish Patra Cc: Christoph Hellwig , "palmer@sifive.com" , "linux-riscv@lists.infradead.org" , "anup@brainfault.org" , "mark.rutland@arm.com" , Damien Le Moal , "jason@lakedaemon.net" , "ard.biesheuvel@linaro.org" , "marc.zyngier@arm.com" , "gregkh@linuxfoundation.org" , "dmitriy@oss-tech.org" , "linux-kernel@vger.kernel.org" , "jeremy.linton@arm.com" , "catalin.marinas@arm.com" , "tglx@linutronix.de" Subject: Re: [PATCH v3 06/12] RISC-V: Rename riscv_of_processor_hart to riscv_of_processor_hartid Message-ID: <20180911061745.GB15060@infradead.org> References: <1536221135-182613-1-git-send-email-atish.patra@wdc.com> <1536221135-182613-7-git-send-email-atish.patra@wdc.com> <20180910112548.GF12979@infradead.org> <6acd4eec-bdfb-cfc8-6dca-782eb9ec01b0@wdc.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <6acd4eec-bdfb-cfc8-6dca-782eb9ec01b0@wdc.com> User-Agent: Mutt/1.9.2 (2017-12-15) X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Sep 10, 2018 at 06:36:52PM -0700, Atish Patra wrote: > On 9/10/18 4:26 AM, Christoph Hellwig wrote: > > On Thu, Sep 06, 2018 at 01:05:29AM -0700, Atish Patra wrote: > > > From: Palmer Dabbelt > > > > > > It's a bit confusing exactly what this function does: it actually > > > returns the hartid of an OF processor node, failing with -1 on invalid > > > nodes. I've changed the name to _hartid() in order to make that a bit > > > more clear, as well as adding a comment. > > > > > > Signed-off-by: Palmer Dabbelt > > > > Looks generally good, but it is going to conflict with the dt iterators > > series from Rob. Given that this is just a little cleanup it might be > > worth deferring until the next merge window. > > > > Sure. np. I guess the entire series can be parked in for-next until the next > merge window opens. Actually more in your series also conflicts. I think we can defer the patch from Rob as it is very small and simple and can be applied post 4.20-rc1.